From patchwork Mon Jan 22 22:32:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 190427 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:805:b0:101:a8e8:374 with SMTP id e5csp41089dyi; Mon, 22 Jan 2024 14:37:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyXBx8y1fOfJL7Q/3CiWBX9QPQ7AIqqle0WTziWyef3/9zdCupNLb9WVg/GJYY4IerqAkL X-Received: by 2002:a05:620a:2205:b0:783:458e:b1f7 with SMTP id m5-20020a05620a220500b00783458eb1f7mr4342423qkh.60.1705963065617; Mon, 22 Jan 2024 14:37:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705963065; cv=pass; d=google.com; s=arc-20160816; b=mR77AwvZn2wY/+Uzh8izF84vcVVGmTgJOJdoWqbpbjqwcDxwQy8M9Y8tE6tnvJrmdh mfIvnMg5CsIab/ZiZg63MSwBevUl7JsWuS9YvPoNJ3mYz8WSwmrTNCwrJUGu4r7EsZmz BsEPBH1dANOkLn1Ywm6mhX7tGz+uDBCAP1xa0LpafvUTbrbcOotgJMUJeqcXCApMMmGp EV82H2XYpIJGr5GutKN7l98ZnJb9JonuB2MGW5QT4z1S8FjG7Tt6vZhDuJ/DHGNg1nhc RbZOLlqad6rJb3C899zASUjfOOYB/L8+xKLfaxk5nbG+V4GsukvlRgzQPFApD2bY6/tF DUiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4H/QyaTEJT6yM0W34T+DHhl8mPiadWYAfCey1J2x+wk=; fh=ji2KzSHNcfxZY2Sk7vSDYpralpWpy8nozLxVXGWh9Iw=; b=zwnFgbv3As+pMl9zmbd9OhprF5RdK34wk2ZNakUAUAXuIX4JUPaZidkI/uTjw8BkpV +v2+Vl46x3dk3D7MEHRw0Q8T16U31Q5dXd2QjSdH3tcKuWvPEoaP1BAmRODAM8Mu7ESv t4KHgsaGC2/7pdwmN1hiZoYVhA25Al/bcKP92dUbStRYrBTwrCCojuQIUUVZTWqJ+NC7 GyXGRls4B5lTt21Ju9tRgwLLLPboDpcKosEpjn+RqFVjgoitWkzTmhMoHgwE3LDWLAmo o/MngChCflcf61H2Vd6uRoHih5jsigb1AVGW7ZEPZIe1EHgaZiPH/3VYvDK0WIHtQNHE RIag== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JiOC8MjR; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-34250-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34250-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id vv11-20020a05620a562b00b007832e7649c8si6574369qkn.301.2024.01.22.14.37.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 14:37:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34250-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JiOC8MjR; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-34250-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34250-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6874C1C243CD for ; Mon, 22 Jan 2024 22:37:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02AB84D596; Mon, 22 Jan 2024 22:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JiOC8MjR" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AE8C4CB39 for ; Mon, 22 Jan 2024 22:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705962788; cv=none; b=maqQgPfrlpe3PSepD8UGKGV6PpxqLf29enmYWLkgrVRTTt9rFVatTCG2JSjs0ToqbRftdRRDd6k+AURHihjU+NRz+53ppgly3D8nZSSVO1NT5vSTuZuVez4anvOcY/davdTIh48iA9IrehdVywl4Esph5y+nhQ3bjTvvgVesquU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705962788; c=relaxed/simple; bh=u1NZ5oJ45qo+iUmBVeXgQl020jMPO7hETF1JUMYSA/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i72sRgCyX3g48imi7dxLSJFBKZlgbJ1/KZPiipa69ZrI+SzodU9K4ZlERnDqIV40LY4rDVXBiU4hHHuZwJeNTmSmRKjssYWbOjvE/RC1fUcNt60vZzgpoduwkC3Oi7VxIZQvR04rg0rV2dJuZ5zpwztwrmJBH20fhBLOszK77Po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JiOC8MjR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705962786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4H/QyaTEJT6yM0W34T+DHhl8mPiadWYAfCey1J2x+wk=; b=JiOC8MjRAKZhLg6zMF4irsG1AFjsD+CSRWggzrkMa2xwGKrlnixVkGPpABNQxBQqv6KcNR 3MHRDvROcrf0MR/p7x0no6tT9e/9ExpJK0gagnX93EZn7pB3pWm5IFiiUX/Laqb1lk2Wwc QEuRB5tlz8TP/0pxKDf1whDgT+tdBXI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473--HGPYFG7OMq08y4wHZqsJA-1; Mon, 22 Jan 2024 17:33:01 -0500 X-MC-Unique: -HGPYFG7OMq08y4wHZqsJA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F87A185A780; Mon, 22 Jan 2024 22:33:00 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FAB4C0FDCA; Mon, 22 Jan 2024 22:32:57 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Viro , Marc Dionne Subject: [PATCH v2 09/10] afs: Remove afs_dynroot_d_revalidate() as it is redundant Date: Mon, 22 Jan 2024 22:32:22 +0000 Message-ID: <20240122223230.4000595-10-dhowells@redhat.com> In-Reply-To: <20240122223230.4000595-1-dhowells@redhat.com> References: <20240122223230.4000595-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788831927230560224 X-GMAIL-MSGID: 1788831927230560224 Remove afs_dynroot_d_revalidate() as it is redundant as all it does is return 1 and the caller assumes that if the op is not given. Suggested-by: Alexander Viro Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org cc: linux-fsdevel@vger.kernel.org --- fs/afs/dynroot.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c index d3bc4a2d7085..c4d2711e20ad 100644 --- a/fs/afs/dynroot.c +++ b/fs/afs/dynroot.c @@ -258,16 +258,7 @@ const struct inode_operations afs_dynroot_inode_operations = { .lookup = afs_dynroot_lookup, }; -/* - * Dirs in the dynamic root don't need revalidation. - */ -static int afs_dynroot_d_revalidate(struct dentry *dentry, unsigned int flags) -{ - return 1; -} - const struct dentry_operations afs_dynroot_dentry_operations = { - .d_revalidate = afs_dynroot_d_revalidate, .d_delete = always_delete_dentry, .d_release = afs_d_release, .d_automount = afs_d_automount,