diff mbox series

[net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for NET_DSA_MT7530_MDIO

Message ID 20240122053451.8004-1-arinc.unal@arinc9.com
State New
Headers
Series [net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for NET_DSA_MT7530_MDIO |

Commit Message

Arınç ÜNAL Jan. 22, 2024, 5:34 a.m. UTC 
  Quoting from commit 4223f8651287 ("net: dsa: mt7530: make NET_DSA_MT7530
select MEDIATEK_GE_PHY"):

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Now, the switch can be used without the PHYs but, at the moment, every
hardware design out there that I have seen uses them. For that, it would
make the most sense to force the selection of MEDIATEK_GE_PHY for the MDIO
interface which currently controls the MT7530 and MT7531 switches.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 drivers/net/dsa/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vladimir Oltean Jan. 25, 2024, 9:29 a.m. UTC | #1 
On Mon, Jan 22, 2024 at 08:34:51AM +0300, Arınç ÜNAL wrote:
> Quoting from commit 4223f8651287 ("net: dsa: mt7530: make NET_DSA_MT7530
> select MEDIATEK_GE_PHY"):
> 
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Now, the switch can be used without the PHYs but, at the moment, every
> hardware design out there that I have seen uses them. For that, it would
> make the most sense to force the selection of MEDIATEK_GE_PHY for the MDIO
> interface which currently controls the MT7530 and MT7531 switches.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---

I see MEDIATEK_GE_PHY only depends on NETDEVICES && PHYLIB, so it should
have no problem being directly selected by a driver without breaking the
build by causing unmet dependencies.

I also see there is precedent with CONFIG_TXGBE selecting
MARVELL_10G_PHY, CONFIG_R8169 selecting REALTEK_PHY, and others.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
patchwork-bot+netdevbpf@kernel.org Jan. 27, 2024, 4:40 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 22 Jan 2024 08:34:51 +0300 you wrote:
> Quoting from commit 4223f8651287 ("net: dsa: mt7530: make NET_DSA_MT7530
> select MEDIATEK_GE_PHY"):
> 
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for NET_DSA_MT7530_MDIO
    https://git.kernel.org/netdev/net-next/c/fb4bb62aaac7

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index f8c1d73b251d..3092b391031a 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -48,7 +48,7 @@  config NET_DSA_MT7530
 config NET_DSA_MT7530_MDIO
 	tristate "MediaTek MT7530 MDIO interface driver"
 	depends on NET_DSA_MT7530
-	imply MEDIATEK_GE_PHY
+	select MEDIATEK_GE_PHY
 	select PCS_MTK_LYNXI
 	help
 	  This enables support for the MediaTek MT7530 and MT7531 switch