diff mbox series

[v1,2/2] i2c: designware: constify regmap_config

Message ID 20240122033108.31053-2-raag.jadav@intel.com
State New
Headers
Series [v1,1/2] i2c: designware: constify abort_sources |

Commit Message

Raag Jadav Jan. 22, 2024, 3:31 a.m. UTC 
  We never modify regmap_config, mark it as const.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jarkko Nikula Jan. 22, 2024, 9:44 a.m. UTC | #1 
On 1/22/24 05:31, Raag Jadav wrote:
> We never modify regmap_config, mark it as const.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Both:

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Raag Jadav Feb. 8, 2024, 10:46 a.m. UTC | #2 
On Mon, Jan 22, 2024 at 11:44:22AM +0200, Jarkko Nikula wrote:
> On 1/22/24 05:31, Raag Jadav wrote:
> > We never modify regmap_config, mark it as const.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > ---
> >   drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> Both:
> 
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Bump.

Anything I can do to move these forward?

Raag
Raag Jadav March 4, 2024, 7:58 a.m. UTC | #3 
On Thu, Feb 08, 2024 at 12:46:07PM +0200, Raag Jadav wrote:
> On Mon, Jan 22, 2024 at 11:44:22AM +0200, Jarkko Nikula wrote:
> > On 1/22/24 05:31, Raag Jadav wrote:
> > > We never modify regmap_config, mark it as const.
> > > 
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > >   drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Both:
> > 
> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> 
> Bump.
> 
> Anything I can do to move these forward?

Hi Andi,

Are these worth moving forward?

Raag
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 855b698e99c0..d122ef349b1c 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -100,7 +100,7 @@  static int bt1_i2c_write(void *context, unsigned int reg, unsigned int val)
 		BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK));
 }
 
-static struct regmap_config bt1_i2c_cfg = {
+static const struct regmap_config bt1_i2c_cfg = {
 	.reg_bits = 32,
 	.val_bits = 32,
 	.reg_stride = 4,