diff mbox series

[v2,2/3] dt-bindings: input: imagis: Document touch keys

Message ID 20240120-b4-imagis-keys-v2-2-d7fc16f2e106@skole.hr
State New
Headers
Series Imagis touch keys and FIELD_GET cleanup |

Commit Message

Duje Mihanović Jan. 20, 2024, 9:16 p.m. UTC 
  IST3032C (and possibly some other models) has touch keys. Document this.

Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
 .../bindings/input/touchscreen/imagis,ist3038c.yaml           | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Krzysztof Kozlowski Jan. 22, 2024, 10:27 a.m. UTC | #1 
On 20/01/2024 22:16, Duje Mihanović wrote:
> IST3032C (and possibly some other models) has touch keys. Document this.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---

Please provide changelog describing what changed against v1. Cover
letter has something but it is not accurate. It says nothing about this
patch.


>  .../bindings/input/touchscreen/imagis,ist3038c.yaml           | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> index 2af71cbcc97d..960e5436642f 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> @@ -42,6 +42,17 @@ properties:
>    touchscreen-inverted-y: true
>    touchscreen-swapped-x-y: true
>  
> +if:

Move allOf here and keep it under allOf.

> +  properties:
> +    compatible:
> +      contains:
> +        const: imagis,ist3032c
> +then:
> +  properties:
> +    linux,keycodes:

No, this property is not allowed by your binding. I doubt this was
really tested.

Anyway, even if it works, it's not what we expect. Where is the property
defined?

Best regards,
Krzysztof
Duje Mihanović Jan. 22, 2024, 4:25 p.m. UTC | #2 
On Monday, January 22, 2024 11:27:09 AM CET Krzysztof Kozlowski wrote:
> On 20/01/2024 22:16, Duje Mihanović wrote:
> > diff --git
> > a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> > b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> > index 2af71cbcc97d..960e5436642f 100644
> > ---
> > a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> > +++
> > b/Documentation/devicetree/bindings/input/touchscreen/
imagis,ist3038c.yaml> 
> > @@ -42,6 +42,17 @@ properties:
> >    touchscreen-inverted-y: true
> >    touchscreen-swapped-x-y: true
> > 
> > +if:
> Move allOf here and keep it under allOf.
> 
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: imagis,ist3032c
> > +then:
> > +  properties:
> 
> > +    linux,keycodes:
> No, this property is not allowed by your binding. I doubt this was
> really tested.
> 
> Anyway, even if it works, it's not what we expect. Where is the property
> defined?

I was under the impression that it can be defined inside the if statement 
since "make dt_binding_check" ran without any errors. If that's wrong, I'm not 
sure how else to make the property valid only for ist3032c (the two devices 
using ist3038c, samsung-j5 and j5x seem to have tm2-touchkey instead).

Regards,
--
Duje
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
index 2af71cbcc97d..960e5436642f 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
@@ -42,6 +42,17 @@  properties:
   touchscreen-inverted-y: true
   touchscreen-swapped-x-y: true
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: imagis,ist3032c
+then:
+  properties:
+    linux,keycodes:
+      description: Keycodes for the touch keys
+      maxItems: 2
+
 additionalProperties: false
 
 required: