Message ID | 20240119-aoss-printf-annotation-v1-1-27e2ceb8937a@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-31414-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp1155106dyb; Fri, 19 Jan 2024 09:23:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBjk+/kutcrkhcuIhHupwDmefuJF0ZV06ALJCxgFg3mFRFiwyQy2nF8XXuLqR/1jCjWrIx X-Received: by 2002:aa7:9a47:0:b0:6d9:a0da:4fbc with SMTP id x7-20020aa79a47000000b006d9a0da4fbcmr149451pfj.36.1705685037320; Fri, 19 Jan 2024 09:23:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705685037; cv=pass; d=google.com; s=arc-20160816; b=ANhvLoDgWD1Elh4gFSwGSJjYVLffsnjFV+zOQG0/FYP5jJyaA7DxRcas1geSKJ6tZw 1jC29Og2pMmhzpZHp5nznGA4oAr4uvbh4D3XH2sIYUUGMP9h4wkPeYdVKGkdJxNpW7it QO1GdFrp+B8ZVDKojTcwgBl8hjZrUyP+Nqh4/wrIRapBe1/grPvtR6tJE6yQjS0JJzNJ LTlDGbyq18AVXwKxAvTlZj6lwp+WRIzqFqU/XOUrvEX3FJe9RpL35v7jOcdLNu06/ppl 6MD7J5WsfVrymI9kJsmZ+bdGD9mD23gQjRCEP94PjjvRRvBZGdBkLcToNbqSXThCBcfD B3cQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=/c9po2kLn4GNWrPlZorjB2epa8/jXcvXyMhmRkCx4ZU=; fh=zeuk33TziV5GCkek2Ln0HpljJMyKP8bxrlQ0Dq4657E=; b=VKwoLVm1lVE8BZw5rYvEoLM9pnr7uhjFVXmsy7LDZBwk8M8lgOKBPbr373RGxq2nNg W7Jl8SjKY5wZ1RrkPx9H7/l0Rx2TS07s7+Q1qttKfpGUYALTAhHrjWbvI1EYXnHwKmBv hodISb0894ZBhZeI+gRw0qYxEl+rNZp53jGBSFRAkdzFS7k8tCHIQGOyt6jc/+rJaUod Ff4AvPotcUvAnH3c72VktiRmaiX/gtY0tM3pj+q8pYUZT3CLZpri/LuPRl3NNXXJ/A3M KoHR5LLgJQndqD3SrKnRrdH9t46SawAvsLC/6rqFDocLMYehPje/IwxR9g37b6YhnnbE 6rVw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=bgmKuxsi; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-31414-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31414-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d22-20020a631d56000000b005cec91fa47csi3740684pgm.680.2024.01.19.09.23.56 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 09:23:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31414-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=bgmKuxsi; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-31414-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31414-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 81D49B26DD1 for <ouuuleilei@gmail.com>; Fri, 19 Jan 2024 17:18:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E51157335; Fri, 19 Jan 2024 17:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="bgmKuxsi" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5F455C11; Fri, 19 Jan 2024 17:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705684443; cv=none; b=nGK5CR8yHWDIK5KEBmA8i8ghSmiIj8Dxz980nEZkvdDo1RRVWRIqLjEEa7eOojpZ3wIR0ymnX2RV8jgSMwx5wOCfMIaLy+LAvubH9XYGy35EEUO2BIBJAKlKT1myxJrgfJGMuAi5nqK0+f8rFxZhV4pMQd7W7r9dpfHo2+ANjvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705684443; c=relaxed/simple; bh=DmmofHX3KxPaCl6ZMtjjgYNUSvVnR35NX25lwSeOb50=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=lB9fYINkIJrWxebNLd/5CZOFjJmYi7EXuy2aZSnTAna8btnpVUxddbgtK1f9b25GwFSq1auE1r3kQTSea/Ts9kW0AIWRaMcV/fw29LMDjkV1TD6DXyhPXEE7lKv0f2Gn/5JrrKEP0LH++I867F0bFIv0g3/p/7YKP4+JHBIvfAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=bgmKuxsi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40JG12Cj027001; Fri, 19 Jan 2024 17:13:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:to:cc; s=qcppdkim1; bh=/c9 po2kLn4GNWrPlZorjB2epa8/jXcvXyMhmRkCx4ZU=; b=bgmKuxsiFl2/h1zSFp5 ILazcYC3PfBGC52DRv+JL2i66ikbynksb137/Fwk2mUbiMnOKXHssVYkEq/Loil/ l86OCwxM98zZ6ANNTDM7EYzr10oPCADquA4wZTIl9f5khmnIUh6agr62eHfz3Dze juZQw6Ft+wqxPGiCyyMFMfJsnUxUd2ipDJZLL2Fxrh43c6H6/aOWkpN1hIe7eUU/ BeMLCt5tkBC29bW9sB2OFu8cwDo5Dp1/QG66x47sDbAfQaArwXkXG8WbVXG030ko WFInT/7mPeFvwP7ctGHPs5tn4i/zveLCVbiPoA4tTXk0eBK+xyf4zG4kA7YDRwvK /Uw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vqhpb9f48-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 17:13:41 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40JHDeAF000526 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 17:13:40 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 19 Jan 2024 09:13:40 -0800 From: Bjorn Andersson <quic_bjorande@quicinc.com> Date: Fri, 19 Jan 2024 09:13:37 -0800 Subject: [PATCH] soc: qcom: aoss: Mark qmp_send() __printf() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20240119-aoss-printf-annotation-v1-1-27e2ceb8937a@quicinc.com> X-B4-Tracking: v=1; b=H4sIAMCtqmUC/x3MMQrDMAxA0asEzRHETjO0VykZlFputcjGMiFgf PeYjn94v4FxETZ4TQ0Kn2KSdISbJ/j8SL+MEkaDX/xjce6JlMwwF9EakVRTpToIhriG7QhMflt h4Fw4yvUfv/feb0PZS59oAAAA To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org> CC: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "kernel test robot" <lkp@intel.com>, Bjorn Andersson <quic_bjorande@quicinc.com> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1705684420; l=1111; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=DmmofHX3KxPaCl6ZMtjjgYNUSvVnR35NX25lwSeOb50=; b=/8yjevG+EvlfESLtBuioM6X7l/awzZNvu12Vq2pNyoSGJbAXksb7ma+iEYFlEmy7r0pspoeay I5inyTKce7pCrcb3OhMS1ZqjBXOyVil/QCPds2p4Um3KhXCdG50qldC X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: tzwWyyG2CPZtb_KrkwNtHjoz_C2csfPa X-Proofpoint-GUID: tzwWyyG2CPZtb_KrkwNtHjoz_C2csfPa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-19_10,2024-01-19_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 mlxscore=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1011 malwarescore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401190099 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788540393635930481 X-GMAIL-MSGID: 1788540393635930481 |
Series |
soc: qcom: aoss: Mark qmp_send() __printf()
|
|
Commit Message
Bjorn Andersson
Jan. 19, 2024, 5:13 p.m. UTC
As reported by lkp, qmp_send() would benefit from a __printf() marker to
allow the compiler to further validate the passed parameters, fix this.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401100855.UYl3HPPt-lkp@intel.com/
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
drivers/soc/qcom/qcom_aoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
base-commit: 2863b714f3ad0a9686f2de1b779228ad8c7a8052
change-id: 20240119-aoss-printf-annotation-df3d5bdea253
Best regards,
Comments
On 19.01.2024 18:13, Bjorn Andersson wrote: > As reported by lkp, qmp_send() would benefit from a __printf() marker to > allow the compiler to further validate the passed parameters, fix this. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401100855.UYl3HPPt-lkp@intel.com/ > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Fri, 19 Jan 2024 09:13:37 -0800, Bjorn Andersson wrote: > As reported by lkp, qmp_send() would benefit from a __printf() marker to > allow the compiler to further validate the passed parameters, fix this. > > Applied, thanks! [1/1] soc: qcom: aoss: Mark qmp_send() __printf() commit: b65a3fa38dbb5c84f360a48f0d5da3aed0011964 Best regards,
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index aff0cfb71482..9d7a74767008 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -214,7 +214,7 @@ static bool qmp_message_empty(struct qmp *qmp) * * Return: 0 on success, negative errno on failure */ -int qmp_send(struct qmp *qmp, const char *fmt, ...) +int __printf(2, 3) qmp_send(struct qmp *qmp, const char *fmt, ...) { char buf[QMP_MSG_LEN]; long time_left;