From patchwork Thu Jan 18 20:31:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 189183 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp305736dyb; Thu, 18 Jan 2024 04:33:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFl+itxtrc/UKr2dFcstrOrvJ8FBSbuTwBknnYGh9MGJ+YNhoqpdECNMTOkqiIZ3URUJ3Yq X-Received: by 2002:a05:620a:15b4:b0:783:4e6e:4e58 with SMTP id f20-20020a05620a15b400b007834e6e4e58mr629775qkk.128.1705581235706; Thu, 18 Jan 2024 04:33:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705581235; cv=pass; d=google.com; s=arc-20160816; b=oG5TZp5rQjsW45bVtIvRJA6Prjo9Tsbviy7Zu6M/A9u/+8A062FltljCN+WtZOnTFK ZZr/gdWQsh05wxzOeGjT0h/teXJ2W+O8faiQLjtVjkTyOJtW7h1UuH94qPzOhkhrwWpZ SlJjag/MMkOX9XJ0v5HhSh1eaTIvYjJixj7E5jLrwjp7xnpkjfmEDZBr3G0m2SJapkef 1EXPYwU0f4O6JB7EA6j3eYozrUcItFhMFuQV+F6BflZa+M1omjJHDkavH6bmtWiv/WYp huc5jlFEALkXMcHDDpdvL/MwVzg39YkTeITtvb8UZJI6PP2lmgnh6/BvRl1ld657GzwB o4VA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from; bh=JlP6c3yi8O5EknEjRyHrK/Vnm2SCt3yE8BO5OF7OgAY=; fh=jQeqwxZYu9epgFztZAh3mGzJVfySkvEJFuXSwKls42g=; b=NHEKuscO4guLmoAZ0hjUjy2dOAXE/WCsJR7/OprIKFouQuELvYSguJH4QuIAJom/2P jJN2YNiIH9bM9zndtSUI5lwtMJc2BpkClds58b9oJPDRzb+vZEl1h4kg1L0R+fvD4Neb duFl44qSDD0dRIZ5p+kjJPMp4I2Y5WPua+xOG2rHYk7AO+Xc7OwwgbemfviekORrkH5C T8XRTxHCLxs1krapYeBHNI8R89cRYuO9hGqmrsPKRZKr3cHckNx0Wne8rKxNPTjo/29X NdRMvSwzeAmwXvdYtOxQKx1NNI37qwnk77FaA2t/lMXXymON1ybevh9YnRcWTHml3+9L H1Wg== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-30096-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30096-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y17-20020a05620a44d100b0078347fb3382si13342493qkp.376.2024.01.18.04.33.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 04:33:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30096-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-30096-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30096-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 804FB1C223D8 for ; Thu, 18 Jan 2024 12:33:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C57424B56; Thu, 18 Jan 2024 12:33:42 +0000 (UTC) Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A652A33FA for ; Thu, 18 Jan 2024 12:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705581220; cv=none; b=B7/KbdlfOJLBvN6cxZNEnT06nWTzpjZdh37XL61pO0XrCFj2ozdGNNN7xAo9e94OSzUiFkCZ6IkK5uNX8CVpql0NR5DqrlZzvMXOg+K+BueL0mVWB0ubnvXvJetLMVyLt6PuFrrg+w8uVGI8M2mTbvw+4MYu9XQHJnHhOfu+ges= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705581220; c=relaxed/simple; bh=bXRtTkMsQOcByH1DqJEtaBQEU/8SZM69SRf+aMse1Nw=; h=Received:Received:Received:From:To:Subject:Date:Message-Id: X-Mailer:MIME-Version:Content-Transfer-Encoding:X-CM-TRANSID: X-Coremail-Antispam:X-CM-SenderInfo; b=h7hRJrr2H3ASWY/ZgWV/faH1WLe2rzIly0uSPuGamFXT8xMfrEFn8WYpJh3GakZKng5LMM5jx0NyOH/0JZLXz97XDv37QF8FyCIGwcniPqkBnBUOt3qudWu3sL7MZGCHutWJIL9xgy6E/3jtqQ+B6rouuswW//YiQudRLsm0tKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4TG2Gc3jkKz4f3kFh for ; Thu, 18 Jan 2024 20:33:28 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 49E9B1A016E for ; Thu, 18 Jan 2024 20:33:32 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAnLW+aGqllR6blBA--.39914S2; Thu, 18 Jan 2024 20:33:32 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] writeback: avoid to move skipped wb in offline_cgwbs list Date: Fri, 19 Jan 2024 04:31:19 +0800 Message-Id: <20240118203119.764016-1-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAnLW+aGqllR6blBA--.39914S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZF4xCF18Wr17CrW3GF48JFb_yoWDtFX_ua 9Yvr1UGrnxursY9Fya9a4UXrZYkw4kCr17WF40y347A3yUAr4DuFWkJFn7Xry8XFWagrWf WrZIvw45Gr1q9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb7AYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl8c AvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7 JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oV Cq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG 8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2js IE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY 0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I 0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAI cVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcV CF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2 jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU0miiDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788431549703595225 X-GMAIL-MSGID: 1788431549703595225 There is no need to move skipped wb to local list. Only move wb which is going to be cleanup to avoid unnecessary work. Signed-off-by: Kemeng Shi --- mm/backing-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 039dc74b505a..681548f848c5 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -773,8 +773,6 @@ static void cleanup_offline_cgwbs_workfn(struct work_struct *work) while (!list_empty(&offline_cgwbs)) { wb = list_first_entry(&offline_cgwbs, struct bdi_writeback, offline_node); - list_move(&wb->offline_node, &processed); - /* * If wb is dirty, cleaning up the writeback by switching * attached inodes will result in an effective removal of any @@ -790,6 +788,8 @@ static void cleanup_offline_cgwbs_workfn(struct work_struct *work) if (!wb_tryget(wb)) continue; + list_move(&wb->offline_node, &processed); + spin_unlock_irq(&cgwb_lock); while (cleanup_offline_cgwb(wb)) cond_resched();