From patchwork Thu Jan 18 22:36:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charlie Jenkins X-Patchwork-Id: 189355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp663827dyb; Thu, 18 Jan 2024 14:37:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLULh7/XYy6sTGcObzZ06cvaZg++toHGZVJTKaFxydVRi7P3JwNM8eeNLp1RzeZnupAmfo X-Received: by 2002:a17:90a:f195:b0:28e:6fc4:7c6c with SMTP id bv21-20020a17090af19500b0028e6fc47c6cmr1388417pjb.87.1705617438240; Thu, 18 Jan 2024 14:37:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705617438; cv=pass; d=google.com; s=arc-20160816; b=Z82ckL0TE1Tc3Wj6qnBRKGU940+GCM+3mx8csGVzTnft7NuEYb439nHRVUJtDkPPYx gt2OIlCyAdTM5UlIGA9lKJxuCSI1sxNMflmvcOsXt+yUFyWKuSEQVwXz7+LDcvatZuHH gtBRNVcPnTI/Pe8gs+PAGCgMHAg2aITwSQqbyDxsywC/wpfypB5/PIj2dPuGgt6E0auW tSw7jEzf8RBerdCEmy28yYz5nH3LtwcHz+1Q7xYwJDRzqiFLF/Vcz8H9PXKytNxzxSFM TGju9ue82lCx9tmUpnBLsIuMaZJskBdKHzNEbLupSc13RqvHN0uXNrcAvuibU9FsgFEt rWag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=22psKGJ5/XvThdwDSK02VziHgNEv3yYHumxnTIri9Ik=; fh=Q3S7ZgH7Zm5APQA66CHOxj7VLxBfQoZXcjv40qXT1hk=; b=q7Bx+SmZv6bQWZOuQHA5Y/nSRadC5xbo1dACQTcq2pIDAZomj6BBCOhS2O/vJbnKic oh5WS+/sOabmahEuHzb3AqJe5W4r6DJ5T4610S2nwdp2RkmNllbdcXRjie6Wq+6SlnqJ XJvgnG1CYeXdHMnYmerPZaBI168rgm5xKdz1PfsCVayapcyUYe6CH8hN96CabIUMQRUZ 9bZgzMcFhOdaqeGO+U4VssVaimtAea+C9k8ABANHa/UnTnslNznbaBE2Ag7O6Jf2KgYi mVEwwZDVx7NY0IIEug1xjp0FAdyYSzsB7S1Qf/6WuqPNP2OHWpgvgCOqTiuKC6EfTr/J 81/g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=17TjdaQq; arc=pass (i=1 spf=pass spfdomain=rivosinc.com dkim=pass dkdomain=rivosinc-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-30605-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30605-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bz9-20020a056a02060900b005c66af62bacsi2270937pgb.174.2024.01.18.14.37.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 14:37:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30605-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=17TjdaQq; arc=pass (i=1 spf=pass spfdomain=rivosinc.com dkim=pass dkdomain=rivosinc-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-30605-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30605-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D58C728645A for ; Thu, 18 Jan 2024 22:37:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D21D1DA4D; Thu, 18 Jan 2024 22:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="17TjdaQq" Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F7379CD for ; Thu, 18 Jan 2024 22:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705617409; cv=none; b=PYxETq71suQnCtd50Umn6fzo+Ae76ncmydtH7Kca9bmHGXCQuqRTz8ysUV/9WRJ4cqaqPKGwcz/1L00ieMFKEpUvbPAOQaIe/hwohT3YMkHCYTyl5NhdjoBlbJ99li8f8w9rq4OkFqgjJF8pTyCHbCgeO7TufBfUw5LFTlxw140= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705617409; c=relaxed/simple; bh=Ewf2ArCyVhqQECvgVJiy2phXnKTeR3STay2OCvwENw0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=g9sSfAkHbQG0xA/IXxQYA4okGFIorjT2PQU3DRxwrdpJmG5dBg3IPTl4KDcSWJyP6/i6LLwZ2ip4J1QZwwMrSP4nRAhJXbeyW0k9APKRorIJ7YpWEIfQI/2oDwKlHALZReDiOs72fiaK+IJPEB/zC20r2wpdt88L4pOw3+nviYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=17TjdaQq; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6dac8955af0so193499b3a.0 for ; Thu, 18 Jan 2024 14:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1705617407; x=1706222207; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=22psKGJ5/XvThdwDSK02VziHgNEv3yYHumxnTIri9Ik=; b=17TjdaQqeF5TG59QM+epASHEr+TKtUeYfAJy0fteKj3miqO+qeyFh2szePcOBto2p2 pcjCGH1YJHTX991PvAWAZu9EP3F7udcGmwu7Y4guembRmaOxGKjDlDdklymyu0NlxKh2 cd5sav0RvdfTH1HfWnPcX2qTu0etqmLYxc473mFIteqt9pp6V1s09tkGMibFw/sOifLU AWUJDHcRYVQ7mBVjU7/PtBAJ3p19lKM3oB88CyI0iMEY1S6jlL/jtSxeB6TRWLjQ7bGY 7PxSCTIdqecNiEzHL9IrBADPE25BG1zMH2KJy8VzsbL4G2zvMROxhN9z3/RoxqIJKNUQ IkUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705617407; x=1706222207; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=22psKGJ5/XvThdwDSK02VziHgNEv3yYHumxnTIri9Ik=; b=gUVovTBDD5Eq8rXLGF6t8CPc7v2GGOrTZ6rTle7h2stZkThDK3Witz7FXYB3IONHdJ 0m8eN9nQqTQi5kjfOmEQ2vsOZFiRGmIJ+YEl9H3RVW64lwxa08ZBBbAieJbeYcJSH7J4 Oqdral/f29E6CicK3tVJXZnyjXLqbsG/nfwUWOhU2Z82oR1TTriP6vKtt465/eCdSNMS fqHw6D04t2Gh+JxQOc86cLvXdCtPEUdJzPK11jqhynWObh6bKjLDXro7Xpmemm/YkXkC XhCfpcunr/BXZspjS0s9Nyuz41zvxynLjMjJH3vnP5NP+mRAj3wvrqbfSMrX3I5VfcvN lEtA== X-Gm-Message-State: AOJu0Yy32i7wVWPWcVsF9MAqsQx9yKr4DQUtXe5cbdF6IBQ3xfWJxCEC B0kw/MMBnRbXE1KKhQ99x+y9bcVr+HHfm+l9LViq7iGcAVTMSnZU99zdhQ4PpGLr0QhqH6m54EC n X-Received: by 2002:a05:6a00:2308:b0:6db:9684:defe with SMTP id h8-20020a056a00230800b006db9684defemr1482192pfh.8.1705617406785; Thu, 18 Jan 2024 14:36:46 -0800 (PST) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id t34-20020a056a0013a200b006da13bc46c0sm3904979pfg.171.2024.01.18.14.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 14:36:46 -0800 (PST) From: Charlie Jenkins Date: Thu, 18 Jan 2024 14:36:45 -0800 Subject: [PATCH v2] riscv: lib: Check if output in asm goto supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240118-csum_remove_output_operands_asm_goto-v2-1-5d1b73cf93d4@rivosinc.com> X-B4-Tracking: v=1; b=H4sIAPynqWUC/5XNQQ6DIBCF4asY1qURQmrtqvcwhihOdRYwhkHSx nj3Um/Q5f8W79sFQ0Rg8ah2ESEjI4US+lIJtwxhBolTaaFrbWql7tLx5m0ETxksbWndkqUV4hA mtgN7O1MiadpWa6eMctCIcrVGeOH7ZLq+9IKcKH5ONavf+ieQlVTSNO7W6HFsJzM+I2ZiDO7qy Iv+OI4vzXL07tsAAAA= To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Charlie Jenkins X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1705617405; l=1498; i=charlie@rivosinc.com; s=20231120; h=from:subject:message-id; bh=Ewf2ArCyVhqQECvgVJiy2phXnKTeR3STay2OCvwENw0=; b=8j8Lc3kU83hQIjeeCFyK7o9YgcEczbHdmRGsbhtSGH1IrtSy/F8ki8oeXrvzdncHyn2Ia3Ld9 x+nDNC7CGyfBtpWARLnVleMssPBiXVhl4azmSkd8VdXYfkkMD2pn8pt X-Developer-Key: i=charlie@rivosinc.com; a=ed25519; pk=t4RSWpMV1q5lf/NWIeR9z58bcje60/dbtxxmoSfBEcs= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788469510975294374 X-GMAIL-MSGID: 1788469510975294374 The output field of an asm goto statement is not supported by all compilers. If it is not supported, fallback to the non-optimized code. Signed-off-by: Charlie Jenkins Fixes: a04c192eabfb ("riscv: Add checksum library") --- The OutputOperands field for asm goto statements is only supported starting from GCC 11. Split the asm goto to remove the use of this feature. --- Changes in v2: - Use CC_HAS_ASM_GOTO_TIED_OUTPUT - Link to v1: https://lore.kernel.org/r/20240118-csum_remove_output_operands_asm_goto-v1-1-47c672bb9d4b@rivosinc.com --- arch/riscv/lib/csum.c | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 080c4324fa5e81ff3780206a138223abfb57a68e change-id: 20240118-csum_remove_output_operands_asm_goto-49922c141ce7 diff --git a/arch/riscv/lib/csum.c b/arch/riscv/lib/csum.c index 06ce8e7250d9..af3df5274ccb 100644 --- a/arch/riscv/lib/csum.c +++ b/arch/riscv/lib/csum.c @@ -156,6 +156,7 @@ do_csum_with_alignment(const unsigned char *buff, int len) end = (const unsigned long *)(buff + len); csum = do_csum_common(ptr, end, data); +#ifdef CC_HAS_ASM_GOTO_TIED_OUTPUT /* * Zbb support saves 6 instructions, so not worth checking without * alternatives if supported @@ -214,6 +215,7 @@ do_csum_with_alignment(const unsigned char *buff, int len) return csum >> 16; } no_zbb: +#endif /* CC_HAS_ASM_GOTO_TIED_OUTPUT */ #ifndef CONFIG_32BIT csum += ror64(csum, 32); csum >>= 32;