From patchwork Wed Jan 17 08:57:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 188726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp778588dye; Wed, 17 Jan 2024 00:57:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGA91XZM2j5Uq/KXtZGBonVOQl5zYWJ0ttuqiRFjhEEqqTQIvTepMlLNgMgNPiWU9prhl/y X-Received: by 2002:a05:6358:415:b0:174:b1f1:85bd with SMTP id 21-20020a056358041500b00174b1f185bdmr5688837rwd.39.1705481871854; Wed, 17 Jan 2024 00:57:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705481871; cv=pass; d=google.com; s=arc-20160816; b=J9nj/WMts+Zk0bDwtA43VFTXx2q8psOV8/y6zwca5Azbbr1ixv5inSGZbqCrzZeiZF WfA2kjlXssr8ZfZUGl05so6dMC+cS4DwJG8xMvPF5r4sY4LX13DLJklE35oru6hR5+oX DdO479EOZScQO8tT3L7E36faCMbGsbaCZLZLQzW920utCFMBsVYUoS8S4o86ARDmPMRB ioltk3MrTEnrZ2XynMu2NMYGRWJaz+NKxc3ynsJ0RFyaTlPGFpB7L++iEjQshLkcEhuo 18DXV/dJCXpD3BQGCgW0jAgynpWgQBQ+5CcYg8+hKxh3Fy/2pXe4XRawVYppzbYknBF2 GYpQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=PlAHTj7ixrkXoxKN4kr+Q6lS3AByIpzUspdeFL7oqtY=; fh=2ooNcWiF1wbXc4MOpItQ0J3HmpaFWSgX1s64XQR6nBA=; b=rB969zFfM4HzvbUY+/qUnVWgI3zHoSE8zydfRMl7EKc/DPUBlLt/zJjp7GZMl37D1/ BFvTFHS+y4enxRljyNS3GnPfYdVeeTgjARSuOf7wGpXBKxw7C9+Kxc3GO+OKYwvGWwCX psEJxpIIpH4nOtdGeLBw7QmxN9LiGL0trrqwzTSToJ/gvRZQ8NdEYQTatkWw/pAIcpWS YuU15+aLPaunBd0nLC6lyOAnrfs2pQkWUcung8uxmY30L80pYchBPOokbN/y1PrBaNSd g/I2JpLjytm2n+OIxnvXB1tgy+70zMQGKoleA5ENzo2TojL7oHIW2ruKYb3xJRsNmeXO hsVw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sr4207a5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-28673-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28673-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i17-20020a17090acf9100b0028bbcd027aasi15863361pju.94.2024.01.17.00.57.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 00:57:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28673-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sr4207a5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-28673-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28673-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 984D8284859 for ; Wed, 17 Jan 2024 08:57:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D40DE1DDFA; Wed, 17 Jan 2024 08:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sr4207a5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354741DDC8 for ; Wed, 17 Jan 2024 08:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705481762; cv=none; b=dH/RMScGauWz3Tqz8x9zLFb1hr+2BLkWdUCk/rVfibdUAXwp6FZj/nplgId5WnfieLlTwib2QFiRMSOoUztpZ1NyUJgdqfXTtpXpquWzxPHf1B5A8Sg3nHI6YuQqDmWKUM099IOtgaKgQbLmeALJXUPZi0fQFQMRRelccMs6lvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705481762; c=relaxed/simple; bh=1gKV14yFhqUD2HBstqbx5w7q3LD/bVO0O+RqRHy8IH4=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; b=AXHo1F7XOnK1aYIeCqiogaVmKe1r2hUQEdmwGtJCqdhr2conx2ZPlW7Jl/b9jEmNDJaz8XQrQ1rd8tEIbeMiCL72oEzfJpJ7WLtT5twmQilELx79aOhrYqnPHLgeRhSQqxJ1i1cn8p7z9BayHqYqK9msdJPX7oTtfxKHKo8wM+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sr4207a5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47565C433C7; Wed, 17 Jan 2024 08:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705481761; bh=1gKV14yFhqUD2HBstqbx5w7q3LD/bVO0O+RqRHy8IH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sr4207a50yCvAIl6nyqEr2IDuKxVplkzQScr+Xb9bXG7YxCon8rmCgEIgJYJmj1+N rTyxiekUrGahQUF5ID/RaaPDjPoAPCPCztaRR7CHmDYIDMqr5Mmkxz/0St5M1zvQPf F7cGQYQYDMS/y9MakUZGDkbZqxYUej039o7BlZZh5u0mNccL3kNeaNp9NhO15Vx4Z6 Z6DeaL/uahPcGuICiAYAkiXPngYbp954pa2nZ3XNQwQL+Xh2Wh1BOp6br2nOse/Nh2 n0SGlMzpk/RKOMXFLQmdslkjMDOjczRQElwk6pV51A3NkfCx3ksx4hGerf7gCozq+c l/XGmc+3qdYOQ== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Cc: Alex Shi Subject: [PATCH 2/5] sched/fair: remove unused parameters Date: Wed, 17 Jan 2024 16:57:12 +0800 Message-ID: <20240117085715.2614671-2-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240117085715.2614671-1-alexs@kernel.org> References: <20240117085715.2614671-1-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788327358797089001 X-GMAIL-MSGID: 1788327358797089001 From: Alex Shi sds isn't used in function sched_asym(), so remove it to cleanup code. Signed-off-by: Alex Shi To: Valentin Schneider To: Vincent Guittot To: Juri Lelli To: Peter Zijlstra To: Ingo Molnar --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 46ba8329b10a..8d70417f5125 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9750,7 +9750,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) /** * sched_asym - Check if the destination CPU can do asym_packing load balance * @env: The load balancing environment - * @sds: Load-balancing data with statistics of the local group * @sgs: Load-balancing statistics of the candidate busiest group * @group: The candidate busiest group * @@ -9769,8 +9768,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) * otherwise. */ static inline bool -sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, - struct sched_group *group) +sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group) { /* Ensure that the whole local core is idle, if applicable. */ if (!sched_use_asym_prio(env->sd, env->dst_cpu)) @@ -9941,7 +9939,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check if dst CPU is idle and preferred to this group */ if (!local_group && env->sd->flags & SD_ASYM_PACKING && env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && - sched_asym(env, sds, sgs, group)) { + sched_asym(env, sgs, group)) { sgs->group_asym_packing = 1; }