diff mbox series

[1/1] of: property: Make 'no port node found' output a debug message

Message ID 20240117083206.2901534-1-alexander.stein@ew.tq-group.com
State New
Headers
Series [1/1] of: property: Make 'no port node found' output a debug message |

Commit Message

Alexander Stein Jan. 17, 2024, 8:32 a.m. UTC 
  There are cases where an unavailable port is not an error, making this
error message a false-positive. Since commit d56de8c9a17d8 ("usb: typec:
tcpm: try to get role switch from tcpc fwnode") the role switch is tried
on the port dev first and tcpc fwnode afterwards. If using the latter
bindings getting from port dev fails every time. The kernel log is flooded
with the messages like:
 OF: graph: no port node found in /soc@0/bus@42000000/i2c@42530000/usb-typec@50
Silence this message by making it a debug message.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/of/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Jan. 19, 2024, 11:12 p.m. UTC | #1 
On Wed, 17 Jan 2024 09:32:06 +0100, Alexander Stein wrote:
> There are cases where an unavailable port is not an error, making this
> error message a false-positive. Since commit d56de8c9a17d8 ("usb: typec:
> tcpm: try to get role switch from tcpc fwnode") the role switch is tried
> on the port dev first and tcpc fwnode afterwards. If using the latter
> bindings getting from port dev fails every time. The kernel log is flooded
> with the messages like:
>  OF: graph: no port node found in /soc@0/bus@42000000/i2c@42530000/usb-typec@50
> Silence this message by making it a debug message.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/of/property.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 641a40cf5cf34..a02a985c13baa 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -665,7 +665,7 @@  struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
 		of_node_put(node);
 
 		if (!port) {
-			pr_err("graph: no port node found in %pOF\n", parent);
+			pr_debug("graph: no port node found in %pOF\n", parent);
 			return NULL;
 		}
 	} else {