From patchwork Tue Jan 16 14:11:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenjie Qi X-Patchwork-Id: 188534 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp281446dye; Tue, 16 Jan 2024 06:12:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGejv0N5Z4KsDFguWR1f7r0LGHIzKhk9gc/7Bv1/ggcZgUpOtTSVqPnWy9KA1v4sKhU6zSA X-Received: by 2002:a6b:c8ce:0:b0:7bb:ea22:15 with SMTP id y197-20020a6bc8ce000000b007bbea220015mr9472927iof.22.1705414327106; Tue, 16 Jan 2024 06:12:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705414327; cv=none; d=google.com; s=arc-20160816; b=vsCyteFmmTXEVDDsfbYLwDvyiHxnA4e9YomAJpR80R75wAwp8yTRKrLlSTaCKjIhMT Wb9XjPQ31a1Hr5tC8RjNtoSSxLkYTH8udlPQhnI4TYgE6a5cP+8H/9L6VYqF37tPFw+1 Suyoan9a4BgbRBVoHvA+t1zI0AV5ae3pMLlf+uDJFlaUJFcyFhGzi4v+m4jUgMKFEpYC 94OIZk3sFuub2eMtOqy5V7w+Hn+yKa79gnBxBpR+fjtTLa0Qca6axA72cTMTmL/493A/ QZbseUAot8inYgAzxWk0yBGUnTRjW0LFCiX9SkVwRMAqTCcPA3B+z5h8sE9rjOD5uFFA QGKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=MOUL5DN5/vRjV29nTf1iYQ4XDWDI92V1Uhs1Q/SpfUY=; fh=nDl6znmQbhlaWAOtC9VQsGq/L9X4vKYd1lZnUV6gntg=; b=WCRXORG7L6F8oJ8t+wKFJ81ctJLgqyFZA8TYrevVkW4JAe3UNojbQK7MB1boVd/8c0 ZdZ9/RGBd77BT+lfT/8mriH7x98NnBcCri1HISPxgsVbGhtxY4Kh4A2gDmaltlWQkeUG KhBp8jiwXOJ0qNCWcb9TXHnYJt6q48W6+AiX0eRRL8tVwO0LLRnqX6wwxnwZNjbiS1/6 B+X+q28wWSWVyy/yVr/SrWbmoV1rPTtjfUMpEGds1W8mTnUnxJjwaw7GFfdzjAsFXNNB fRhANQEknXJ8aLmc0UxVlzRCnnWRUZWRAF2rxvS/68UDR5tS7UhxkMF1889t26XJPOhl BjtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=Olrpyaog; spf=pass (google.com: domain of linux-kernel+bounces-27455-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27455-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q24-20020a63e218000000b005ce018f428bsi10697874pgh.681.2024.01.16.06.12.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 06:12:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27455-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=Olrpyaog; spf=pass (google.com: domain of linux-kernel+bounces-27455-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27455-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DAFC528520F for ; Tue, 16 Jan 2024 14:12:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D7BD1BF27; Tue, 16 Jan 2024 14:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Olrpyaog" Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F741BDE7 for ; Tue, 16 Jan 2024 14:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d5ece717aeso3316385ad.1 for ; Tue, 16 Jan 2024 06:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705414313; x=1706019113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pwGjvXloGvIfAhj2uR+wy0smwtrFBrVoNPSps/xZwaQ=; b=OlrpyaogntkooKtRS6Q+CDvit4gOLBcuP48zQryIA/etz/j0OshxAYKnmVhl1tlvve SCpkhJx7qIuHpHMI2T6eVWZOTz/yMHomzQjtbulcVnAAUvyoJzc5RqIzpBIm+vTU3g5d AIJK7K+gLLYbFu1gu6uIq6j579q0QEGNtrvtxhVxamNhvQzlSX/e3Vl229PjmzUTTyGo vMZVPbUNMlepi+kil6lTKetitzxQuNxf63/wjUJO2vyD4pEC6bNy82j/e1DLYfztrN6K P2ABnxUK/S2eMgSuoAttrHkwphpiuuemM2HordJYHrEm1KNfTNJyPsAksVvOTEZtaKTM ALTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705414313; x=1706019113; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pwGjvXloGvIfAhj2uR+wy0smwtrFBrVoNPSps/xZwaQ=; b=kxbJu/ugHJXq5FQZimAfLDCAmon1vcN19Ac99MXzcKwEJlZqGCt8xDkkx8LyfmcQoN YJElvXEsaQq2ifqQ+FnbMgb5Jluvu0egIUszzOffv4C6bS6B0DvcZk2Cp2YFkQ2dt9uU gibSMIYaA0OAzBp3XJrhVHXbca2NKCDg1WYkRnfsxVtcOaC7Yzs9oBbagS9blTERaeTt BYCSakwvUKBC0RM38qWtCDbfIAnuFTn0INXKBlwywyYvtuOVauAEhzrSTF2McL8MCLJs AJwBAGQ4ywl9AzNU/X47iOHTBlDW+pZ3JXUoxPEdZF7y/wPokILtaFo1H7Tg+n6oCkMF DA4Q== X-Gm-Message-State: AOJu0YysynFwOnOgZorj3QmGqOmBeTc+JB9SqH47FD2RYaiK1+vJTy12 eHAeVQ1OGnsHEWfZVeEjIlY= X-Received: by 2002:a17:902:eccf:b0:1d5:b797:fdc with SMTP id a15-20020a170902eccf00b001d5b7970fdcmr2922442plh.131.1705414313502; Tue, 16 Jan 2024 06:11:53 -0800 (PST) Received: from localhost.localdomain ([2001:250:4000:8246:8dd2:f82d:e185:367f]) by smtp.gmail.com with ESMTPSA id p19-20020a170903249300b001d5c38d720bsm4360242plw.2.2024.01.16.06.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 06:11:53 -0800 (PST) From: Wenjie Qi To: jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: hustqwj@hust.edu.cn, Wenjie Qi Subject: [PATCH v1] f2fs: fix NULL pointer dereference in f2fs_submit_page_write() Date: Tue, 16 Jan 2024 22:11:38 +0800 Message-ID: <20240116141138.1245-1-qwjhust@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788256533317063022 X-GMAIL-MSGID: 1788256533317063022 BUG: kernel NULL pointer dereference, address: 0000000000000014 RIP: 0010:f2fs_submit_page_write+0x6cf/0x780 [f2fs] Call Trace: ? show_regs+0x6e/0x80 ? __die+0x29/0x70 ? page_fault_oops+0x154/0x4a0 ? prb_read_valid+0x20/0x30 ? __irq_work_queue_local+0x39/0xd0 ? irq_work_queue+0x36/0x70 ? do_user_addr_fault+0x314/0x6c0 ? exc_page_fault+0x7d/0x190 ? asm_exc_page_fault+0x2b/0x30 ? f2fs_submit_page_write+0x6cf/0x780 [f2fs] ? f2fs_submit_page_write+0x736/0x780 [f2fs] do_write_page+0x50/0x170 [f2fs] f2fs_outplace_write_data+0x61/0xb0 [f2fs] f2fs_do_write_data_page+0x3f8/0x660 [f2fs] f2fs_write_single_data_page+0x5bb/0x7a0 [f2fs] f2fs_write_cache_pages+0x3da/0xbe0 [f2fs] .. It is possible that other threads have added this fio to io->bio and submitted the io->bio before entering f2fs_submit_page_write(). At this point io->bio = NULL. If is_end_zone_blkaddr(sbi, fio->new_blkaddr) of this fio is true, then an NULL pointer dereference error occurs at bio_get(io->bio). The original code for determining zone end was after "out:", which would have missed some fio who is zone end. I've moved this code before "skip:" to make sure it's done for each fio. Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu --- fs/f2fs/data.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index dce8defdf4c7..4f445906db8b 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1080,10 +1080,6 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio) io->last_block_in_bio = fio->new_blkaddr; trace_f2fs_submit_page_write(fio->page, fio); -skip: - if (fio->in_list) - goto next; -out: #ifdef CONFIG_BLK_DEV_ZONED if (f2fs_sb_has_blkzoned(sbi) && btype < META && is_end_zone_blkaddr(sbi, fio->new_blkaddr)) { @@ -1096,6 +1092,10 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio) __submit_merged_bio(io); } #endif +skip: + if (fio->in_list) + goto next; +out: if (is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN) || !f2fs_is_checkpoint_ready(sbi)) __submit_merged_bio(io);