From patchwork Tue Jan 16 11:07:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 188496 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp178698dye; Tue, 16 Jan 2024 03:07:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoSDAteOZGrQx47L7k7cKx8Z1WoaXB751Hcsy4lzcQgA/sLm2jFIEf4UnZPA7qL/OO9hIx X-Received: by 2002:a05:622a:54d:b0:429:8c90:4d2b with SMTP id m13-20020a05622a054d00b004298c904d2bmr9984094qtx.69.1705403267767; Tue, 16 Jan 2024 03:07:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705403267; cv=none; d=google.com; s=arc-20160816; b=msnrM5GnMKpyXwgoirGsgYawhANQvzNB7igdEtikA9adDB8QH2vP7fJuVU4DIicVrj Adz5j60N/k2I8AYPlT59mTYvUfcnlsq0WezbSmhH7qroqMIvWT9x0Bz8V0Yi9e779nfh b0Yw4JyajQ9uQXni7jzpwZt75T/RQKauzThKmF46DLjb/F/L58mY1RjPMN9/IlebERLY s2BOj5749mifbgM45mVzj3oSt645r4Ws4XxOUay8jGaW7mmUhuAgNn81J8atozO6TiKm xj4qtSfm3qtKwuTaUjfvqtpg6SKW86GqArdgEgY1N5fhe5RwJgEaxbmZLs7CC2CgZShS ZtBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=QVAGc4XL3xs1uMSry25G+l6Lbj7TMq/VrUzFoxhkoKU=; fh=XG4WW3CNAL509GDoc/W3Ryl++WqlrKFHTUxG5J6uH4c=; b=lj/0b1DM//ICaIsLp71nQr4H0xKeay9rnbQyj3aJI5Z5QBUy8a/SEJzqHyqTQcr5xZ mVFYXIlEvMJgSG5j13VqhUcAkYSuOMntH4fzuOaObVyvjeeo8RYc4bwZdAWC4Sh+9TI4 3msma2mid4FZ5wsJ5Ylbab7sQFuNbF3U8LB1HB+PtGyuP/1iqnfoF0Zrl34Zc7FmFJWW b4g+IVqGFiX8Y/+nOBkJNTYwT7SxTCTBDmzqTOZu12HLd2e/71R/5SfG3hKqHnvryx52 QDbxllfZwxGSIbEhHhIoomnzDsuzEIzEKerNm7sZpcvy/p9ZjfpjkqWJxXXimOvnpgkV eOng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lzTL8GnA; spf=pass (google.com: domain of linux-kernel+bounces-27289-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27289-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id p9-20020a05622a048900b00429986b74a3si9706839qtx.748.2024.01.16.03.07.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 03:07:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27289-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lzTL8GnA; spf=pass (google.com: domain of linux-kernel+bounces-27289-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27289-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8EA521C22F78 for ; Tue, 16 Jan 2024 11:07:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10A621A71C; Tue, 16 Jan 2024 11:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lzTL8GnA" Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69121A590; Tue, 16 Jan 2024 11:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50eaabc36bcso11965667e87.2; Tue, 16 Jan 2024 03:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705403245; x=1706008045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QVAGc4XL3xs1uMSry25G+l6Lbj7TMq/VrUzFoxhkoKU=; b=lzTL8GnAmiCDdrB9X8AY46y+KtpHjUe0jjlCof1XZ//53AcBhiZwsfOT1l7LFYR7AJ 4oiL3uLCrugQa4P5/gpHNYYbnA4v2pcDuFgbT3iGDmMEuhsU5YXlvilPhkUYR1DkP/DO 6c/0XR02UZ0XXJr4HYA3SR25cUrKHGlYyBIFi0Ht5Zdn8i7Vy0ytZYrfJY3zxpD2LLry 2HYjOpilk0PE6rakgdXJKnSjAMnpBtGqWDX3rtsiCx9KqVDuN4y0ottbKFLj3B90BAeu ALyg12sGYUP5q8NgQZfDaAk4bWwuCl3QxRaurYStHcbpMk4btO0mqC2P1TkbLH7p1Pmm 9Xsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705403245; x=1706008045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QVAGc4XL3xs1uMSry25G+l6Lbj7TMq/VrUzFoxhkoKU=; b=g/zmD6x/Bc7W6XxzDo5CEqaJSHWZaySjHZefqtxJ7/PD03Fmlzt8fwUcWBo0ldJeQQ 5RmpGti9UPch9sQJdP/ASkd/CuYhP3KD2LKEdTAs1PVAMyC4AAvwfJkXVy9qiOf8zUPo FLGG6eDKmnGRucm6D08eCHJmuUBYh2JaVpiGzEwETgftPeRM5BeZ2nbrzPbS0kXpS+JY T+dHxuAynoIMEClKiteka2tT9V/qLCQqyUkAy6za3KBZliZsHxnsaJ50HEVfe/hO9QpA a2KSytmNR/G0XRZ7C46aSYY0S2Tca3h5O+Lobrfx6lr3ZGsELbKKWeY75KhSn59YpKW0 5v4w== X-Gm-Message-State: AOJu0Yyg0NbSS7wIl1UKroVSNH3S/1OgrfCl0exs11nsvJYxvATTjLgk Dw17lFzEX4goXPmhc/x0G8M= X-Received: by 2002:a19:6549:0:b0:50e:abe1:1c63 with SMTP id c9-20020a196549000000b0050eabe11c63mr3434504lfj.32.1705403244776; Tue, 16 Jan 2024 03:07:24 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id a18-20020adffad2000000b003373ece28efsm14329359wrs.29.2024.01.16.03.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 03:07:24 -0800 (PST) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] bcachefs: remove redundant variable tmp Date: Tue, 16 Jan 2024 11:07:23 +0000 Message-Id: <20240116110723.2247265-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788244937151460482 X-GMAIL-MSGID: 1788244937151460482 The variable tmp is being assigned a value but it isn't being read afterwards. The assignment is redundant and so tmp can be removed. Cleans up clang scan build warning: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Brian Foster --- fs/bcachefs/rebalance.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/bcachefs/rebalance.c b/fs/bcachefs/rebalance.c index 95f46cb3b5bd..827316a27431 100644 --- a/fs/bcachefs/rebalance.c +++ b/fs/bcachefs/rebalance.c @@ -385,7 +385,6 @@ static int bch2_rebalance_thread(void *arg) struct bch_fs *c = arg; struct bch_fs_rebalance *r = &c->rebalance; struct moving_context ctxt; - int ret; set_freezable(); @@ -393,8 +392,7 @@ static int bch2_rebalance_thread(void *arg) writepoint_ptr(&c->rebalance_write_point), true); - while (!kthread_should_stop() && - !(ret = do_rebalance(&ctxt))) + while (!kthread_should_stop() && !do_rebalance(&ctxt)) ; bch2_moving_ctxt_exit(&ctxt);