From patchwork Tue Jan 16 04:10:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 188371 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp40057dye; Mon, 15 Jan 2024 20:12:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWT5Dxk0TS+R+O1Kp6wg50OtXZhT08UVa3w+w19CdXpB4qKy9l9/RmlxOAvg51YUKRL/cW X-Received: by 2002:a17:903:2808:b0:1d4:75c6:9560 with SMTP id kp8-20020a170903280800b001d475c69560mr2788423plb.59.1705378334945; Mon, 15 Jan 2024 20:12:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705378334; cv=none; d=google.com; s=arc-20160816; b=TDES0CvMIKOuoj3vkjjFZy9cK0NgaDSwgbs+v+oC1xNMi46QV1yGmQGZj1SHK3hWZP 3iVVL3fZTheUoltiezlcnblLwQkDtl302osniKHhUYtXb/GCe19SSnbJwnZ6cWB3UI50 LA5Uc0Kbi3z5kLYG1rilUbtmxv8fkL+2E2Z1UnGpTY/ga2AUWQC1RRBG4lLGY66ciuct w9gOD/CQpfV3L9csLv4pl69NehgO2Osz9puwKY5lsHcy7hIPScHiKgwLnSoHZM5p7ojZ uF5In6hBBHDaG+N6nS3dtk7RAq/xUX9iy8skE3XZ6vGeH6PSu+Jocc9/C/Q161tKBczs mVLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; fh=UkKqDtQf/nyeWncZ0OnJZ79jYcbt/5EXA6rFMCrt7Kg=; b=OXjFREsXdNMm8D05f5933tY/28+SWUrYG+xU4GlvEen9UNDur58skhlZr2j6ZHMsP/ XZNLLKzoMLgr7dmFsdrKyfPjEXIP/9OM2EIj+hCSbZgBEj/10U84InCGQzlgwho1l2vg Zlh5i6EUWN6gQAkW8XP5LLoRbCx1pcae5uLN85MQMbvX+yts1PM3hqIQKK4JLJIDxS9x cyCeeKibekMwrcGYn1oHrjZezBgDwIg1d992TpsFHF4UvnW8d7CNxYhBewfghod9rG5T VGOXEfjlRtMt3H2xS/v66SS/cw8bj1defz6QwUaUYrH0BXS0vaZ/fkwybCebpw5WsfQn iqJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=gS8mDw+N; spf=pass (google.com: domain of linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i18-20020a170902eb5200b001d496d21086si9912548pli.500.2024.01.15.20.12.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:12:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=gS8mDw+N; spf=pass (google.com: domain of linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9DDF2284A76 for ; Tue, 16 Jan 2024 04:12:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8301510A25; Tue, 16 Jan 2024 04:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="gS8mDw+N" Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDDE10A2A for ; Tue, 16 Jan 2024 04:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6dddba43d70so4657673a34.1 for ; Mon, 15 Jan 2024 20:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705378283; x=1705983083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=gS8mDw+N0vl5VxlTMOykZ6FXiQKiZHSNmUcHzeZnM3hFM5Iv0J9/gfdAg6g+Ltlk9n tuMFXI39vsauahLQDcmXYsnzUM0kPp3MoVGMyjO99Yru0eCjkV14Cn3qGWNkwwJVCBbf Vi0ZwU2iH8n1/IhTp/ugdF0WcyoVrWdTf1R3Vk3vvbr1pYVl7FJ7O8Q2KGldkcpOmH9t 6pptrDMM4Z6DUpRTwi9zqWcD3ob0IqktCwNfMSOex1Qwi2KuT9W9U7kIiGAJh9SL5hyG ejulNh3cNfm0qNNnCeyeRWhwL/iDMo5J+wtqicp0EfX3v0C+HTj5/TqjQORv1+8cOwGP 9LhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705378283; x=1705983083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=Poyi1nNzyZ92IQBVo8X5hmQhXzyMk9PXYijfe5gt9HpCv5jXzSA/2/7APTp8I5K4TP TaouCXO86ACxAndCJMOOFZ5E9kJq++oO6WdWG+ZYJMuzLIaQAxq8aNkcmLvk+FtGNdvC g0QqH5CemiGZOCIF+OAoMTgGFbm+Mxj/zE+cgbFDV4bsiwPM1eWDHKbRn334WEKar1HN 2XZf38O7KntoRCa/LzUGNVYK2GUcdrHZBgh7zUM3xfJM/jcCYfM1kC6/jY91Z8lrZ98J Ou1gumCAMoSbuKWqZCxEQITQx7qVx3qfOm4EiInIiS8YseYyKoznkADemedCNKXHr7j7 iiVg== X-Gm-Message-State: AOJu0YzmCzDcCArj9G+//MXVa8rXUzzbqdeIkxNU+vHwIDv/nIe81uCM eX+4l1eDnebiG/c3YtRGArT3KuPa5OHo+g== X-Received: by 2002:a05:6358:924:b0:175:d42f:6c63 with SMTP id r36-20020a056358092400b00175d42f6c63mr4731065rwi.36.1705378282820; Mon, 15 Jan 2024 20:11:22 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id e3-20020a056a0000c300b006da14f68ac1sm8348585pfj.198.2024.01.15.20.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:22 -0800 (PST) From: Nylon Chen To: paul.walmsley@sifive.com, palmer@dabbelt.com, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, aou@eecs.berkeley.edu Cc: zong.li@sifve.com, vincent.chen@sifive.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, nylon7717@gmail.com, Nylon Chen Subject: [v6 3/3] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Tue, 16 Jan 2024 12:10:54 +0800 Message-ID: <20240116041054.11641-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240116041054.11641-1-nylon.chen@sifive.com> References: <20240116041054.11641-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788218793103935695 X-GMAIL-MSGID: 1788218793103935695 Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=1 pol=0 1739692/4032985) -> (ena=1 pol=0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index b07c8598bb21..7cf7a76cdb44 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_ddata *ddata, /* As scale <= 15 the shift operation cannot overflow. */ num = (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period = div64_ul(num, rate); + ddata->real_period = DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->chip.dev, "New real_period = %u ns\n", ddata->real_period); }