[v6,1/3] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties
Message ID | 20240116041054.11641-2-nylon.chen@sifive.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp39893dye; Mon, 15 Jan 2024 20:11:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdE2F4H2hm+/c1JfX9TA2KrAdfTIQEi5KyMc76TlCNyH5/pAEIUey6NBgJp8BMVsvQvBaQ X-Received: by 2002:a81:dc06:0:b0:5d4:90a:c3bc with SMTP id h6-20020a81dc06000000b005d4090ac3bcmr4649459ywj.30.1705378300526; Mon, 15 Jan 2024 20:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705378300; cv=none; d=google.com; s=arc-20160816; b=YvmhX7v7+kpMOFwEvt7iin+ly8ZdUlhtQEstMWRpVivUV+MUiHWkau0Uo/pEZULK59 3t3AI8Xqed6BpjCn8bFH31K99WStcmD/DAXRL/Ynwb1jtJGoEuR1YmOEkJkX+nppkyjW GU5ZinjdFwSD0Ekm9gMq/Vq46BSb6W4ZzmL8o72g274vomUXn/wErBhjk/Go3UtybpPq fYjGlf9/K2R6IVJFIot6fP6yH37xKSllrglcKMvECULMBfb+rXMfxXIOZludEho6bO6U 1uEd1f+QPPRcOjjjqTTiHEpdvZrGV99An5D2kaIRrlN20zbkh9StggVve4tvg7Dqfdnu +u+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lNWOGH7VpQY6V8fQKtozhdwdDDbXnjZtAA+yG72Gg0I=; fh=HdLk8u0jhvs7C0KBcYg5FBqcF70cNpKlWL7kFME3264=; b=h+5axxTKc19kH+dyq/oBK8rNbMr/0Km+ZCKRtSbIFZRBvPMLuRfUnJ0ewhfWKlA0+y TS2nj0OPPq8dVdY20Uxvqy94IgBVYXnIL5k0x8UmSsv1xbTRtW3TKN6MKrcwjf4CnLF4 Qq6O9UlMaFqg/fFfBN/ZJXXjQFzjTvXhQQfJYI6STRaAujj7g40ALC9gpc1Qo1Aa+F54 PEzLUrwXKxftM6SwJPBQ1n2fZSeeOYwrDkUzlEZXT7WSS5Zmj3E+K+PS9okNkEzSfG5d gl9nEqqkiiQPAvD2m0Fot3yz3jrwt84Y+4L6+QUNRPcI9A9OF1UEc0r72aAD7M0yYk8Z EZXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=lzTimnaR; spf=pass (google.com: domain of linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z5-20020a170902834500b001d5dac194d0si1604470pln.303.2024.01.15.20.11.40 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=lzTimnaR; spf=pass (google.com: domain of linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44ECD2849CA for <ouuuleilei@gmail.com>; Tue, 16 Jan 2024 04:11:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4ED12101F7; Tue, 16 Jan 2024 04:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="lzTimnaR" Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34BF2882E for <linux-kernel@vger.kernel.org>; Tue, 16 Jan 2024 04:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-28cf491b197so4757107a91.1 for <linux-kernel@vger.kernel.org>; Mon, 15 Jan 2024 20:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705378270; x=1705983070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lNWOGH7VpQY6V8fQKtozhdwdDDbXnjZtAA+yG72Gg0I=; b=lzTimnaRDqVlnO5uGWtGw0kq3oftjo8S/OaySCU9PYzYg0Bt1DbIbGdcCmyAvaKjeO ggER/jZjF1dXwqkvZe6kK87izhKuYnHUz5Fh86jcJ1a3UCCHhL3BJOHcwbbQ9LDsxllM GuH+Ec2fKc+2uIAi3IPLXHFT1XLGFawqua+6mKBidmIyOpPQyJuCbQ32PPjRmtR+50dz TjtCln60cxCOcXDFs9Hk9O2HkGrg6OtaJXtBUns2IUWvNSwo8lQ9Jx0oVcSqyTsQGIxO gyO+eZRn3TM6V2JSK02GWLI2CBGckNLBiE2EdbamInXuabzCHp81N3owEB7zEu+qLDC3 f4zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705378270; x=1705983070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lNWOGH7VpQY6V8fQKtozhdwdDDbXnjZtAA+yG72Gg0I=; b=Mwcv356ay4jmCT+FkGKaNmeF5QM5sZ/aQ07mRZSuSv39/Pad5X+CDCASwoSGa7ucQH t1Iorx5H+rPO5cfOA3YhRD3YpphvAQi/LnSXpo0fTKN7HC6jlVrR1njl63baN5Vtea2G Tr9jH/KFNpymBfaU7Hz0voNKNt37kjRw1lqLj9PXSLeM+1ZbVYzsiftQdnUM58XzsWHD SaYLwjPT8jW6LkJVlGtCyC+0cLHQ77t/DX727xjX/wzlNkvrqBmpy3n+Or9E6Mc6/YJU Dq60eTps6ANJgeYFiEbFY2Kf/7pbW3MIqLULBrDdkKVsKlfE6aU+tZgCCj+XKnUIScxQ wCRA== X-Gm-Message-State: AOJu0YycbYzwF/PsjRsO65QtBez/SHpEtqkialFw+nsQIC5cwtdtrRQ7 FPI+qXKkPYLhIuSmKQSiOCaRBYCIfE5/SxiWHG6l06Q8TAiGtw== X-Received: by 2002:a05:6a00:4f8c:b0:6d9:aa4b:3800 with SMTP id ld12-20020a056a004f8c00b006d9aa4b3800mr3973757pfb.19.1705378270417; Mon, 15 Jan 2024 20:11:10 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id e3-20020a056a0000c300b006da14f68ac1sm8348585pfj.198.2024.01.15.20.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:10 -0800 (PST) From: Nylon Chen <nylon.chen@sifive.com> To: paul.walmsley@sifive.com, palmer@dabbelt.com, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, aou@eecs.berkeley.edu Cc: zong.li@sifve.com, vincent.chen@sifive.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, nylon7717@gmail.com, Nylon Chen <nylon.chen@sifive.com>, Conor Dooley <conor.dooley@microchip.com> Subject: [v6 1/3] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Date: Tue, 16 Jan 2024 12:10:52 +0800 Message-ID: <20240116041054.11641-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240116041054.11641-1-nylon.chen@sifive.com> References: <20240116041054.11641-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788218757009865527 X-GMAIL-MSGID: 1788218757009865527 |
Series |
Change PWM-controlled LED pin active mode and algorithm
|
|
Commit Message
Nylon Chen
Jan. 16, 2024, 4:10 a.m. UTC
This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Co-developed-by: Zong Li <zong.li@sifve.com> Signed-off-by: Zong Li <zong.li@sifve.com> Co-developed-by: Vincent Chen <vincent.chen@sifive.com> Signed-off-by: Vincent Chen <vincent.chen@sifive.com> Signed-off-by: Nylon Chen <nylon.chen@sifive.com> --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 8 ++++---- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- 2 files changed, 8 insertions(+), 12 deletions(-)
Comments
Nylon Chen wrote: > This removes the active-low properties of the PWM-controlled LEDs in > the HiFive Unmatched device tree. > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. > > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] > Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Co-developed-by: Zong Li <zong.li@sifve.com> > Signed-off-by: Zong Li <zong.li@sifve.com> > Co-developed-by: Vincent Chen <vincent.chen@sifive.com> > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > Signed-off-by: Nylon Chen <nylon.chen@sifive.com> > --- > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 8 ++++---- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- > 2 files changed, 8 insertions(+), 12 deletions(-) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > index 900a50526d77..11e7ac1c54bb 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > @@ -49,7 +49,7 @@ led-controller { > compatible = "pwm-leds"; > > led-d1 { > - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > + pwms = <&pwm0 0 7812500 0>; > active-low; > color = <LED_COLOR_ID_GREEN>; > max-brightness = <255>; > @@ -57,7 +57,7 @@ led-d1 { > }; > > led-d2 { > - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > + pwms = <&pwm0 1 7812500 0>; > active-low; > color = <LED_COLOR_ID_GREEN>; > max-brightness = <255>; > @@ -65,7 +65,7 @@ led-d2 { > }; > > led-d3 { > - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > + pwms = <&pwm0 2 7812500 0>; > active-low; > color = <LED_COLOR_ID_GREEN>; > max-brightness = <255>; > @@ -73,7 +73,7 @@ led-d3 { > }; > > led-d4 { > - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > + pwms = <&pwm0 3 7812500 0>; > active-low; > color = <LED_COLOR_ID_GREEN>; > max-brightness = <255>; > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index 07387f9c135c..b328ee80693f 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -51,8 +51,7 @@ led-controller-1 { > compatible = "pwm-leds"; > > led-d12 { > - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > - active-low; > + pwms = <&pwm0 0 7812500 0>; Here you remove the active-low property, but you don't above. I'm not sure what's the right thing to do, but I would have expected the same change in both places. /Emil > color = <LED_COLOR_ID_GREEN>; > max-brightness = <255>; > label = "d12"; > @@ -68,20 +67,17 @@ multi-led { > label = "d2"; > > led-red { > - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > - active-low; > + pwms = <&pwm0 2 7812500 0>; > color = <LED_COLOR_ID_RED>; > }; > > led-green { > - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > - active-low; > + pwms = <&pwm0 1 7812500 0>; > color = <LED_COLOR_ID_GREEN>; > }; > > led-blue { > - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > - active-low; > + pwms = <&pwm0 3 7812500 0>; > color = <LED_COLOR_ID_BLUE>; > }; > }; > -- > 2.42.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Tue, Jan 16, 2024 at 02:20:57AM -0800, Emil Renner Berthing wrote: > Nylon Chen wrote: > > This removes the active-low properties of the PWM-controlled LEDs in > > the HiFive Unmatched device tree. > > > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. > > > > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] > > Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Co-developed-by: Zong Li <zong.li@sifve.com> > > Signed-off-by: Zong Li <zong.li@sifve.com> > > Co-developed-by: Vincent Chen <vincent.chen@sifive.com> > > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > > Signed-off-by: Nylon Chen <nylon.chen@sifive.com> > > --- > > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 8 ++++---- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- > > 2 files changed, 8 insertions(+), 12 deletions(-) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > index 900a50526d77..11e7ac1c54bb 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > @@ -49,7 +49,7 @@ led-controller { > > compatible = "pwm-leds"; > > > > led-d1 { > > - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > + pwms = <&pwm0 0 7812500 0>; > > active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > @@ -57,7 +57,7 @@ led-d1 { > > }; > > > > led-d2 { > > - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > + pwms = <&pwm0 1 7812500 0>; > > active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > @@ -65,7 +65,7 @@ led-d2 { > > }; > > > > led-d3 { > > - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > + pwms = <&pwm0 2 7812500 0>; > > active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > @@ -73,7 +73,7 @@ led-d3 { > > }; > > > > led-d4 { > > - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > + pwms = <&pwm0 3 7812500 0>; > > active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index 07387f9c135c..b328ee80693f 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -51,8 +51,7 @@ led-controller-1 { > > compatible = "pwm-leds"; > > > > led-d12 { > > - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > + pwms = <&pwm0 0 7812500 0>; > > Here you remove the active-low property, but you don't above. I'm not sure > what's the right thing to do, but I would have expected the same change in both > places. Just to note, the original version of this that I acked/reviewed removed the property from all led nodes. I then apparently didn't look closely enough at v5 and left acked/reviewed tags on it too. It did not remove the active-low properties but this change was not mentioned in the changelog for the series. D4 on the unleashed and D12 on the unmatched have the same circuitry (modulo the placement of the series resistor) so I don't get why the property is being removed from only D12. I rescind my ack/review until that is clarified and/or fixed. Thanks, Conor. > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > label = "d12"; > > @@ -68,20 +67,17 @@ multi-led { > > label = "d2"; > > > > led-red { > > - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > + pwms = <&pwm0 2 7812500 0>; > > color = <LED_COLOR_ID_RED>; > > }; > > > > led-green { > > - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > + pwms = <&pwm0 1 7812500 0>; > > color = <LED_COLOR_ID_GREEN>; > > }; > > > > led-blue { > > - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > + pwms = <&pwm0 3 7812500 0>; > > color = <LED_COLOR_ID_BLUE>; > > }; > > }; > > -- > > 2.42.0 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv
Conor Dooley <conor.dooley@microchip.com> 於 2024年1月16日 週二 下午6:45寫道: > > On Tue, Jan 16, 2024 at 02:20:57AM -0800, Emil Renner Berthing wrote: > > Nylon Chen wrote: > > > This removes the active-low properties of the PWM-controlled LEDs in > > > the HiFive Unmatched device tree. > > > > > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. > > > > > > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] > > > Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] > > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > Co-developed-by: Zong Li <zong.li@sifve.com> > > > Signed-off-by: Zong Li <zong.li@sifve.com> > > > Co-developed-by: Vincent Chen <vincent.chen@sifive.com> > > > Signed-off-by: Vincent Chen <vincent.chen@sifive.com> > > > Signed-off-by: Nylon Chen <nylon.chen@sifive.com> > > > --- > > > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 8 ++++---- > > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- > > > 2 files changed, 8 insertions(+), 12 deletions(-) > > > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > > index 900a50526d77..11e7ac1c54bb 100644 > > > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > > @@ -49,7 +49,7 @@ led-controller { > > > compatible = "pwm-leds"; > > > > > > led-d1 { > > > - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > > + pwms = <&pwm0 0 7812500 0>; > > > active-low; > > > color = <LED_COLOR_ID_GREEN>; > > > max-brightness = <255>; > > > @@ -57,7 +57,7 @@ led-d1 { > > > }; > > > > > > led-d2 { > > > - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > > + pwms = <&pwm0 1 7812500 0>; > > > active-low; > > > color = <LED_COLOR_ID_GREEN>; > > > max-brightness = <255>; > > > @@ -65,7 +65,7 @@ led-d2 { > > > }; > > > > > > led-d3 { > > > - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > > + pwms = <&pwm0 2 7812500 0>; > > > active-low; > > > color = <LED_COLOR_ID_GREEN>; > > > max-brightness = <255>; > > > @@ -73,7 +73,7 @@ led-d3 { > > > }; > > > > > > led-d4 { > > > - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > > + pwms = <&pwm0 3 7812500 0>; > > > active-low; > > > color = <LED_COLOR_ID_GREEN>; > > > max-brightness = <255>; > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > > index 07387f9c135c..b328ee80693f 100644 > > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > > @@ -51,8 +51,7 @@ led-controller-1 { > > > compatible = "pwm-leds"; > > > > > > led-d12 { > > > - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > > - active-low; > > > + pwms = <&pwm0 0 7812500 0>; > > Hi Emil and Conor, thanks for your feedback. > > > > Here you remove the active-low property, but you don't above. I'm not sure > > what's the right thing to do, but I would have expected the same change in both > > places. > For this patch, all "active-low" should be deleted. This is my mistake. I will fix it in the next version. > > > Just to note, the original version of this that I acked/reviewed removed > the property from all led nodes. I then apparently didn't look closely > enough at v5 and left acked/reviewed tags on it too. It did not remove > the active-low properties but this change was not mentioned in the > changelog for the series. Sorry Conor, I apologize for any confusion I may have caused. > > D4 on the unleashed and D12 on the unmatched have the same circuitry > (modulo the placement of the series resistor) so I don't get why the > property is being removed from only D12. > > I rescind my ack/review until that is clarified and/or fixed. > > Thanks, > Conor. > > > > > color = <LED_COLOR_ID_GREEN>; > > > max-brightness = <255>; > > > label = "d12"; > > > @@ -68,20 +67,17 @@ multi-led { > > > label = "d2"; > > > > > > led-red { > > > - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > > - active-low; > > > + pwms = <&pwm0 2 7812500 0>; > > > color = <LED_COLOR_ID_RED>; > > > }; > > > > > > led-green { > > > - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > > - active-low; > > > + pwms = <&pwm0 1 7812500 0>; > > > color = <LED_COLOR_ID_GREEN>; > > > }; > > > > > > led-blue { > > > - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > > - active-low; > > > + pwms = <&pwm0 3 7812500 0>; > > > color = <LED_COLOR_ID_BLUE>; > > > }; > > > }; > > > -- > > > 2.42.0 > > > > > > > > > _______________________________________________ > > > linux-riscv mailing list > > > linux-riscv@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-riscv
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..11e7ac1c54bb 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -49,7 +49,7 @@ led-controller { compatible = "pwm-leds"; led-d1 { - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 0 7812500 0>; active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; @@ -57,7 +57,7 @@ led-d1 { }; led-d2 { - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 1 7812500 0>; active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; @@ -65,7 +65,7 @@ led-d2 { }; led-d3 { - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 2 7812500 0>; active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; @@ -73,7 +73,7 @@ led-d3 { }; led-d4 { - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 3 7812500 0>; active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..b328ee80693f 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -51,8 +51,7 @@ led-controller-1 { compatible = "pwm-leds"; led-d12 { - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 0 7812500 0>; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d12"; @@ -68,20 +67,17 @@ multi-led { label = "d2"; led-red { - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 2 7812500 0>; color = <LED_COLOR_ID_RED>; }; led-green { - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 1 7812500 0>; color = <LED_COLOR_ID_GREEN>; }; led-blue { - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 3 7812500 0>; color = <LED_COLOR_ID_BLUE>; }; };