[v2,2/2] dt-bindings: arm: Add device-name in the coresight components
Commit Message
device-name is used to provide a better description of the coresight
device. It can provide the info like the system or HW it belongs to.
Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
.../devicetree/bindings/arm/arm,coresight-catu.yaml | 5 +++++
.../devicetree/bindings/arm/arm,coresight-cpu-debug.yaml | 5 +++++
Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 5 +++++
.../devicetree/bindings/arm/arm,coresight-dummy-sink.yaml | 5 +++++
.../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 5 +++++
.../bindings/arm/arm,coresight-dynamic-funnel.yaml | 5 +++++
.../bindings/arm/arm,coresight-dynamic-replicator.yaml | 5 +++++
.../devicetree/bindings/arm/arm,coresight-etb10.yaml | 5 +++++
Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml | 5 +++++
.../devicetree/bindings/arm/arm,coresight-static-funnel.yaml | 5 +++++
.../bindings/arm/arm,coresight-static-replicator.yaml | 5 +++++
Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml | 5 +++++
Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml | 5 +++++
.../devicetree/bindings/arm/arm,coresight-tpiu.yaml | 5 +++++
.../devicetree/bindings/arm/qcom,coresight-tpda.yaml | 5 +++++
.../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 5 +++++
16 files changed, 80 insertions(+)
Comments
On Mon, 15 Jan 2024 08:42:48 -0800, Mao Jinlong wrote:
> device-name is used to provide a better description of the coresight
> device. It can provide the info like the system or HW it belongs to.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
> .../devicetree/bindings/arm/arm,coresight-catu.yaml | 5 +++++
> .../devicetree/bindings/arm/arm,coresight-cpu-debug.yaml | 5 +++++
> Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 5 +++++
> .../devicetree/bindings/arm/arm,coresight-dummy-sink.yaml | 5 +++++
> .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 5 +++++
> .../bindings/arm/arm,coresight-dynamic-funnel.yaml | 5 +++++
> .../bindings/arm/arm,coresight-dynamic-replicator.yaml | 5 +++++
> .../devicetree/bindings/arm/arm,coresight-etb10.yaml | 5 +++++
> Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml | 5 +++++
> .../devicetree/bindings/arm/arm,coresight-static-funnel.yaml | 5 +++++
> .../bindings/arm/arm,coresight-static-replicator.yaml | 5 +++++
> Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml | 5 +++++
> Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml | 5 +++++
> .../devicetree/bindings/arm/arm,coresight-tpiu.yaml | 5 +++++
> .../devicetree/bindings/arm/qcom,coresight-tpda.yaml | 5 +++++
> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 5 +++++
> 16 files changed, 80 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml: device-name: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240115164252.26510-3-quic_jinlmao@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
On 15/01/2024 17:42, Mao Jinlong wrote:
> device-name is used to provide a better description of the coresight
> device. It can provide the info like the system or HW it belongs to.
>
system or HW are defined by top level model, so probably you meant here
something else. Anyway you need to provide better rationale, because
above argument can be applied to any device and we do not have generic
device-name property. Once you have good explanation, then probably you
want "label" not some new property.
Best regards,
Krzysztof
Hi Mao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.7 next-20240112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mao-Jinlong/coresight-core-Add-device-name-support/20240116-004557
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240115164252.26510-3-quic_jinlmao%40quicinc.com
patch subject: [PATCH v2 2/2] dt-bindings: arm: Add device-name in the coresight components
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240117/202401170445.7STzlFcl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401170445.7STzlFcl-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml: device-name: missing type definition
@@ -44,6 +44,11 @@ properties:
- const: arm,coresight-catu
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -39,6 +39,11 @@ properties:
- const: arm,coresight-cpu-debug
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -88,6 +88,11 @@ properties:
- const: arm,coresight-cti
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -39,6 +39,11 @@ properties:
enum:
- arm,coresight-dummy-sink
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
in-ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -38,6 +38,11 @@ properties:
enum:
- arm,coresight-dummy-source
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
out-ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -41,6 +41,11 @@ properties:
- const: arm,coresight-dynamic-funnel
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -41,6 +41,11 @@ properties:
- const: arm,coresight-dynamic-replicator
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -41,6 +41,11 @@ properties:
- const: arm,coresight-etb10
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -60,6 +60,11 @@ properties:
Embedded Trace Macrocell (version 4.x), with system register access only
const: arm,coresight-etm4x-sysreg
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -27,6 +27,11 @@ properties:
compatible:
const: arm,coresight-static-funnel
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
power-domains:
maxItems: 1
@@ -27,6 +27,11 @@ properties:
compatible:
const: arm,coresight-static-replicator
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
power-domains:
maxItems: 1
@@ -43,6 +43,11 @@ properties:
- const: arm,coresight-stm
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 2
@@ -42,6 +42,11 @@ properties:
- const: arm,coresight-tmc
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -41,6 +41,11 @@ properties:
- const: arm,coresight-tpiu
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
maxItems: 1
@@ -54,6 +54,11 @@ properties:
- const: qcom,coresight-tpda
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
minItems: 1
maxItems: 2
@@ -40,6 +40,11 @@ properties:
- const: qcom,coresight-tpdm
- const: arm,primecell
+ device-name:
+ description:
+ Define the name which can describe what kind of HW or system the
+ device is for.
+
reg:
minItems: 1
maxItems: 2