From patchwork Mon Jan 15 14:56:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alexis_Lothor=C3=A9?= X-Patchwork-Id: 188221 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2614:b0:101:6a76:bbe3 with SMTP id mm20csp1760265dyc; Mon, 15 Jan 2024 07:07:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IH2ZKJgU9Za+QAIOPTeJAPTJg9Dfw0QEeTaSJuuuNUBG82bNJisSWKl/WHY7gA/TPmMlP5K X-Received: by 2002:a05:6402:5242:b0:558:9db4:30b3 with SMTP id t2-20020a056402524200b005589db430b3mr7861812edd.15.1705331251936; Mon, 15 Jan 2024 07:07:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705331251; cv=none; d=google.com; s=arc-20160816; b=wpMOdweBU62C47qv75xJSonz1xTpGm07QQECChZvY654F++5Txy/KPc0cUzAG4BZjp D6aJMOWGUtRhWnSjnGLrWvEOP3XzxXxahOd4YnSedIlCuAB9vhrDl29iEJV1ezcSgd2Z U1ZFrzLNi8sfXneEbgcj8mxL88c97FVmyKYlQqdS3knjIHveAhu+/UABIHjkfQmDd0mu /TxEdFDA4acVNFOdU8//S9J/A6mUTiI8peZaG69fTKqIDTk0BJj4zJYaJBkY2wit2NqN qqbDKUxYxl/+t3IsP9ZAA6+OkeSVdGYp/8F0O92b35+HgfKn7MmJobPb8SOpRbKUC3TS wwSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=qUQFLny0OJogecoJQ6XqtWgWxGYqMWpFkFbyJn8U9iw=; fh=fVWNSIr8Vd5WRJo6LslfqG3nFGLhcHDnKbQ0ZKCs5kk=; b=ZGhp3tf1Qoz+RWQYQD2P6FH2HjLZ/FG2iMEFBLHfW2pnRbny9rvxxId+oMfh2RCMpd uv7znEpp5LZYh5sHnFV9aHKwGNEvXxGqNlY/W2PKzl8Ndhuimje0QaL9tuco5WitG2+H 5wW2iseHseVzy38ziLr0MHhvy0dafCYE2nncp9ySFR1R2R/ASKCnydsVnWK1f9n48XFH 2J8dWLciYuBmtDoSDCgUP0tolBkTaI2La6HnotZ0ilF7P2Y02wqSfyKLRy56KEGa7JxR sHSop4zxX1CV+IoR4aKx0riaSW3LmFDL3j0ynUwtlxypEatVfWZvQkVa6X9Y+6im11Tj 2H+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=DUVyiaxL; spf=pass (google.com: domain of linux-kernel+bounces-26156-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26156-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n23-20020a5099d7000000b0055390d3c062si3954502edb.529.2024.01.15.07.07.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 07:07:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26156-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=DUVyiaxL; spf=pass (google.com: domain of linux-kernel+bounces-26156-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26156-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 889551F22B14 for ; Mon, 15 Jan 2024 15:07:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A92661802A; Mon, 15 Jan 2024 15:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DUVyiaxL" Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FDC179B7; Mon, 15 Jan 2024 15:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: from relay9-d.mail.gandi.net (unknown [217.70.183.199]) by mslow1.mail.gandi.net (Postfix) with ESMTP id CD0D8C646A; Mon, 15 Jan 2024 14:59:20 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1D897FF805; Mon, 15 Jan 2024 14:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1705330753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qUQFLny0OJogecoJQ6XqtWgWxGYqMWpFkFbyJn8U9iw=; b=DUVyiaxLVcCQGvgki9t3xNTv8GyWblnTcZhvz4bwUksdLH++0leG6dGavwjxpuGjuXmFQo AtpUp3KdZ5ca5Q5GBW/O5IdK5X+Ji5HN9f9Hd1FZmMqycOtJFi00CfxpxqVEogkGynnEYc gYVu5cF29DpkofadmoGsTjxKllPp2aMsKbxA5EN45TFimjykjtuqydiJUMbse7nH6b+J6k 1cwwXy7sFTN78n84yRwUF+GZfILWRWpyRj4ivqIW6IrLMgk/kWq2xhCdMtgIdWsUzR268u EUAT96Afx6Roxd2AWcce9OVrmRouRfODQarR7qs347kTnnbd6oCfbarp00bcPw== From: =?utf-8?q?Alexis_Lothor=C3=A9?= Date: Mon, 15 Jan 2024 15:56:31 +0100 Subject: [PATCH 2/5] wifi: wilc1000: fix driver_handler when committing initial configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240115-wilc_1000_fixes-v1-2-54d29463a738@bootlin.com> References: <20240115-wilc_1000_fixes-v1-0-54d29463a738@bootlin.com> In-Reply-To: <20240115-wilc_1000_fixes-v1-0-54d29463a738@bootlin.com> To: linux-wireless@vger.kernel.org Cc: Ajay Singh , Claudiu Beznea , Kalle Valo , David Mosberger-Tang , Thomas Petazzoni , linux-kernel@vger.kernel.org, =?utf-8?q?Alexis_Lothor=C3=A9?= X-Mailer: b4 0.12.4 X-GND-Sasl: alexis.lothore@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788169422964497420 X-GMAIL-MSGID: 1788169422964497420 From: Ajay Singh During firmware initial configuration in wilc_init_fw_config, the special driver_handler 0 should be used instead of targeting a specific virtual interface (either 1 or 2) The issue does not seem to have real consequence (both virtual interfaces seems to answer correctly to a Add Block Ack request with the Immediate policy), but lets make everything homogeneous Signed-off-by: Ajay Singh Signed-off-by: Alexis Lothoré --- drivers/net/wireless/microchip/wilc1000/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c index 8923eb64c964..f3b9709f8730 100644 --- a/drivers/net/wireless/microchip/wilc1000/netdev.c +++ b/drivers/net/wireless/microchip/wilc1000/netdev.c @@ -416,7 +416,7 @@ static int wilc_init_fw_config(struct net_device *dev, struct wilc_vif *vif) b = 1; if (!wilc_wlan_cfg_set(vif, 0, WID_11N_IMMEDIATE_BA_ENABLED, &b, 1, - 1, 1)) + 1, 0)) goto fail; return 0;