From patchwork Fri Jan 12 15:46:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 187775 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2614:b0:101:6a76:bbe3 with SMTP id mm20csp261211dyc; Fri, 12 Jan 2024 07:47:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZuzWgXRvmm80KnlDMLHDAMLDwqdz9NCm4+cOGAdupD0f1G19rz0b05cq4ru7M+90AplQA X-Received: by 2002:a05:6402:30a6:b0:558:b6d6:4c6f with SMTP id df6-20020a05640230a600b00558b6d64c6fmr1716477edb.8.1705074422445; Fri, 12 Jan 2024 07:47:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705074422; cv=none; d=google.com; s=arc-20160816; b=WE2d+P2JMHPho35wCU/U/0C+7V1yaLldPKbOVItfOwMtE8ApJP3idnQ6vtcAi0tiDZ XnmL0RP4GHaqb5xvqgA7YW7gkKMCf1/XV3w92oDts1/2dbVhzmo3sVo6dSBiz21iOtJG Jkyb/wmJqwNes10p22XSEw2oG8MFQZZ84u6DzWfp+59OOuzUot4cAEE3dSIEn1zwzNxV GRaq3+5TjN1XeYAht8LMrJnomJ4sWsYJE7iUC4O/azKcbacfcSPnEv7ygX2ikqve6lkT DsAxaoyvkgha66llrNqYfQHJ6iGzFz6dJTjJPLUL86wNv6G9Yapg94R1o8e1oK/FhGzU GJaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=G1dUWDjk0pMP0PZi+Ldg4wEj7SvSc/wPa3tYQwhA0Lw=; fh=Vt4MF2mkEob8wHsiIEVO0FMp/tQ5kOJKjfDhEdncdXc=; b=HbDtRElgTDqyBb/MGq0o/W2a+G6vP4PsIS4oGfx4Lsitlx1OIiFqDmVVp9+J7hNR4l owOfiQ7/tM7o+H5flrQAa19gFSxNsC3w3+kq7y4GsZxtuZvtcQcOw3lMldvYw86tdKqe vO4EGHCqf3cR/28qNZG0catILSEqX0KI0dHCzo63kwYG8LBOCJqdJMifGYxHXRV6zrRM WnQvVm3EBHErtw4WJXIugwx4rtM1k1bEhAV+3sjbzTw2ymVHywpv6YklzmFr3qb5oatU Ui+ehdWDQQtcDkTXnqgiFmCxMnUGCHTWTKQGQW9mohPrsycq0tGBszutxK0yV9lBy4Nn wMcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hqvOXEaD; spf=pass (google.com: domain of linux-kernel+bounces-24819-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24819-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g7-20020a056402320700b00558cb8f8395si641440eda.16.2024.01.12.07.47.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 07:47:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24819-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hqvOXEaD; spf=pass (google.com: domain of linux-kernel+bounces-24819-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24819-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1503E1F25025 for ; Fri, 12 Jan 2024 15:47:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D38D973183; Fri, 12 Jan 2024 15:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hqvOXEaD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D1366EB7D; Fri, 12 Jan 2024 15:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2E52C43399; Fri, 12 Jan 2024 15:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705074393; bh=5LTULEAdFpJcQBG6D6ceSXiQtGzk7tED42bNjO0Rk+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hqvOXEaDSm1CyW5xE6ar9yif2JT/BSSeb2hAxaUYvxBC6RV1EP+KCjwxqnM4uTE5d ROXKPFvKXMRZAaQSuZlw9GGniXf904gAus9MjM1pD+J8eNFhVBCnk0jzebVLg92FUl cF3wK2nh3V0kXZI6b3Umu13fTPJTisxf4RZIHX7Yus7DyXamvjfI41l4vVq20EakH2 bddQVhGqId+9VUGOA3l5xGOFZHX6altm21y38nHW/TdVLH8m1QwYnexISLbIIF1jiK blXNHTKWz7zh31Y66VGCeg14Iimr3ahuwaE3N0rhD9BPwEUx5sVUc3OJ1hpNCo4e6y ekPoSnbYMIVWw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Boqun Feng , Joel Fernandes , Neeraj Upadhyay , "Paul E . McKenney" , Uladzislau Rezki , rcu , Kalesh Singh Subject: [PATCH 1/7] rcu/exp: Fix RCU expedited parallel grace period kworker allocation failure recovery Date: Fri, 12 Jan 2024 16:46:15 +0100 Message-Id: <20240112154621.261852-2-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240112154621.261852-1-frederic@kernel.org> References: <20240112154621.261852-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787900117505009983 X-GMAIL-MSGID: 1787900117505009983 Under CONFIG_RCU_EXP_KTHREAD=y, the nodes initialization for expedited grace periods is queued to a kworker. However if the allocation of that kworker failed, the nodes initialization is performed synchronously by the caller instead. Now the check for kworker initialization failure relies on the kworker pointer to be NULL while its value might actually encapsulate an allocation failure error. Make sure to handle this case. Reviewed-by: Kalesh Singh Fixes: 9621fbee44df ("rcu: Move expedited grace period (GP) work to RT kthread_worker") Signed-off-by: Frederic Weisbecker --- kernel/rcu/tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 499803234176..b000c1a83fc2 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -4760,6 +4760,7 @@ static void __init rcu_start_exp_gp_kworkers(void) rcu_exp_par_gp_kworker = kthread_create_worker(0, par_gp_kworker_name); if (IS_ERR_OR_NULL(rcu_exp_par_gp_kworker)) { pr_err("Failed to create %s!\n", par_gp_kworker_name); + rcu_exp_par_gp_kworker = NULL; kthread_destroy_worker(rcu_exp_gp_kworker); return; }