Message ID | 20240112041926.3924315-1-suhui@nfschina.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-24283-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1897515dyi; Thu, 11 Jan 2024 20:20:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGE4pVo/Qdzyx8z/hma5Daox6kgarN1hiOz01I/lmlRMydLCAs7B+3JW5s0oXd7IEjiUR8 X-Received: by 2002:a05:6a21:3282:b0:19a:7899:8238 with SMTP id yt2-20020a056a21328200b0019a78998238mr527622pzb.7.1705033241771; Thu, 11 Jan 2024 20:20:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705033241; cv=none; d=google.com; s=arc-20160816; b=EbMjkW3mOzB9Rv61CNvImlsUs/Cpa6hjcJ3evU8PTndYdsAWX9T+2gGevqZgoHsvyh dP4hVR2meIHu9Dl70Yz2bKNrwdNXRS/0rjyUBwPo1mSAcb3IFqlzOSihTab3T2dDAiLl Lp4A9V0mTiCMI/gULoJ52le2EDygUR0jW7zj12ZKgVi81zcU0zAGaD3dtJSPEiSC+xeq W+6waPbgH78YS8YjCgEwEWE5P48UZoVooLKf7wh6O+ZkHsl86aWO4Mh/jaXP8uehoWmn WRtJk1KejmvITn4Vh6ByZ7M1ouNcnSnKUjWtdAxG9xbcE4M25dYEI6Z7XcaJcHUWBZ5h PkYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=6shhXKa2yJEiAQsJ0Jt4iLIOaW0xqaLrYRMG5mL4PAU=; fh=m2TwruvFnFCoSQ2DwkJsz2pEyboh9gElC3EoOF3vPzY=; b=wfoPqbbSvh5r/hjLbu0dCsNQrD5AMysQGekTtz4kALYlIeTYq9xgyFrD0dsUxhMlYL JsOiPZsTXdWPlcglkE+PaqcK2umh0jWFMgk5OVV25WvDDB58vjr8P8QdPjqRzhss0Gwb 1yY+HKCwI6sps4+rN7HrYKsqT0Zxp1YBBlO0RWGrM1jwaxUnDrQ6UiM1vHT9F4HMw/lG 6h2x6BsjI185wRZR1RyxLer9j5qVOYFPPXUeq8fLTLBlSdnb77CqbT6PZyTKCcXOTMQ/ 9JJ5i09Zf0fqx/ePqN01uWLaWEjaZaimGikwrf6UQ4D+uT6vgk7nAbkYx2VnSNo2wz4h pIvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-24283-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24283-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t25-20020aa79399000000b006d9bd2c09dasi2337904pfe.336.2024.01.11.20.20.41 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 20:20:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24283-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-24283-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24283-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4A8AF28A675 for <ouuuleilei@gmail.com>; Fri, 12 Jan 2024 04:20:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DF69D2574F; Fri, 12 Jan 2024 04:20:01 +0000 (UTC) Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id 8FBAA1A73F; Fri, 12 Jan 2024 04:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 93801604F046F; Fri, 12 Jan 2024 12:19:37 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui <suhui@nfschina.com> To: artur.paszkiewicz@intel.com, jejb@linux.ibm.com, martin.petersen@oracle.com, nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com Cc: Su Hui <suhui@nfschina.com>, dan.j.williams@intel.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build Date: Fri, 12 Jan 2024 12:19:27 +0800 Message-Id: <20240112041926.3924315-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787856936426622700 X-GMAIL-MSGID: 1787856936426622700 |
Series |
scsi: isci: request: Fix an error code problem in isci_io_request_build
|
|
Commit Message
Su Hui
Jan. 12, 2024, 4:19 a.m. UTC
Clang static complains that Value stored to 'status' is never read.
Return 'status' rather than 'SCI_SUCCESS'.
Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/scsi/isci/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 1/12/24 05:19, Su Hui wrote: > Clang static complains that Value stored to 'status' is never read. > Return 'status' rather than 'SCI_SUCCESS'. > > Fixes: f1f52e75939b ("isci: uplevel request infrastructure") > Signed-off-by: Su Hui <suhui@nfschina.com> Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> Clang static complains that Value stored to 'status' is never read. > Return 'status' rather than 'SCI_SUCCESS'. Applied to 6.8/scsi-staging, thanks!
diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c index 71f711cb0628..355a0bc0828e 100644 --- a/drivers/scsi/isci/request.c +++ b/drivers/scsi/isci/request.c @@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost, return SCI_FAILURE; } - return SCI_SUCCESS; + return status; } static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)