From patchwork Thu Jan 11 11:48:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 187324 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1388991dyi; Thu, 11 Jan 2024 03:51:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEK4MjzXy/TsJb8xRx3dCXwW78Y8rNv5k8TjNOlBlmpISOkLAtm33HwUE4ASFshaMLs4qHh X-Received: by 2002:a17:902:c10c:b0:1d4:cf2b:2bf with SMTP id 12-20020a170902c10c00b001d4cf2b02bfmr762633pli.4.1704973891709; Thu, 11 Jan 2024 03:51:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704973891; cv=none; d=google.com; s=arc-20160816; b=sroD9PPBmDs8xDKNfmqPgfDjQNfy/AtKpZ62aVlE9UxtHSLJAreMEJzTRJTsD8DKl2 EYr6+JxF17I0FYq4obdYtSZ2UcM+7e4fZeH7gDRqn284+T7/NkKjhM78chsiEJUQ0zEa rdhyXgme5LRUTlAJ1EFqwy0y7xMsMSexOpIu/UymLB4oGlXtqZwpz0KfBYxkMOwqAm43 yqxIzF8xigDZxGtPkVza/f3J0m3rnn4mFrHXKnu+ZbjOVXeHCtRaSKJ2sf4IQ6vaHjh2 Lc1tMjyHzW84A0xLfSSNPekCZvBa45bOUdz5qHT2xETIsaSNYC0xYowSTpjJZNNGoWTJ c2iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/252E7E9rHvdE4Vh1Ct14md+rj0q8EJ6U+aeAJaeD2w=; fh=wMnX2JVBtS2NrVgo2CnGDWraHKef72/T+fbwIIcSOXY=; b=cWMIRsQH+S2PbEqjQFI39ISVDgqKI4Il/CTJZjzmC+DLC+5MDDgPO2YgCqms/8Uh0T j3Uc8m0TWFyvqg6LnQv16cnEFRpr9UTSxOaxT5CiONTPU6RBI3BNM+LlV2l2ILUbPEnM DlVrsgopJGsGUiMV1/3okGAJJWsYWazvaeNDoM7apBVGaR/Veuqxpxe9+Km+UCLtnfKz zpOy0Ye9xefZklbmjiMqFgzhflPzxUrfOvoSeyZwU+rM4XOxzbn+9QqkRgyF6clewYWJ e3ZjH6GgB5FZBTn/a9bNvefF+Vj7E8PllJFkvSSmCDcFH9Qj9WhOBy7djin1+yeEvsXA WEXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=DV6UL8G0; spf=pass (google.com: domain of linux-kernel+bounces-23514-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23514-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id kj6-20020a17090306c600b001d3554bb52bsi900671plb.519.2024.01.11.03.51.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 03:51:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23514-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=DV6UL8G0; spf=pass (google.com: domain of linux-kernel+bounces-23514-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23514-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 921D02889A9 for ; Thu, 11 Jan 2024 11:50:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D807015EA1; Thu, 11 Jan 2024 11:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DV6UL8G0" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7AC715AC6; Thu, 11 Jan 2024 11:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BB9115B5; Thu, 11 Jan 2024 12:48:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1704973692; bh=+W3iDB8WTozj1nqYH1DK/H9GSSjDUiV71a1AKS5P110=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DV6UL8G0pZNLD0JQ4J60eNXyk4ghOtA/+S8g9sfEOZYHMAd5Lq6NWGx89K1EKdz2c tXffXlm7JNPtBvFTPJeME8UnTvICr+0JUwT+Y9+qZOEIF/H5C8pLT7yqb+56lxtIyC UrG0aH4EWgpaoIKQwnNYOqevK3kpwIejixX6OP6c= From: Paul Elder To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, aford173@gmail.com, Paul Elder , Laurent Pinchart , Rob Herring , Alexander Stein , Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Helen Koike , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 05/11] dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible Date: Thu, 11 Jan 2024 20:48:25 +0900 Message-Id: <20240111114831.656736-6-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240111114831.656736-1-paul.elder@ideasonboard.com> References: <20240111114831.656736-1-paul.elder@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787794703570299964 X-GMAIL-MSGID: 1787794703570299964 The i.MX8MP ISP is compatbile with the rkisp1 driver. Add it to the list of compatible strings. While at it, expand on the description of the clocks to make it clear which clock in the i.MX8MP ISP they map to, based on the names from the datasheet. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Tested-by: Alexander Stein Tested-by: Adam Ford --- Changes since v1: - Add fsl,blk-ctrl property - Make iommus, phys and phy-names conditional on compatible --- .../bindings/media/rockchip-isp1.yaml | 37 ++++++++++++++++--- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml index afcaa427d48b..6be00aca4181 100644 --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml @@ -16,6 +16,7 @@ description: | properties: compatible: enum: + - fsl,imx8mp-isp - rockchip,px30-cif-isp - rockchip,rk3399-cif-isp @@ -36,9 +37,9 @@ properties: minItems: 3 items: # isp0 and isp1 - - description: ISP clock - - description: ISP AXI clock - - description: ISP AHB clock + - description: ISP clock (for imx8mp, clk) + - description: ISP AXI clock (for imx8mp, m_hclk) + - description: ISP AHB clock (for imx8mp, hclk) # only for isp1 - description: ISP Pixel clock @@ -52,6 +53,13 @@ properties: # only for isp1 - const: pclk + fsl,blk-ctrl: + $ref: /schemas/types.yaml#/definitions/phandle-array + maxItems: 1 + description: + A phandle to the media block control for the ISP, followed by a cell + containing the index of the gasket. + iommus: maxItems: 1 @@ -113,9 +121,6 @@ required: - interrupts - clocks - clock-names - - iommus - - phys - - phy-names - power-domains - ports @@ -143,6 +148,26 @@ allOf: required: - interrupt-names + - if: + properties: + compatible: + contains: + const: fsl,imx8mp-isp + then: + properties: + iommus: false + phys: false + phy-names: false + required: + - fsl,blk-ctrl + else: + properties: + fsl,blk-ctrl: false + required: + - iommus + - phys + - phy-names + additionalProperties: false examples: