From patchwork Thu Jan 11 04:10:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Liu X-Patchwork-Id: 187162 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1219718dyi; Wed, 10 Jan 2024 20:13:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqDNro3yss46bE2FNv6uCP3HYcPtbPlfvTgwBwDyM/l3eE+3urPN5bZGhFsPsvnZfJ8ST8 X-Received: by 2002:a05:622a:c8:b0:429:bafc:ed3d with SMTP id p8-20020a05622a00c800b00429bafced3dmr83336qtw.19.1704946407863; Wed, 10 Jan 2024 20:13:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704946407; cv=none; d=google.com; s=arc-20160816; b=Y0kjvG+GZoO+a8yHCzBtOnc8mHdSkzy4YcFXpwV7ntmyrrUmzdrJJlmg5dshRvNLwf EbODrfJuU/FNvJrPcGTn39dXK0PTIi2mdkWXo54c83QYo+a/Z7slMJvIfLtrXBkygE2Q dxPHOsmXnhtalrdSYSK3sdYZID2w/F7ALKtcwBgiE5LfSXjZ7cb7m7ScyJOuuYMr7pE5 uj5lqsoaOMAlCGTB5FJnWeot0HUkqj+xHNn+TXA1eyhIzCUM22D3DScSN8DgBQkf+mHe o26+pdVIwpX3YFd0dpqVZgyutVqNMuC3ro+tywr1anWxbvzoRy0tel4UHlzSzDtR1+BX rH5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=CzPAMvTrUGUPJZq8oLQ/EdvlbzClHAMsEqXoZuxGnoo=; fh=aa7ajXSXkJe0gRz4CDJDDWs+jFd1z8IECXwIf+VZeM8=; b=Crfj8idwQtPsZMA+U4zQn8iv+BcfAHnf007tHy8EferkxYYcn0PC1zCJED/vbihoC4 VVSVashHv8hBLteTLV6L3ntOg0pAWNT7z5tpF+LykhDFXu1ls1VoZxrormTOSkqJOhZr nAmF5IFZVL45zqGdGPicZ9fwuLpYGz6kjkOR5Mf3hD+onXvbMnczhWKuCkoyldw2DN/4 buzJr1b4AMMxr7Y8LFNhS6hTKY1zybgUb8/Mthzb5vCDWS0z0TmHa0MhSBstgUu9w5ar B6JrC8UXYLsn3+KFmnT92Tve+nRi2Tuw9+monJC80FbMluEEejv1TBY1ByLTxqVO38YQ ypfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=asQJoT0o; spf=pass (google.com: domain of linux-kernel+bounces-23056-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23056-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x10-20020a05622a000a00b00429c482b5f1si230042qtw.671.2024.01.10.20.13.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 20:13:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23056-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=asQJoT0o; spf=pass (google.com: domain of linux-kernel+bounces-23056-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23056-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A63071C23281 for ; Thu, 11 Jan 2024 04:13:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE8C7101C3; Thu, 11 Jan 2024 04:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="asQJoT0o" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C117ADF69; Thu, 11 Jan 2024 04:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704946234; x=1736482234; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sjL5Dfrqx7fX931BlScUsmc+6VABv8SzlS11acNijUI=; b=asQJoT0oeFC4yI2fXJKJ0sZW3UljPh8MAM5s2Fkw00Pq87Ve3NDOGndd SdtJycS7sx/GZfQsg/smnOF79ZxNV6apITivBFYkItyvGctxd3eGtyN2M 5DDT3Um4e9h3i5/tl0vIGr9YG2strzIW3i/f+n9DcTcd5IE6JDemmoBmp 1oX/Ed5a9v4sLiPOozPZNwJeaNttSrzuJ3mC+HIdy+h5HwGIDL00gCFNq MpxHkBH2T4lKcJ3w6tNZ19virCUgqmsM0PUAGnfKXAjEXUACZSO9Rcun2 oHMjX6Cu6JFxRPByyA/Sp6T8z2Kbhy1fonvd/f/AaJkFjx/fvSfae7qHa g==; X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="389167702" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="389167702" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 20:10:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="1113691918" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="1113691918" Received: from 984fee00a4c6.jf.intel.com ([10.165.58.231]) by fmsmga005.fm.intel.com with ESMTP; 10 Jan 2024 20:10:32 -0800 From: Yi Liu To: joro@8bytes.org, alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com, robin.murphy@arm.com, baolu.lu@linux.intel.com Cc: cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com, yi.l.liu@intel.com, yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com, shameerali.kolothum.thodi@huawei.com, lulu@redhat.com, suravee.suthikulpanit@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, zhenzhong.duan@intel.com, joao.m.martins@oracle.com, xin.zeng@intel.com, yan.y.zhao@intel.com, j.granados@samsung.com, binbin.wu@linux.intel.com Subject: [PATCH v11 8/8] iommu/vt-d: Add iotlb flush for nested domain Date: Wed, 10 Jan 2024 20:10:15 -0800 Message-Id: <20240111041015.47920-9-yi.l.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240111041015.47920-1-yi.l.liu@intel.com> References: <20240111041015.47920-1-yi.l.liu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787765884458195354 X-GMAIL-MSGID: 1787765884458195354 From: Lu Baolu This implements the .cache_invalidate_user() callback to support iotlb flush for nested domain. Reviewed-by: Kevin Tian Signed-off-by: Lu Baolu Co-developed-by: Yi Liu Signed-off-by: Yi Liu --- drivers/iommu/intel/nested.c | 88 ++++++++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) diff --git a/drivers/iommu/intel/nested.c b/drivers/iommu/intel/nested.c index b5a5563ab32c..1e866ed02fef 100644 --- a/drivers/iommu/intel/nested.c +++ b/drivers/iommu/intel/nested.c @@ -73,9 +73,97 @@ static void intel_nested_domain_free(struct iommu_domain *domain) kfree(to_dmar_domain(domain)); } +static void nested_flush_dev_iotlb(struct dmar_domain *domain, u64 addr, + unsigned mask) +{ + struct device_domain_info *info; + unsigned long flags; + u16 sid, qdep; + + spin_lock_irqsave(&domain->lock, flags); + list_for_each_entry(info, &domain->devices, link) { + if (!info->ats_enabled) + continue; + sid = info->bus << 8 | info->devfn; + qdep = info->ats_qdep; + qi_flush_dev_iotlb(info->iommu, sid, info->pfsid, + qdep, addr, mask); + quirk_extra_dev_tlb_flush(info, addr, mask, + IOMMU_NO_PASID, qdep); + } + spin_unlock_irqrestore(&domain->lock, flags); +} + +static void intel_nested_flush_cache(struct dmar_domain *domain, u64 addr, + unsigned long npages, bool ih) +{ + struct iommu_domain_info *info; + unsigned long i; + unsigned mask; + + xa_for_each(&domain->iommu_array, i, info) + qi_flush_piotlb(info->iommu, + domain_id_iommu(domain, info->iommu), + IOMMU_NO_PASID, addr, npages, ih); + + if (!domain->has_iotlb_device) + return; + + if (npages == U64_MAX) + mask = 64 - VTD_PAGE_SHIFT; + else + mask = ilog2(__roundup_pow_of_two(npages)); + + nested_flush_dev_iotlb(domain, addr, mask); +} + +static int intel_nested_cache_invalidate_user(struct iommu_domain *domain, + struct iommu_user_data_array *array) +{ + struct dmar_domain *dmar_domain = to_dmar_domain(domain); + struct iommu_hwpt_vtd_s1_invalidate inv_entry; + u32 index, processed = 0; + int ret = 0; + + if (array->type != IOMMU_HWPT_INVALIDATE_DATA_VTD_S1) { + ret = -EINVAL; + goto out; + } + + for (index = 0; index < array->entry_num; index++) { + ret = iommu_copy_struct_from_user_array(&inv_entry, array, + IOMMU_HWPT_INVALIDATE_DATA_VTD_S1, + index, __reserved); + if (ret) + break; + + if ((inv_entry.flags & ~IOMMU_VTD_INV_FLAGS_LEAF) || + inv_entry.__reserved) { + ret = -EOPNOTSUPP; + break; + } + + if (!IS_ALIGNED(inv_entry.addr, VTD_PAGE_SIZE) || + ((inv_entry.npages == U64_MAX) && inv_entry.addr)) { + ret = -EINVAL; + break; + } + + intel_nested_flush_cache(dmar_domain, inv_entry.addr, + inv_entry.npages, + inv_entry.flags & IOMMU_VTD_INV_FLAGS_LEAF); + processed++; + } + +out: + array->entry_num = processed; + return ret; +} + static const struct iommu_domain_ops intel_nested_domain_ops = { .attach_dev = intel_nested_attach_dev, .free = intel_nested_domain_free, + .cache_invalidate_user = intel_nested_cache_invalidate_user, }; struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *parent,