Message ID | 20240111-lpg-v3-1-811c9e82dae4@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-22996-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1194912dyi; Wed, 10 Jan 2024 18:54:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFH7OJ43QiCoC1aDGrcUKRSlCCuc2YkLsvruouCYf6XzAPF6w5/HFzt/bQJdKCK+gc/jH3f X-Received: by 2002:a2e:9914:0:b0:2cc:e215:734a with SMTP id v20-20020a2e9914000000b002cce215734amr229313lji.45.1704941660436; Wed, 10 Jan 2024 18:54:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704941660; cv=none; d=google.com; s=arc-20160816; b=DZiSO2zJoor/rBBi/i05PuceiGYUyUgndr9gwrVdpPVMFEo9NUQ54D4fGw5pbRjZBs /MHGga4eWkdgYlOIzu9vJKTWU2kSIljUxqwbir9jRt2UxFLvcUXFk2ijZMxa91/yWiE+ ZCpE2qJcOz44i/bWoa/ws/8bDgP39dAE81UTnxnTpL/1oMGVuy6V0TQs1P1kmbfDnJCB vUrv8/E2U1MmZvFDT/kOw0wviPAbgzWXSY3j/d91zOZ6fu2IjvoXzaEq6LmVhO7BqEF7 9Cbr2/z0BV78sz4FnM0PHtcUQY67OKiQmdwwndozr4IshB/l5U9ZreiBa8t3T5WCKWPf feNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=XX8qwF+4bxWeXjjcxN6e4JMmR8Y/hjXCSVtmvHbqc7I=; fh=5Nw6CUKfQDR0dyHzzV7EuwdgQ4LSCXOAo1TFv08iboM=; b=weffcRGRBLgQU4IVoWolNaU5Y9s7rp578dYpzNXocmYFdgOKx/QuVzKDYk1Eh1Z5F1 WSQSQOtQnEzI0jorIQhAwKkPVAdCYe/+wb+BIGfnmki3tygCeuynnkICk3p/JAZDsyOb B8MT5aN1AHm1MB822pA4JCMIJwDycO3YkgCkn80LbBM6/komldsgJa/KS0Edd5elc7Q7 gSI8B5xPS5ucci3ApQCJpM+3Y2hQSDOZhexwAodne7or+KyLJ39UNjSQCTezE1DejOsn ajcuFwTH5FOGWFtP/BTUowliyFdq8lsI5aAbMMDbz7prSwaE4ZUwnmrh3KT/qSpWyc1t H0og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eb3wna++; spf=pass (google.com: domain of linux-kernel+bounces-22996-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22996-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id er7-20020a056402448700b0055640a7fb40si90136edb.36.2024.01.10.18.54.20 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 18:54:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22996-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eb3wna++; spf=pass (google.com: domain of linux-kernel+bounces-22996-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22996-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 100301F23C70 for <ouuuleilei@gmail.com>; Thu, 11 Jan 2024 02:54:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9B261110; Thu, 11 Jan 2024 02:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eb3wna++" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA171C16; Thu, 11 Jan 2024 02:53:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 80DD2C433C7; Thu, 11 Jan 2024 02:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704941638; bh=UplJWH4Q/tqUK9lL0NeQ0i3KjWIEOgUf4v3sM9Fc79Q=; h=From:Date:Subject:To:Cc:Reply-To:From; b=eb3wna++o9nQcqx77zTqpfG0Z/wRpYlPwZs0rmcvTuNqEbn7k7TMFkhNJMdvyBpJh R1V2IJEjM6qiNvxMFkrbh5GS/n+Q3tHRx6lAzwIyVEoBxMOCSP5HmJmgI9AxG5AKki /1dSjcuJv7TXCzo9wDB8Idmykw3SJZ1sUEGKJJPKjCEU1E5yiUquWCsAbzIz97oGmV HnEFZpk2LbELB3rHWYPrX0s/yBtAHy5QtWKePD8y4z530RtTfB6uT066zEhXS8sU1x zoqUf+ZZBjrm5YP9yiCCGds2iMzheJyoi3H43E9+fouM6l0eiqbUjrbkQaJqqrJIRb r4Vsp/f+nWahQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D7F4C4707C; Thu, 11 Jan 2024 02:53:58 +0000 (UTC) From: Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> Date: Thu, 11 Jan 2024 10:52:58 +0800 Subject: [PATCH RESEND v3] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs. Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240111-lpg-v3-1-811c9e82dae4@quicinc.com> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hui Liu <quic_huliu@quicinc.com> X-Mailer: b4 0.13-dev-83828 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704941637; l=1646; i=quic_huliu@quicinc.com; s=20230823; h=from:subject:message-id; bh=jkgKPcTHB0LvObnOdM+JMFH2yGRqbzzTL1fwXf6UZho=; b=7pv7EDwJ2g9yQxFYnyhYX0JwYuAgStVMqFM5Z0qMfu0ILqrf5UFuKESXSC6pCrzbri/kt6bX7 FmKxPZuaEx5AvdmlXsmr7nBM3vNCFvVJw3JDYNjt8GDx1QqzDTtxX8t X-Developer-Key: i=quic_huliu@quicinc.com; a=ed25519; pk=1z+A50UnTuKe/FdQv2c0W3ajDsJOYddwIHo2iivhTTA= X-Endpoint-Received: by B4 Relay for quic_huliu@quicinc.com/20230823 with auth_id=80 X-Original-From: Hui Liu <quic_huliu@quicinc.com> Reply-To: <quic_huliu@quicinc.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787760906425978822 X-GMAIL-MSGID: 1787760906425978822 |
Series |
[RESEND,v3] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs.
|
|
Commit Message
Hui Liu via B4 Relay
Jan. 11, 2024, 2:52 a.m. UTC
From: Hui Liu <quic_huliu@quicinc.com> Add definition for three LEDs to make sure they can be enabled base on QCOM LPG LED driver. Signed-off-by: Hui Liu <quic_huliu@quicinc.com> --- Changes in v3: - Rephrased commit text and updated the nodes to qcm6490-idp board file. - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ Changes in v2: - Rephrased commit text and updated the nodes to board file. - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com --- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) --- base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 change-id: 20231215-lpg-4aadd374811a Best regards,
Comments
On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > > From: Hui Liu <quic_huliu@quicinc.com> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > Changes in v3: > - Rephrased commit text and updated the nodes to qcm6490-idp board file. The commit message is the same as in v2. Commit subject mentions non-existing board, "qcs6490-idp" > - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ > > Changes in v2: > - Rephrased commit text and updated the nodes to board file. > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index 37c91fdf3ab9..f801144a1556 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -5,6 +5,7 @@ > > /dts-v1/; > > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sc7280.dtsi" > #include "pm7325.dtsi" > @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { > }; > }; > > +&pm8350c_pwm { > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + label = "red"; Is there any reason why Krzysztof's review for v2 was ignored? Let me repeat it here: "Drop labels. You already have color, so you miss function." > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + label = "green"; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + label = "blue"; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > > --- > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > change-id: 20231215-lpg-4aadd374811a > > Best regards, > -- > Hui Liu <quic_huliu@quicinc.com> > >
On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote: > From: Hui Liu <quic_huliu@quicinc.com> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > Changes in v3: > - Rephrased commit text and updated the nodes to qcm6490-idp board file. > - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ > > Changes in v2: > - Rephrased commit text and updated the nodes to board file. > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index 37c91fdf3ab9..f801144a1556 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -5,6 +5,7 @@ > > /dts-v1/; > > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sc7280.dtsi" > #include "pm7325.dtsi" > @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { > }; > }; > > +&pm8350c_pwm { > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; Hi Hui Liu, > + color = <LED_COLOR_ID_RED>; > + label = "red"; Please remove the deprecated "label" property. Since you already have "color" set you only need to add "function". On phones for the notification LED we usually use "function = LED_FUNCTION_STATUS;" Also depends on what your hardware looks like, if it's 3 separate LEDs then with label replaced it would be okay. If the 3 LEDs are in one spot (so you can mix the colors with it), then please make it a RGB multi-led like e.g. in sm8550-qrd.dts. Regards Luca > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + label = "green"; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + label = "blue"; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > > --- > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > change-id: 20231215-lpg-4aadd374811a > > Best regards,
On 11/01/2024 09:47, Luca Weiss wrote: > On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote: >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..f801144a1556 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; > > Hi Hui Liu, > >> + color = <LED_COLOR_ID_RED>; >> + label = "red"; > > Please remove the deprecated "label" property. Since you already have > "color" set you only need to add "function". On phones for the > notification LED we usually use "function = LED_FUNCTION_STATUS;" > > Also depends on what your hardware looks like, if it's 3 separate LEDs > then with label replaced it would be okay. > If the 3 LEDs are in one spot (so you can mix the colors with it), then > please make it a RGB multi-led like e.g. in sm8550-qrd.dts. > I already asked for this and it was ignored: https://lore.kernel.org/all/6aa67adb-a4d5-40da-a261-c90050ac04b2@linaro.org/ Let's engage three different community reviewers to repeat the same, one feedback. This is just disrespectful to our time. Best regards, Krzysztof
On 1/11/2024 4:58 PM, Krzysztof Kozlowski wrote: > On 11/01/2024 09:47, Luca Weiss wrote: >> On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote: >>> From: Hui Liu <quic_huliu@quicinc.com> >>> >>> Add definition for three LEDs to make sure they can >>> be enabled base on QCOM LPG LED driver. >>> >>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >>> --- >>> Changes in v3: >>> - Rephrased commit text and updated the nodes to qcm6490-idp board file. >>> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >>> >>> Changes in v2: >>> - Rephrased commit text and updated the nodes to board file. >>> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >>> --- >>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> index 37c91fdf3ab9..f801144a1556 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> @@ -5,6 +5,7 @@ >>> >>> /dts-v1/; >>> >>> +#include <dt-bindings/leds/common.h> >>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >>> #include "sc7280.dtsi" >>> #include "pm7325.dtsi" >>> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { >>> }; >>> }; >>> >>> +&pm8350c_pwm { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "okay"; >>> + >>> + led@1 { >>> + reg = <1>; >> >> Hi Hui Liu, >> >>> + color = <LED_COLOR_ID_RED>; >>> + label = "red"; >> >> Please remove the deprecated "label" property. Since you already have >> "color" set you only need to add "function". On phones for the >> notification LED we usually use "function = LED_FUNCTION_STATUS;" >> >> Also depends on what your hardware looks like, if it's 3 separate LEDs >> then with label replaced it would be okay. >> If the 3 LEDs are in one spot (so you can mix the colors with it), then >> please make it a RGB multi-led like e.g. in sm8550-qrd.dts. >> > > I already asked for this and it was ignored: > > https://lore.kernel.org/all/6aa67adb-a4d5-40da-a261-c90050ac04b2@linaro.org/ > > Let's engage three different community reviewers to repeat the same, one > feedback. This is just disrespectful to our time. Sorry, I ignored that comments, I will submit v4 to update it. Thanks for your comments. > > Best regards, > Krzysztof >
On 1/11/2024 4:47 PM, Luca Weiss wrote: > On Thu Jan 11, 2024 at 3:52 AM CET, Hui Liu via B4 Relay wrote: >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..f801144a1556 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; > > Hi Hui Liu, > >> + color = <LED_COLOR_ID_RED>; >> + label = "red"; > > Please remove the deprecated "label" property. Since you already have > "color" set you only need to add "function". On phones for the > notification LED we usually use "function = LED_FUNCTION_STATUS;" > I will remove it at next version, thanks! > Also depends on what your hardware looks like, if it's 3 separate LEDs > then with label replaced it would be okay. > If the 3 LEDs are in one spot (so you can mix the colors with it), then > please make it a RGB multi-led like e.g. in sm8550-qrd.dts The 3 LEDs are separate. > Regards > Luca > >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + label = "green"; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + label = "blue"; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >
On 1/11/2024 11:38 AM, Dmitry Baryshkov wrote: > On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. > > The commit message is the same as in v2. > > Commit subject mentions non-existing board, "qcs6490-idp" > >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..f801144a1556 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + label = "red"; > > Is there any reason why Krzysztof's review for v2 was ignored? Let me > repeat it here: "Drop labels. You already have color, so you miss > function." I will update it. > > >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + label = "green"; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + label = "blue"; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >> -- >> Hui Liu <quic_huliu@quicinc.com> >> >> > >
On 1/11/2024 11:38 AM, Dmitry Baryshkov wrote: > On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. > > The commit message is the same as in v2. > > Commit subject mentions non-existing board, "qcs6490-idp" This devicetree file of this board has been merged in linux-next, https://lore.kernel.org/linux-arm-msm/170157925812.1717511.10611634209504625070.b4-ty@kernel.org/ > >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..f801144a1556 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + label = "red"; > > Is there any reason why Krzysztof's review for v2 was ignored? Let me > repeat it here: "Drop labels. You already have color, so you miss > function." > > >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + label = "green"; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + label = "blue"; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >> -- >> Hui Liu <quic_huliu@quicinc.com> >> >> > >
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts index 37c91fdf3ab9..f801144a1556 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts @@ -5,6 +5,7 @@ /dts-v1/; +#include <dt-bindings/leds/common.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sc7280.dtsi" #include "pm7325.dtsi" @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { }; }; +&pm8350c_pwm { + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + label = "red"; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + label = "green"; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + label = "blue"; + }; +}; + &qupv3_id_0 { status = "okay"; };