From patchwork Tue Jan 9 13:34:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 186390 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp111639dyi; Tue, 9 Jan 2024 05:38:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGs+oF6F3TEmiVN6YgToaRaUQrKc/DUmsvXAV36VbOj9jo0iU5gKhTUGodHuq8hk8iHdveW X-Received: by 2002:a17:90a:cf06:b0:28c:ad71:9617 with SMTP id h6-20020a17090acf0600b0028cad719617mr2373577pju.48.1704807525957; Tue, 09 Jan 2024 05:38:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704807525; cv=none; d=google.com; s=arc-20160816; b=gWKz8BVV8N92Jpo3htxNYRLD7qDhHSBEP/AOoHIx+/aPs3lAarKVHRQtKvh1mpoEyQ pvYXQ6Zq91OYqgkfVrwDQmKzFZe/cXCulZbNXUI5JcV9Ph0umfd5GQQy5isq6zh8wdei iqnxhMZIHPWbbClc8f/qQrM1M7O6Lnz8cEjHRDGUMwRvnivwsP70atdXBEPSRt3XXxjg bLmHLoNwaXcdg5pgtlve3Da71HsNDdapy4/xNgzNvMnaiwygIw8acZ+nfhpljS0pJfQ5 lFDn+kkjc29l6k/R6Zd/pJefq16JiNk2SvOvxDTL5xSuDB8hVaAPQaq96gRgd/78/re2 SiRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter; bh=TdzphiKewiAEGb5mVeNRXY8JwRsEqxcS+5rYPinKWAY=; fh=8J42c8+O3ffBvuBze3MX/0D2nvEHkxpHHQL1Xm4pXzQ=; b=DrV2D3uGEN6fhA5SEEZHdjHIg/an2dsvJS+ObABBfdzZ/OdDfVYTKXJl9Co58zEgKO 2iJMuJEY78GdJzj+MEYEqVzg7mhfkbw1KrmeHvEN8cYJhP2hJzRexbtHJ1Vhi4ELbEl0 IeIeCXf8EuPkoUvGzPc/LSxbxfhxtVhwZiPIImkQCVa0NBs23fetmc63Trdq3ugOojPX C0WJZQ/vXDCLo7KJNQ4uu3Y3YGUGiN6iuwVxYukRhcANWeyPkRzs98wjifRzaWyiQelx dBH75Tzt5ul2Mj77C4nBPIgLj9A4wgHHSYe6+aPpcr1alWyPdwSy49RppQhSNm6F5vOY yDFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Rl1Ovwlq; spf=pass (google.com: domain of linux-kernel+bounces-20906-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20906-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id ay9-20020a17090b030900b0028cf2b39b57si7278084pjb.109.2024.01.09.05.38.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 05:38:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20906-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Rl1Ovwlq; spf=pass (google.com: domain of linux-kernel+bounces-20906-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20906-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2473CB23D3C for ; Tue, 9 Jan 2024 13:37:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AF2B3984B; Tue, 9 Jan 2024 13:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="Rl1Ovwlq" Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1141838F9F; Tue, 9 Jan 2024 13:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Received: from localhost.ispras.ru (unknown [10.10.165.2]) by mail.ispras.ru (Postfix) with ESMTPSA id 5CB2240737DD; Tue, 9 Jan 2024 13:37:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 5CB2240737DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1704807436; bh=TdzphiKewiAEGb5mVeNRXY8JwRsEqxcS+5rYPinKWAY=; h=From:To:Cc:Subject:Date:From; b=Rl1OvwlqxuwvpisiP4VBWnGLxvuCidOwAPlrS6WQp+tgypcJOmosmZNGPAyUSSXKn l01p+tt421gxRXq14syQ/JhWyMnZkzlmbwsDeenhMvaKkPVNsoclgqx30ksVstFfV2 kFLKJvkOV5udxD91wDb77P3lvTpiIURTuGsdMbtQ= From: Fedor Pchelkin To: Namjae Jeon Cc: Fedor Pchelkin , Steve French , Sergey Senozhatsky , Tom Talpey , Ronnie Sahlberg , Hyunchul Lee , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: [PATCH] ksmbd: free ppace array on error in parse_dacl Date: Tue, 9 Jan 2024 16:34:27 +0300 Message-ID: <20240109133429.31752-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787620256350714605 X-GMAIL-MSGID: 1787620256350714605 Free the ppace array if one of the init_acl_state() calls inside parse_dacl() fails. At the moment the function may fail only due to the memory allocation errors so it's highly unlikely in this case but nevertheless a fix is needed. Found by Linux Verification Center (linuxtesting.org). Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3") Signed-off-by: Fedor Pchelkin --- fs/smb/server/smbacl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/smb/server/smbacl.c b/fs/smb/server/smbacl.c index 1164365533f0..e6d0537cab49 100644 --- a/fs/smb/server/smbacl.c +++ b/fs/smb/server/smbacl.c @@ -406,11 +406,14 @@ static void parse_dacl(struct mnt_idmap *idmap, return; ret = init_acl_state(&acl_state, num_aces); - if (ret) + if (ret) { + kfree(ppace); return; + } ret = init_acl_state(&default_acl_state, num_aces); if (ret) { free_acl_state(&acl_state); + kfree(ppace); return; }