From patchwork Tue Jan 9 11:20:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 186325 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp41013dyi; Tue, 9 Jan 2024 03:23:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLaoyzR6QW8dVFLHAcP/iaBaPdWjICeNq45ax12RFAGK8W4T/tNgccoyNpclo+jqy8vH4k X-Received: by 2002:a05:6a00:a07:b0:6da:fc26:44c1 with SMTP id p7-20020a056a000a0700b006dafc2644c1mr1529745pfh.44.1704799393795; Tue, 09 Jan 2024 03:23:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704799393; cv=none; d=google.com; s=arc-20160816; b=KsACknK6sunk71BYtuKFEqVVo3SG2dA9puajgnTTmMtrS6KapdZpuS3CVsERJxgkx1 cF0ODvyigHqHwg+bT6aGpyn80vc+Xz/VYNl7WP3BF7/n4ZTp8qd6uHl7NNzIj05a8J1+ XFLt3dAArWpFxCFHStek3QU5u6a1A7knkaXYLxYmaJgdZtuSKwpswh8JGmygrngUEMT4 W+wnnMK/n5eTXI7KxWqfB+sRrlUaR8vJADLLn40kGGfcyJtTUymnDe3S+7ViqDs16uhl 9mQ8Us3/hCZMs+3SH0LUo6DEp/VgEJaGRra8/R4H7c1sdX33/BhHOAl6dXLQVSK1P8nr OBXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rr5EJ/KUtWAGcPxbo/TizcNZKdZiXnS9Nbdtw3WvDek=; fh=wHeWnRAPvg2xJ56RgmOMhm93PiD0Bj1H5ZiEjecP7fw=; b=PhwYXZOND9gq/pV/Ok06fdEMv57h9JY4MCJKDSMj7WA4MlAQwVNxdchSFAxN78LCdT 9m1lAtkUxbsqT9JfeGaV73LKKrnTG3IVQb/hmrkBcxhRW+X9atTULaIn/DjZzsjmgANS bh0sK4m0BlDINO3WWLhaPeK16D4LSuIGD3ZshvJdCCRPcJDaLgup/4/mvtiugamsCIoz rAS7O4hTRPO08d5gE/jpCJgDV/j7lcbn9SbrLVPJH4naw5tQ86Evg1eMFc6F2k0pOqEa CINuDg9UIefixVfpEBhup6B/T5eOHJnxxataFCz2DgkM3IKfq06ZdIsJyPXGx0dDV3hi uhlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CdravXAG; spf=pass (google.com: domain of linux-kernel+bounces-20757-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20757-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id ko8-20020a056a00460800b006cbd8179b4csi1330672pfb.108.2024.01.09.03.23.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 03:23:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20757-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CdravXAG; spf=pass (google.com: domain of linux-kernel+bounces-20757-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20757-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 45068B235AE for ; Tue, 9 Jan 2024 11:22:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B20E38DD2; Tue, 9 Jan 2024 11:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CdravXAG" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D666381CA for ; Tue, 9 Jan 2024 11:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704799251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rr5EJ/KUtWAGcPxbo/TizcNZKdZiXnS9Nbdtw3WvDek=; b=CdravXAGI+7Xpx3Ur/TbRD21FdYohyR9vtJs7zWEqCv3f47T7ZsG+neLmRLhTvxrAjKUmv 7KEnIMFRWHWs8m+MV/8D9KerEEBDleHRmEXWfUIWuxLk6m+CmuDNdXCnvP+p3OJ3UmZtI5 4MDElHK5+yTzwqkKUT4h0fkertsUZc8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-EIoi-qiVMCWdOvvkHaBtvw-1; Tue, 09 Jan 2024 06:20:43 -0500 X-MC-Unique: EIoi-qiVMCWdOvvkHaBtvw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59A0D29AA3A5; Tue, 9 Jan 2024 11:20:42 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E2DBC15A0C; Tue, 9 Jan 2024 11:20:39 +0000 (UTC) From: David Howells To: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet Cc: David Howells , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] netfs: Mark netfs_unbuffered_write_iter_locked() static Date: Tue, 9 Jan 2024 11:20:18 +0000 Message-ID: <20240109112029.1572463-2-dhowells@redhat.com> In-Reply-To: <20240109112029.1572463-1-dhowells@redhat.com> References: <20240109112029.1572463-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787611728806616599 X-GMAIL-MSGID: 1787611728806616599 Mark netfs_unbuffered_write_iter_locked() static as it's only called from the file in which it is defined. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/direct_write.c | 4 ++-- fs/netfs/internal.h | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/netfs/direct_write.c b/fs/netfs/direct_write.c index aad05f2349a4..b9cbfd6a8a01 100644 --- a/fs/netfs/direct_write.c +++ b/fs/netfs/direct_write.c @@ -27,8 +27,8 @@ static void netfs_cleanup_dio_write(struct netfs_io_request *wreq) * Perform an unbuffered write where we may have to do an RMW operation on an * encrypted file. This can also be used for direct I/O writes. */ -ssize_t netfs_unbuffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *iter, - struct netfs_group *netfs_group) +static ssize_t netfs_unbuffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *iter, + struct netfs_group *netfs_group) { struct netfs_io_request *wreq; unsigned long long start = iocb->ki_pos; diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h index d2d63120ac60..a6dfc8888377 100644 --- a/fs/netfs/internal.h +++ b/fs/netfs/internal.h @@ -26,12 +26,6 @@ void netfs_rreq_unlock_folios(struct netfs_io_request *rreq); int netfs_prefetch_for_write(struct file *file, struct folio *folio, size_t offset, size_t len); -/* - * direct_write.c - */ -ssize_t netfs_unbuffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *iter, - struct netfs_group *netfs_group); - /* * io.c */