Message ID | 20240108183302.255055-2-afd@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-19964-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp1202916dyq; Mon, 8 Jan 2024 10:35:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXF5oiRjVQRRWXpSqpsow66cGN0pAEolMK8hAkcu6iheAyCJV5xOE6FRlvXkFQkihdZx8c X-Received: by 2002:a17:902:bd95:b0:1d4:44cf:abe2 with SMTP id q21-20020a170902bd9500b001d444cfabe2mr1786093pls.113.1704738938247; Mon, 08 Jan 2024 10:35:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704738938; cv=none; d=google.com; s=arc-20160816; b=CiPMk4s8vPaPrAsvdyY0wYdoGaTPvxHbP1JOrhrS/AMJo31m1Ibi/nblATSKn1x0wI w1dTi0b45U29vu6aZrI5s70yTIlu71gHk/cDAfpNCcUC8PO8tWaX3Gt+3kyIlyMsm21A OTk5X00/zCkkz6xllgU6sR/wAce3/WVV5WTaEAhL1LBnfdywezZk8Mxqc+XZJRo/Jsdi z3B+ZuqDNR1xYK5m0mSac7QF4x6zstqRmg4rAtUYZ2kxKnCb7H3a56exDo9el1RqoKm1 GGp92uOFEvUVWyHrQ1jAWqJ7eesdlmTRAQDVxUSHxYjiN0DzEUNYM7fX9VHb8+Y6O5HC 8u+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Gdhx6GMh4rVP3km5x1uoGL2Uoq7UqUUHtltyRBPwCl8=; fh=KxsLCgRx1W60WvlrtjrMBLJnN6MITNW0a37pWS2ejYg=; b=XlmETfC5tcbxE47bdiP4YgCw30Q43PoMEhfmeXrlnLV+VPis4Nn+KUijwHbQJiET0S KPrKnubO811HLeJLFwco3kY3O6dAK/PTwo2eIohslMZvz+7ZncfomJWyQ9js/jRkiFuI vdGoW4EH5BlDIF3HlpVJPVGdnpyn/IbXJOFoep+2A+u+5+mzwRylqUri813hpmNS8rK4 MwFEczwENBQ5EuUi8jCEOXll2oIAM358dfCCTujuHyOJ5srNquBU1QvlMn388TP1vCAb mCkRk1IadHaKyUbqlFakDKw8MaG22F/MTjlW0fQjcOeIw5+uECeCrxHfSfLTWWzv88VL yuGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=tIC3FO5N; spf=pass (google.com: domain of linux-kernel+bounces-19964-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19964-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id w2-20020a170902e88200b001d3b2366adasi255173plg.35.2024.01.08.10.35.37 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 10:35:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19964-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=tIC3FO5N; spf=pass (google.com: domain of linux-kernel+bounces-19964-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19964-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id CD4C1B22E96 for <ouuuleilei@gmail.com>; Mon, 8 Jan 2024 18:34:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D14D555C12; Mon, 8 Jan 2024 18:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tIC3FO5N" X-Original-To: linux-kernel@vger.kernel.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C9247793; Mon, 8 Jan 2024 18:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 408IX5ms041769; Mon, 8 Jan 2024 12:33:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704738785; bh=Gdhx6GMh4rVP3km5x1uoGL2Uoq7UqUUHtltyRBPwCl8=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=tIC3FO5NGBdpNDZlL287om+LGb2BYGIgBzpWR4Jj6OVKhN1b5dqIyLqSNRd3Asg27 PYv3+qbzz6maBy2EnNEuv8N8WDCe6hqy8SionOywnJa55CZ2Gmu/CwUGPkD1dzCZ/v emN536JMSU2ovagvBOND/1UjP9UZWTchj78/WjV4= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 408IX5mU022175 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jan 2024 12:33:05 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 8 Jan 2024 12:33:05 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 8 Jan 2024 12:33:05 -0600 Received: from lelvsmtp5.itg.ti.com ([10.249.40.136]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 408IX3hA051691; Mon, 8 Jan 2024 12:33:04 -0600 From: Andrew Davis <afd@ti.com> To: Frank Binns <frank.binns@imgtec.com>, Donald Robson <donald.robson@imgtec.com>, Matt Coster <matt.coster@imgtec.com>, "H . Nikolaus Schaller" <hns@goldelico.com>, Adam Ford <aford173@gmail.com>, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, =?utf-8?q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>, Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Paul Cercueil <paul@crapouillou.net> CC: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-sunxi@lists.linux.dev>, <linux-omap@vger.kernel.org>, <linux-mips@vger.kernel.org>, Andrew Davis <afd@ti.com> Subject: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Date: Mon, 8 Jan 2024 12:32:52 -0600 Message-ID: <20240108183302.255055-2-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240108183302.255055-1-afd@ti.com> References: <20240108183302.255055-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787548336712635131 X-GMAIL-MSGID: 1787548336712635131 |
Series |
Device tree support for Imagination Series5 GPU
|
|
Commit Message
Andrew Davis
Jan. 8, 2024, 6:32 p.m. UTC
Signed-off-by: Andrew Davis <afd@ti.com>
---
.../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++--
MAINTAINERS | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} (91%)
Comments
Andrew Davis <afd@ti.com> writes: Hello Andrew, > Signed-off-by: Andrew Davis <afd@ti.com> > --- I think this deserves a commit message with the rationale for the rename. Because kept an eye to the previous version, I know the reason and agree with the change. Also, if remember correctly this was suggested by Maxime? After a adding a commit message and Suggested-by tag: Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi Andrew, On Mon, 2024-01-08 at 12:32 -0600, Andrew Davis wrote: > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- > MAINTAINERS | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} (91%) > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > similarity index 91% > rename from Documentation/devicetree/bindings/gpu/img,powervr.yaml > rename to Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index a13298f1a1827..03a8308b41ae7 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -2,10 +2,10 @@ > # Copyright (c) 2023 Imagination Technologies Ltd. > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# > +$id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Imagination Technologies PowerVR and IMG GPU > +title: Imagination Technologies PowerVR Rogue and IMG GPUs All the GPUs that will appear in this file will be Rogues, so for me it would be more natural for 'Rogue' to come after 'IMG'. Can you change the title to: Imagination Technologies PowerVR and IMG Rogue GPUs With that changed and Javier's suggestions addressed: Reviewed-by: Frank Binns <frank.binns@imgtec.com> > > maintainers: > - Frank Binns <frank.binns@imgtec.com> > diff --git a/MAINTAINERS b/MAINTAINERS > index fa67e2624723f..5b205795da04e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10461,7 +10461,7 @@ M: Donald Robson <donald.robson@imgtec.com> > M: Matt Coster <matt.coster@imgtec.com> > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: Documentation/devicetree/bindings/gpu/img,powervr.yaml > +F: Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > F: Documentation/gpu/imagination/ > F: drivers/gpu/drm/imagination/ > F: include/uapi/drm/pvr_drm.h
On 08/01/2024 19:32, Andrew Davis wrote: > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- > MAINTAINERS | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) If you are renaming it, why not renaming to match compatible as we usually expect? Best regards, Krzysztof
On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote: > On 08/01/2024 19:32, Andrew Davis wrote: >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- >> MAINTAINERS | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > If you are renaming it, why not renaming to match compatible as we > usually expect? > There are (or will be) multiple compatible strings described in this file, naming the file after just one would not fully convey the content of the file. This generic style naming seems common already for bindings with multiple compatibles. Andrew > Best regards, > Krzysztof >
On 09/01/2024 17:14, Andrew Davis wrote: > On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote: >> On 08/01/2024 19:32, Andrew Davis wrote: >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- >>> MAINTAINERS | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> If you are renaming it, why not renaming to match compatible as we >> usually expect? >> > > There are (or will be) multiple compatible strings described in this > file, naming the file after just one would not fully convey the content > of the file. This generic style naming seems common already for bindings > with multiple compatibles. I saw only one compatible used as fallback. Where are more? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml similarity index 91% rename from Documentation/devicetree/bindings/gpu/img,powervr.yaml rename to Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml index a13298f1a1827..03a8308b41ae7 100644 --- a/Documentation/devicetree/bindings/gpu/img,powervr.yaml +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml @@ -2,10 +2,10 @@ # Copyright (c) 2023 Imagination Technologies Ltd. %YAML 1.2 --- -$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# +$id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Imagination Technologies PowerVR and IMG GPU +title: Imagination Technologies PowerVR Rogue and IMG GPUs maintainers: - Frank Binns <frank.binns@imgtec.com> diff --git a/MAINTAINERS b/MAINTAINERS index fa67e2624723f..5b205795da04e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10461,7 +10461,7 @@ M: Donald Robson <donald.robson@imgtec.com> M: Matt Coster <matt.coster@imgtec.com> S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc -F: Documentation/devicetree/bindings/gpu/img,powervr.yaml +F: Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml F: Documentation/gpu/imagination/ F: drivers/gpu/drm/imagination/ F: include/uapi/drm/pvr_drm.h