[net-next,01/10] net: fill in MODULE_DESCRIPTION()s for 8390
Commit Message
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to all the good old 8390 modules and drivers.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/8390/8390.c | 1 +
drivers/net/ethernet/8390/8390p.c | 1 +
drivers/net/ethernet/8390/apne.c | 1 +
drivers/net/ethernet/8390/hydra.c | 1 +
drivers/net/ethernet/8390/stnic.c | 1 +
drivers/net/ethernet/8390/zorro8390.c | 1 +
6 files changed, 6 insertions(+)
Comments
Hi Breno,
On Mon, Jan 8, 2024 at 7:17 PM Breno Leitao <leitao@debian.org> wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to all the good old 8390 modules and drivers.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Thanks for your patch!
> --- a/drivers/net/ethernet/8390/apne.c
> +++ b/drivers/net/ethernet/8390/apne.c
> @@ -610,4 +610,5 @@ static int init_pcmcia(void)
> return 1;
> }
>
> +MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver");
I would write:
National Semiconductor 8390 Amiga PCMCIA ethernet driver
as this driver does not work on generic platforms with a PCMCIA slot.
> MODULE_LICENSE("GPL");
Gr{oetje,eeting}s,
Geert
On Tue, Jan 09, 2024 at 12:25:14PM +0100, Geert Uytterhoeven wrote:
> Hi Breno,
>
> On Mon, Jan 8, 2024 at 7:17 PM Breno Leitao <leitao@debian.org> wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to all the good old 8390 modules and drivers.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
>
> Thanks for your patch!
>
> > --- a/drivers/net/ethernet/8390/apne.c
> > +++ b/drivers/net/ethernet/8390/apne.c
> > @@ -610,4 +610,5 @@ static int init_pcmcia(void)
> > return 1;
> > }
> >
> > +MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver");
>
> I would write:
>
> National Semiconductor 8390 Amiga PCMCIA ethernet driver
>
> as this driver does not work on generic platforms with a PCMCIA slot.
Thanks. I will update and send a v2.
@@ -100,4 +100,5 @@ static void __exit ns8390_module_exit(void)
module_init(ns8390_module_init);
module_exit(ns8390_module_exit);
#endif /* MODULE */
+MODULE_DESCRIPTION("National Semiconductor 8390 core driver");
MODULE_LICENSE("GPL");
@@ -102,4 +102,5 @@ static void __exit NS8390p_cleanup_module(void)
module_init(NS8390p_init_module);
module_exit(NS8390p_cleanup_module);
+MODULE_DESCRIPTION("National Semiconductor 8390 core for ISA driver");
MODULE_LICENSE("GPL");
@@ -610,4 +610,5 @@ static int init_pcmcia(void)
return 1;
}
+MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver");
MODULE_LICENSE("GPL");
@@ -270,4 +270,5 @@ static void __exit hydra_cleanup_module(void)
module_init(hydra_init_module);
module_exit(hydra_cleanup_module);
+MODULE_DESCRIPTION("Zorro-II Hydra 8390 ethernet driver");
MODULE_LICENSE("GPL");
@@ -296,4 +296,5 @@ static void __exit stnic_cleanup(void)
module_init(stnic_probe);
module_exit(stnic_cleanup);
+MODULE_DESCRIPTION("National Semiconductor DP83902AV ethernet driver");
MODULE_LICENSE("GPL");
@@ -443,4 +443,5 @@ static void __exit zorro8390_cleanup_module(void)
module_init(zorro8390_init_module);
module_exit(zorro8390_cleanup_module);
+MODULE_DESCRIPTION("Zorro NS8390-based ethernet driver");
MODULE_LICENSE("GPL");