| Message ID | 20240108131216.53867-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-19596-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp1007890dyq;
Mon, 8 Jan 2024 05:12:54 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IHi9gzqBdX7vrbx58S0ZeABcjyR8RGc4REL7bM5SLmHEedSCExzKq1bGPyVaZAu+eyjb8qs
X-Received: by 2002:a05:6808:3a09:b0:3bc:29c3:6a47 with SMTP id
gr9-20020a0568083a0900b003bc29c36a47mr2513241oib.92.1704719574213;
Mon, 08 Jan 2024 05:12:54 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1704719574; cv=none;
d=google.com; s=arc-20160816;
b=diqXz/RuJJMtmXM3BWrhEbsuGmR7jR0QxZk2/tz9mOaS3MSXgHan+hJQJJ75nSSk/r
e0VlgNNLdT4YONfsaWGOHspV2EMdmZ3HdbSYwRozem41jl13Y3MLoYJCm1TNecw8YpVe
VcTQINysoLl9phCPxgYA2ckjZWBGqhGsJYKrdDwO5iI2aL9hpUsmMus8lumgLwBuVphx
tj1DBau3vgmnPSIrp5Cpow4OjQjIrV0+lsZhVxPkbaNuJTWkKvS7SpSKW30dKVmK35Ve
VavLzEmCwzlhhTMfpSytu7UB6zd5riv9Gvx/P4rrvHAl+Amve3fFuqNg54ELSAxlIAmi
IDZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from:dkim-signature;
bh=9fWlLW9JR4Djl8Tla7EpamvMDTw59uaIUP0UDK+OfAY=;
fh=thcStVYtLFTLPJaUqD9mE6cvhOHepq8jMpb8c6zfZrc=;
b=Bp5M7zPZrYZLBLHLIGE4Rpreivt+EAAchP9dF9cLTb2FI5NOd98r+KO2TMpz170QJD
yCxyH3HVh426ckRj6nYyUSmpEyLmxQ7gFIAcONFJ8MAuCN3Ci6GjOi3WR+r4N1lZ+Yhs
jZZYmN0Mt8lhLEJl37Q1e8zVerQsFUMM8/sRLAnM3VMZHSYVQpLi7zXJHyZsSJId9RIl
QObwLu0HD8MrJ88XleY5+hOaRjeT135M76Jb7Mg1VMG6ed2P11OKuf7+/kWhQquN2Xfd
ydxwaWr1cljbWzokzwOqBtRoMXRwuAOhp7/Yu+mavIZhITdIR39P7VAW1xg2qts+RzSe
QVzg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=eCJTWy3l;
spf=pass (google.com: domain of
linux-kernel+bounces-19596-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-19596-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org.
[2604:1380:45d1:ec00::1])
by mx.google.com with ESMTPS id
b22-20020a0cb3d6000000b0067f8c92249csi7901051qvf.78.2024.01.08.05.12.54
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 08 Jan 2024 05:12:54 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-19596-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=eCJTWy3l;
spf=pass (google.com: domain of
linux-kernel+bounces-19596-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-19596-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ny.mirrors.kernel.org (Postfix) with ESMTPS id 03DDF1C226EA
for <ouuuleilei@gmail.com>; Mon, 8 Jan 2024 13:12:54 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id C69A644C8F;
Mon, 8 Jan 2024 13:12:32 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="eCJTWy3l"
X-Original-To: linux-kernel@vger.kernel.org
Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com
[209.85.218.53])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89FFC4174D
for <linux-kernel@vger.kernel.org>; Mon, 8 Jan 2024 13:12:28 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Received: by mail-ej1-f53.google.com with SMTP id
a640c23a62f3a-a28f66dc7ffso487241266b.0
for <linux-kernel@vger.kernel.org>;
Mon, 08 Jan 2024 05:12:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1704719547; x=1705324347;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=9fWlLW9JR4Djl8Tla7EpamvMDTw59uaIUP0UDK+OfAY=;
b=eCJTWy3l4T+VpDQh9nIzNZVhKYvbebBIPa+KyADduj6COwMgEHici/YPWjCXuy0I+v
ox5K8vd7yuIOctrtJZEMFTTQZNb3Fyh8LHBQZhmI3VE7z5JnBmrxfVhoFRcywgC0MVwF
nVa/Q8fOXT/YD/z/JK52eV2ewYkWQ5LeE83032Kkqy80v6YyND15U4jc8X7+bhScSN+V
KoB7gGXFVP7mB7DxJ5OY4XvNHA+1fAKeAxmvZsMEwhnOMkZSmbhNpykqXMRE8RblMQTU
2EIhtNgFxsaojkLQ/bZVQM6vrIHIumZUgmw+22vAh0qDQESI291vf4YxjXCY3K5Nva+K
J7/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1704719547; x=1705324347;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=9fWlLW9JR4Djl8Tla7EpamvMDTw59uaIUP0UDK+OfAY=;
b=t1RsNnkxbO0I/X3h7oSgthis/1/6VIaAaP64kpwOTkUnZ5y9K6Js1+fbkU1XIaScMl
hEz4rEm/zan6hIXX204L0cFmUL5UO4AP1LtMvikBlyTN0NZMd/kVB6OLA0Qw8fIXaMSC
nQtcZbPZvN6S/TgwdQf4ajQ8+Cv8Sl3saslPZbjEhT3o+OfJyqp8fuvlqUb5JCb2bnvJ
310P0LonsEZmEBymxJJxvJBncOoyNfCUufTv+6a0ZLMQmHOYRCFHqXxes6Bq8bCd2yu6
WrvHBvJZqKGLh50egsD0C8kSivBH9EYHgPxJ2dzcYkYpnrSPn4AMFDDMUF8JyO4j2ykb
ZZ7Q==
X-Gm-Message-State: AOJu0YyIrmiMV4Lok8Sf/h61UpjFaAbCIYNkoCeVzZ31SyCd8c606Wc3
EretG52TjFMcp5CJD6P8lAyMTE+u9s7y8Q==
X-Received: by 2002:a17:906:28cf:b0:a26:db5e:1f2f with SMTP id
p15-20020a17090628cf00b00a26db5e1f2fmr5323983ejd.35.1704719546806;
Mon, 08 Jan 2024 05:12:26 -0800 (PST)
Received: from krzk-bin.. ([178.197.223.112])
by smtp.gmail.com with ESMTPSA id
w23-20020a1709062f9700b009fc576e26e6sm3902828eji.80.2024.01.08.05.12.25
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 08 Jan 2024 05:12:26 -0800 (PST)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
Date: Mon, 8 Jan 2024 14:12:15 +0100
Message-Id: <20240108131216.53867-1-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1787528032183640911
X-GMAIL-MSGID: 1787528032183640911
|
| Series |
[1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
|
|
Commit Message
Krzysztof Kozlowski
Jan. 8, 2024, 1:12 p.m. UTC
Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
name for the pin:
sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
Fixes: 4a657c264b78 ("arm64: dts: qcom: db845c: Enable PCIe controllers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 8.01.2024 14:12, Krzysztof Kozlowski wrote: > Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE > name for the pin: > > sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected) > > Fixes: 4a657c264b78 ("arm64: dts: qcom: db845c: Enable PCIe controllers") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Mon, 08 Jan 2024 14:12:15 +0100, Krzysztof Kozlowski wrote: > Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE > name for the pin: > > sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected) > > Applied, thanks! [1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios commit: 584a327c5cffc36369b2a8953d9448826240f1ac [2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios commit: 7c38989d0f7a35c83e7c4781271d42662903fa8d Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index ab6220456513..1f517328199b 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -580,7 +580,7 @@ &mss_pil { &pcie0 { status = "okay"; perst-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>; - enable-gpio = <&tlmm 134 GPIO_ACTIVE_HIGH>; + wake-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>; vddpe-3v3-supply = <&pcie0_3p3v_dual>;