diff mbox series

[v2,1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD DSI

Message ID 20240108095902.22725-2-quic_riteshk@quicinc.com
State New
Headers
Series Add support for Novatek NT36672E LCD DSI panel |

Commit Message

Ritesh Kumar Jan. 8, 2024, 9:59 a.m. UTC 
  Document Novatek NT36672E FHD+ LCD DSI panel.

Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>

---
v2: Fixed review comments from Krzysztof
      - renamed to novatek,nt36672e, since the binding is for the IC and
        not the panel.
      - moved additionalProperties after required.
---
 .../display/panel/novatek,nt36672e.yaml       | 66 +++++++++++++++++++
 1 file changed, 66 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml

Comments

Krzysztof Kozlowski Jan. 8, 2024, 10:07 a.m. UTC | #1 
On 08/01/2024 10:59, Ritesh Kumar wrote:
> Document Novatek NT36672E FHD+ LCD DSI panel.
> 
> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> 
> ---
> v2: Fixed review comments from Krzysztof

Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch` helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.

>       - renamed to novatek,nt36672e, since the binding is for the IC and
>         not the panel.
>       - moved additionalProperties after required.
> ---
>  .../display/panel/novatek,nt36672e.yaml       | 66 +++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> new file mode 100644
> index 000000000000..dc4672f3d01d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT36672E LCD DSI Panel
> +
> +maintainers:
> +  - Ritesh Kumar <quic_riteshk@quicinc.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: novatek,nt36672e
> +
> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  vddi-supply: true
> +  avdd-supply: true
> +  avee-supply: true

Are these names of pins? Somehow I have troubles believing that NT36672A
and NT36672E have entirely different names for these...


Best regards,
Krzysztof
Ritesh Kumar Jan. 9, 2024, 10:36 a.m. UTC | #2 
>-----Original Message-----
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Sent: Monday, January 8, 2024 3:38 PM
>To: Ritesh Kumar (QUIC) <quic_riteshk@quicinc.com>; dri-
>devel@lists.freedesktop.org; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Cc: neil.armstrong@linaro.org; Jessica Zhang (QUIC)
><quic_jesszhan@quicinc.com>; sam@ravnborg.org;
>maarten.lankhorst@linux.intel.com; mripard@kernel.org;
>tzimmermann@suse.de; airlied@gmail.com; daniel@ffwll.ch;
>robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>Abhinav Kumar (QUIC) <quic_abhinavk@quicinc.com>; Rajeev Nandan (QUIC)
><quic_rajeevny@quicinc.com>; Vishnuvardhan Prodduturi (QUIC)
><quic_vproddut@quicinc.com>; sumit.semwal@linaro.org
>Subject: Re: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD
>DSI
>
>On 08/01/2024 10:59, Ritesh Kumar wrote:
>> Document Novatek NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
>>
>> ---
>> v2: Fixed review comments from Krzysztof
>
>Please use standard email subjects, so with the PATCH keyword in the title. `git
>format-patch` helps here to create proper versioned patches.
>Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails
>more difficult thus making the review process less convenient.

I am using git format-patch only. I think the name of series is changed causing the trouble.

>
>>       - renamed to novatek,nt36672e, since the binding is for the IC and
>>         not the panel.
>>       - moved additionalProperties after required.
>> ---
>>  .../display/panel/novatek,nt36672e.yaml       | 66 +++++++++++++++++++
>>  1 file changed, 66 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
>>
>> diff --git
>>
>a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam
>> l
>>
>b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam
>> l
>> new file mode 100644
>> index 000000000000..dc4672f3d01d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e
>> +++ .yaml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id:
>> +http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Novatek NT36672E LCD DSI Panel
>> +
>> +maintainers:
>> +  - Ritesh Kumar <quic_riteshk@quicinc.com>
>> +
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: novatek,nt36672e
>> +
>> +  reg:
>> +    maxItems: 1
>> +    description: DSI virtual channel
>> +
>> +  vddi-supply: true
>> +  avdd-supply: true
>> +  avee-supply: true
>
>Are these names of pins? Somehow I have troubles believing that NT36672A
>and NT36672E have entirely different names for these...

Yes, these are name of pins.

Below is the Pin Description from NT36672E Datasheet:

vddi - Power supply to the I/O.
avdd - Positive input analog power for driver IC use.
avee - Negative input analog power for driver IC use.

I could not find datasheet of NT36672A online to compare  the names.

Thanks,
Ritesh
Krzysztof Kozlowski Jan. 9, 2024, 11:02 a.m. UTC | #3 
On 08/01/2024 11:07, Krzysztof Kozlowski wrote:
> On 08/01/2024 10:59, Ritesh Kumar wrote:
>> Document Novatek NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
>>
>> ---
>> v2: Fixed review comments from Krzysztof
> 
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch` helps here to create proper versioned patches.
> Another useful tool is b4. Skipping the PATCH keyword makes filtering of
> emails more difficult thus making the review process less convenient.

That was for the future (I understand making that mistake once with your
v1, but that's v2), no need to resend only for this.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
new file mode 100644
index 000000000000..dc4672f3d01d
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml
@@ -0,0 +1,66 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Novatek NT36672E LCD DSI Panel
+
+maintainers:
+  - Ritesh Kumar <quic_riteshk@quicinc.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: novatek,nt36672e
+
+  reg:
+    maxItems: 1
+    description: DSI virtual channel
+
+  vddi-supply: true
+  avdd-supply: true
+  avee-supply: true
+  port: true
+  reset-gpios: true
+  backlight: true
+
+required:
+  - compatible
+  - reg
+  - vddi-supply
+  - avdd-supply
+  - avee-supply
+  - reset-gpios
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "novatek,nt36672e";
+            reg = <0>;
+
+            reset-gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>;
+
+            vddi-supply = <&vreg_l8c_1p8>;
+            avdd-supply = <&disp_avdd>;
+            avee-supply = <&disp_avee>;
+
+            backlight = <&pwm_backlight>;
+
+            port {
+                panel0_in: endpoint {
+                    remote-endpoint = <&dsi0_out>;
+                };
+            };
+        };
+    };
+...