Message ID | 20240104130123.37115-8-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-16681-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5597509dyb; Thu, 4 Jan 2024 05:06:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFz2pzKaHs48kykdEqB4WIcBb1GPf8gHzjg6OHPAZthrlu0yfnriK3u4hiIi0SSUdugDQHh X-Received: by 2002:a05:6808:14c4:b0:3bb:eb58:85dd with SMTP id f4-20020a05680814c400b003bbeb5885ddmr580299oiw.0.1704373596996; Thu, 04 Jan 2024 05:06:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704373596; cv=none; d=google.com; s=arc-20160816; b=dfqdpXC/vao0ukUyjOAyPrUMc4fhL0cLDx1SbmeX0n00pDyw7BxoJKfjVfx9g7fahY YkZgbFfgoRQ5EVOjB9H8/ctib57a6KN2DtSOPe8+Q9RherTRWADX9wRXAAW3QEHIubM8 dNwbhZ30VA8zBa9PSDBxVMmz8ykc5p6B20uJSlsfK/M412bJKmbzu0yPA4VzJZOnsT2I rNhMNouRdzzW742PDbccmoQ0W0a9+BeYw2OGc+clv+5K87p7eqRp8mze9y7ifAncyBGB e4w9Kir8MCs8RDlOc7GLxaiXxLjuPWH9VgJxCaxrCiRCcFbMWdL0vQZZfOWrOYrOoutz Lm+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=tjubhM9aoU69uzCwJp4rB5H4DPxtKhGSNuyfkMH8Lnk=; fh=1uFngekeZT2FVGQaKpK4gjTIex4FU0hdfexTfOUKej8=; b=Q62qkPQKi6v3tXCjwd99DVEBegrTbE0rgjwwSnxfVNxQpLrDhOeUKYbre/IuoohOWV HDe82OqZXzZFBaj+Ahs1jh/Zc1TtRDIUdKiu3I/I03pdkQACf+nToQO+dRh0A0gD36WL ZaWZtYdP/L1fyYmYYMT7nzaBDJgl4v7wtFYPr5+EaJvesVg0WvryMLbWwr463yjhOQy+ xJJcv2xPLWXTiQVlZtIAQtKrKT30QhMGhWoeu0cdgZpcCpb+/bRCyueMRmj4VuZ7FOQR SrYZxahU/JNq7FQq45S+W2/EanZdNjrkFEFbV27Gga4zNKxH2HAIpjlvo89eVLTyJ4Vb u9mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=i1fH9UTd; spf=pass (google.com: domain of linux-kernel+bounces-16681-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16681-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id jl20-20020a056102195400b00466a0f3c16csi3263450vsb.750.2024.01.04.05.06.36 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:06:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16681-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=i1fH9UTd; spf=pass (google.com: domain of linux-kernel+bounces-16681-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16681-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BCD341C214A6 for <ouuuleilei@gmail.com>; Thu, 4 Jan 2024 13:06:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 766D928694; Thu, 4 Jan 2024 13:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="i1fH9UTd" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAAD424B22 for <linux-kernel@vger.kernel.org>; Thu, 4 Jan 2024 13:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-336897b6bd6so428046f8f.2 for <linux-kernel@vger.kernel.org>; Thu, 04 Jan 2024 05:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1704373333; x=1704978133; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tjubhM9aoU69uzCwJp4rB5H4DPxtKhGSNuyfkMH8Lnk=; b=i1fH9UTdejynp/wbaJS2KLYILgwYmbsa7NRCM3iJpWuOMnZncABvbv3F8YBK46xZZT U3X2und5/Gwz4PCDRlDiihQ02XgLZIjwU788KEs+dPPXeZdoM5MqPjP7D84AE/WKUtO0 c36CITX8IkPdkPrGMce7UzAg70milTpZEO6bLR4OMJjZojI81boIxrInBIPGMQ5jJKm1 02wHC70LNiJBZ7ULF2hz6U2Gq7ygHp1XXA8nzYeBcv6sNb9TZ83tU5zkXoKf0MWp5vCY aur/7ZeC7uQQ9I04WYr0ALo0sfnP0SQRkunCQLzJLW6/aT1G+NaxjS5Nr5g6e+YXPL9x VBdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704373333; x=1704978133; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tjubhM9aoU69uzCwJp4rB5H4DPxtKhGSNuyfkMH8Lnk=; b=oxf7vIMfvbtg60NTIVZH0Ww5EkhjQlqe9w/ByUNIxQEvn/BHSqATl5rfBUf77yaFMv 73Mx4pZj4qLcDKH5e/piRR+FWK6/07o3+9TbQnSbxDbZWNKsRPNqQBoAQAe2zl/TvY5Z oGWwW6xKo1NWwJIYPIhSbXY42+o/hKnTeSKzSXwOFG72/YOwqDlSMG9Xe5nQf5BfHZYQ T3/3ua0P0eSMQ6iwRuANZwPM8V/vZxyaogb/9gULKWN8AM7RUjmXD4JNf//CsTxUVyKk VDaehv/7VszdssUJGyk5c/SN4tBNlnGKmYyZcnJDA6pwpjS6SMXuFd9RSh8EjjGqkhss XIgA== X-Gm-Message-State: AOJu0YyfuixkQiBn2VAKLRos7SqtABrc6jNvY8TbXSu2Tqe+yG1Xzg7A ux+uJs2EQ7scPtLLJvwZPkJFvHSxVM4LZA== X-Received: by 2002:a5d:530b:0:b0:333:2e15:632c with SMTP id e11-20020a5d530b000000b003332e15632cmr447162wrv.10.1704373333369; Thu, 04 Jan 2024 05:02:13 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:5b69:3768:8459:8fee]) by smtp.gmail.com with ESMTPSA id w5-20020a5d5445000000b0033660f75d08sm32887387wrv.116.2024.01.04.05.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:02:13 -0800 (PST) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Kalle Valo <kvalo@kernel.org>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Heiko Stuebner <heiko@sntech.de>, Jernej Skrabec <jernej.skrabec@gmail.com>, Chris Morgan <macromorgan@hotmail.com>, Linus Walleij <linus.walleij@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Arnd Bergmann <arnd@arndb.de>, Neil Armstrong <neil.armstrong@linaro.org>, =?utf-8?q?N=C3=ADcolas_F_=2E_R_?= =?utf-8?q?=2E_A_=2E_Prado?= <nfraprado@collabora.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Peng Fan <peng.fan@nxp.com>, Robert Richter <rrichter@amd.com>, Dan Williams <dan.j.williams@intel.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Terry Bowman <terry.bowman@amd.com>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, Huacai Chen <chenhuacai@kernel.org>, Alex Elder <elder@linaro.org>, Srini Kandagatla <srinivas.kandagatla@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [RFC 7/9] dt-bindings: wireless: ath11k: describe QCA6390 Date: Thu, 4 Jan 2024 14:01:21 +0100 Message-Id: <20240104130123.37115-8-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240104130123.37115-1-brgl@bgdev.pl> References: <20240104130123.37115-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787165248688540658 X-GMAIL-MSGID: 1787165248688540658 |
Series |
PCI: introduce the concept of power sequencing of PCIe devices
|
|
Commit Message
Bartosz Golaszewski
Jan. 4, 2024, 1:01 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Describe the ath11k variant present on the QCA6390 module. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- .../bindings/net/wireless/qcom,ath11k-pci.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
Comments
On 04/01/2024 14:01, Bartosz Golaszewski wrote: > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > index 817f02a8b481..f584c25f4276 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > @@ -16,6 +16,7 @@ description: | > properties: > compatible: > enum: > + - pci17cb,1101 # QCA6390 > - pci17cb,1103 # WCN6855 > > reg: > @@ -27,6 +28,19 @@ properties: > string to uniquely identify variant of the calibration data for designs > with colliding bus and device ids > > + enable-gpios: > + description: GPIO line enabling the ATH11K module when asserted. > + maxItems: 1 > + > + vddpmu-supply: > + description: VDD_PMU supply regulator handle > + > + vddpcie1-supply: > + description: VDD_PCIE1 supply regulator handle > + > + vddpcie2-supply: > + description: VDD_PCIE2 supply regulator handle Looks like these are valid only for specific variant, so you should have allOf:if:then disallowing other properties when not applicable. The same applies for existing properties which might not exist on qca6390. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > On 04/01/2024 14:01, Bartosz Golaszewski wrote: > >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> index 817f02a8b481..f584c25f4276 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> @@ -16,6 +16,7 @@ description: | >> properties: >> compatible: >> enum: >> + - pci17cb,1101 # QCA6390 >> - pci17cb,1103 # WCN6855 >> >> reg: >> @@ -27,6 +28,19 @@ properties: >> string to uniquely identify variant of the calibration data for designs >> with colliding bus and device ids >> >> + enable-gpios: >> + description: GPIO line enabling the ATH11K module when asserted. >> + maxItems: 1 >> + >> + vddpmu-supply: >> + description: VDD_PMU supply regulator handle >> + >> + vddpcie1-supply: >> + description: VDD_PCIE1 supply regulator handle >> + >> + vddpcie2-supply: >> + description: VDD_PCIE2 supply regulator handle > > Looks like these are valid only for specific variant, so you should have > allOf:if:then disallowing other properties when not applicable. The same > applies for existing properties which might not exist on qca6390. And it would be good to provide more information in the commit log about the platforms where this is used, otherwise the context might not be clear. Or maybe document that in the bindings file, not sure.
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml index 817f02a8b481..f584c25f4276 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml @@ -16,6 +16,7 @@ description: | properties: compatible: enum: + - pci17cb,1101 # QCA6390 - pci17cb,1103 # WCN6855 reg: @@ -27,6 +28,19 @@ properties: string to uniquely identify variant of the calibration data for designs with colliding bus and device ids + enable-gpios: + description: GPIO line enabling the ATH11K module when asserted. + maxItems: 1 + + vddpmu-supply: + description: VDD_PMU supply regulator handle + + vddpcie1-supply: + description: VDD_PCIE1 supply regulator handle + + vddpcie2-supply: + description: VDD_PCIE2 supply regulator handle + required: - compatible - reg