[v3,2/2] hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems
Message ID | 20240104024819.848979-2-kai.heng.feng@canonical.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-16212-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5384606dyb; Wed, 3 Jan 2024 18:49:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBn2FX8OgKsfQmZRtf6exXOXLVPDJfXKKgHxZQVrde6ojhfNydwnpm7x6xDva2FvPMxrj6 X-Received: by 2002:a05:6358:d5aa:b0:175:64c5:a900 with SMTP id ms42-20020a056358d5aa00b0017564c5a900mr20639rwb.60.1704336568230; Wed, 03 Jan 2024 18:49:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704336568; cv=none; d=google.com; s=arc-20160816; b=NMEfsK3AuvW8gHltye2ZBdifX+fxIGYqD/e4NGiBtFmAdVCf4QWSoVn+fo/qwLkBSW yQRQeZ9ud1tiYoO7v9zLtno2xiw6RbKBfA0/uFYeMmQB/nBDBb7PNiSVL5F3qIdP6Q2P jvbIRGZeNrdo5kKi7U3GMX202jETUPrqGQm0Nu6IX/rgKP8qanhsMaXzh60lpIgQtTZE s5JK6zXGBwAY33Rsmo+4QcQ13viTjCoPPc0wZDrbxftIAXfyh0Hq/ziQVlZgsyu5d6C8 7sQVL5LK6biA8wC5sqs/ihDsejG4HptMvJwzbf3SdYdZuNvyahvbJ7MtwCrtlu5E+bz7 Nmug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HgPMGk6E0+2L7TIuVWwAqyxB34ASPMOpRfr0tWcLfRc=; fh=SzCKdFOxLTr6GR1lmw6aNzdbV1Tq9k5ZyfqOVVuDMX0=; b=XYVQF/tvt8PtNDPrfmJO1ojN+Ua7sj9lVIBYdPGhaUSW24cbX/3dIdqUDGqCb4NL7U rvgxXi7eb03hVA6AZgOVwlYLTkMyqD4/S+tjlRWAygDTKkRP4vugaa6x9ozT2YVDj9oL /+GPgLjKAGFvZzysbaO7wTXbfHfH9m8fNyuH2jGxn7ohQrovv09YABqIbctRVPZuTufz dqE1zfTVL1S+Bk6mzIuxmVIWhvu4SkJ5PFnSxR3tLJe0Lj4l2u4568oMdLbu0lNmOGLH L9AbGol5rdaiqXH+lfnQAF3UoI+G9S7EtcbZ/znmlUgF+K109vzvbqVqibymCCfPv9Tl 19cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=CDTDhbcb; spf=pass (google.com: domain of linux-kernel+bounces-16212-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16212-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b12-20020a63cf4c000000b005ceb4a70213si2431516pgj.385.2024.01.03.18.49.27 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 18:49:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16212-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=CDTDhbcb; spf=pass (google.com: domain of linux-kernel+bounces-16212-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16212-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9D0C5B20ED1 for <ouuuleilei@gmail.com>; Thu, 4 Jan 2024 02:49:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 35974134CD; Thu, 4 Jan 2024 02:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="CDTDhbcb" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E27291FC1; Thu, 4 Jan 2024 02:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Received: from HP-EliteBook-x360-830-G8-Notebook-PC.. (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 4BBEB42FC5; Thu, 4 Jan 2024 02:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1704336513; bh=HgPMGk6E0+2L7TIuVWwAqyxB34ASPMOpRfr0tWcLfRc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CDTDhbcb1Mf6ISsdvaCwiSEvK2Q+5bJga2YNlcvPxjjAOfYv78Pz1UBqlhvpmSYwB HTP6r4lWeLntfc+KI+pxMw+GDqvRFmsstw+893OKmFMdYFB+t2kxou4umKbIya77Z8 /9JqodztYRFDA7NFYooyUqPLXnFA6mCKolZjsVWIby0gb2CrXueGCdHTV61rARsZXx yGfrcumxcyo4scKLxDhJ8MR+OfSBEKoqMO5AJ0qwCdy2NTFbO3FnI86Q5Yhn7NLcxh PVGL1YwAKUtmZ80WJZZ5nPfRpIsqTjGpQH46dBK/aJ/VHN7iI6gmL0GnFKgiZauUDN Rp7W0tTK4qKeg== From: Kai-Heng Feng <kai.heng.feng@canonical.com> To: jdelvare@suse.com, linux@roeck-us.net Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems Date: Thu, 4 Jan 2024 10:48:19 +0800 Message-Id: <20240104024819.848979-2-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240104024819.848979-1-kai.heng.feng@canonical.com> References: <20240104024819.848979-1-kai.heng.feng@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787126421288189181 X-GMAIL-MSGID: 1787126421288189181 |
Series |
[v3,1/2] ACPI: IPMI: Add helper to wait for when SMI is selected
|
|
Commit Message
Kai-Heng Feng
Jan. 4, 2024, 2:48 a.m. UTC
The following error can be observed at boot:
[ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130)
[ 3.717928] ACPI Error: Region IPMI (ID=7) has no handler (20230628/exfldio-261)
[ 3.717936] No Local Variables are initialized for Method [_GHL]
[ 3.717938] No Arguments are initialized for method [_GHL]
[ 3.717940] ACPI Error: Aborting method \_SB.PMI0._GHL due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
[ 3.717949] ACPI Error: Aborting method \_SB.PMI0._PMC due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
[ 3.717957] ACPI: \_SB_.PMI0: _PMC evaluation failed: AE_NOT_EXIST
On Dell systems several methods of acpi_power_meter access variables in
IPMI region [0], so wait until IPMI space handler is installed by
acpi_ipmi and also wait until SMI is selected to make the space handler
fully functional.
[0] https://www.dell.com/support/manuals/en-us/redhat-enterprise-linux-v8.0/rhel8_rn_pub/advanced-configuration-and-power-interface-acpi-error-messages-displayed-in-dmesg?guid=guid-0d5ae482-1977-42cf-b417-3ed5c3f5ee62
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v3:
- Use helper.
- Use return value to print warning message.
v2:
- Use completion instead of request_module().
drivers/hwmon/acpi_power_meter.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
Hi Kai-Heng, kernel test robot noticed the following build errors: [auto build test ERROR on rafael-pm/linux-next] [also build test ERROR on groeck-staging/hwmon-next rafael-pm/acpi-bus rafael-pm/devprop linus/master v6.7-rc8 next-20240104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kai-Heng-Feng/hwmon-acpi_power_meter-Ensure-IPMI-space-handler-is-ready-on-Dell-systems/20240104-105227 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20240104024819.848979-2-kai.heng.feng%40canonical.com patch subject: [PATCH v3 2/2] hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems config: i386-randconfig-r133-20240104 (https://download.01.org/0day-ci/archive/20240105/202401051544.T4aBavV5-lkp@intel.com/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240105/202401051544.T4aBavV5-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401051544.T4aBavV5-lkp@intel.com/ All errors (new ones prefixed by >>): >> ld.lld: error: undefined symbol: acpi_wait_for_acpi_ipmi >>> referenced by acpi_power_meter.c:888 (drivers/hwmon/acpi_power_meter.c:888) >>> drivers/hwmon/acpi_power_meter.o:(acpi_power_meter_add) in archive vmlinux.a
diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c index 703666b95bf4..33fb9626633d 100644 --- a/drivers/hwmon/acpi_power_meter.c +++ b/drivers/hwmon/acpi_power_meter.c @@ -883,6 +883,12 @@ static int acpi_power_meter_add(struct acpi_device *device) strcpy(acpi_device_class(device), ACPI_POWER_METER_CLASS); device->driver_data = resource; + if (dmi_match(DMI_SYS_VENDOR, "Dell Inc.") && + acpi_dev_get_first_match_dev("IPI0001", NULL, -1)) { + if (acpi_wait_for_acpi_ipmi()) + dev_warn(&device->dev, "Waiting for ACPI IPMI timeout"); + } + res = read_capabilities(resource); if (res) goto exit_free;