From patchwork Wed Jan 3 08:45:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yan Zhao X-Patchwork-Id: 184670 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4911054dyb; Wed, 3 Jan 2024 01:15:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhHlkW3uJF/vKJne7c7ElrrbRYiM+19x7lojHPiClR1s3NW/XSRWTUMO5WOwLmz1Wofrie X-Received: by 2002:a17:906:c144:b0:a28:2c8d:5fd2 with SMTP id dp4-20020a170906c14400b00a282c8d5fd2mr1862220ejc.46.1704273356275; Wed, 03 Jan 2024 01:15:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704273356; cv=none; d=google.com; s=arc-20160816; b=u6UR8aWdG7f1NY0rLqcVa9ojxwVUgxc9d5fKjg+Fx0xO/+wm80S0+2F/k2RITWtSc9 Ugf9xKEqtwUQ/Ytxe15fcLYEw++JQmrep006WehRXmV7u0YjWu9wGpf8KxSdrONhHcx9 GVz5fRyLRzQ9ZN4ZyGFTP/GoqXztPTPS5nBZFE9fi0ELrZV142Ah8BLjFVbz7fKLSU5s VjfluiFLuQh7yWI7Ql1pXRKYyYnNZ1qyJf/5pg+GwGwKIB9LCpSOSsULG878ShKhDeuB 8nPoj4savYrnl4ADgF8T25H4yb5q/Ic8Iya8Vx3A3uPGexAFrYs8/WLypbCFJlr7N3XL OulA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=EH8hofSdKqG8a3qA5atY2RQ4G+xnIwPlyuok+fV/5U4=; fh=Vx93WHraSNwAtImeuZXYuwSlSJ9uZLtDICdtmXdGBhg=; b=zLQCblb9yTlRjRSmbliimd6P6TH6ilgJ+pTjn8Kr4YcsgI4lXOBDg5NgJS/jOCNLex ecvQf7bnkdazy12r8syOiFbwFdo/9a5sSdeL12ySYArXggBss98b3SJ7w3Jsfo5QyNob fR0/8kAvIn8nGU40z6Yld+iwnt4iLa9wQvE64dBA6BYPRx+tyo8i3nJoIj3RYpfAew0b ptewuRBPlhhmFRB8rrmCMohYpn88k0y1+OWzDdZXXmQvXGetV4jduMj8c6o7CKgB2bNu 760N9GTSBEmggSMy+30SZYXTvtfzB17D+/d+btHPHeeg/Vj5H1RZghTZ870aZIh8kSRi 3E1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d1r8NF7s; spf=pass (google.com: domain of linux-kernel+bounces-15315-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15315-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g8-20020a170906198800b00a280aead136si1993894ejd.1034.2024.01.03.01.15.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 01:15:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15315-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d1r8NF7s; spf=pass (google.com: domain of linux-kernel+bounces-15315-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15315-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2A6001F224B9 for ; Wed, 3 Jan 2024 09:15:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 84F6518C15; Wed, 3 Jan 2024 09:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d1r8NF7s" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B84118AEB; Wed, 3 Jan 2024 09:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704273293; x=1735809293; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=al72hcUGOzqysVVj35W64xRJAG42d0hvvgBN5GR17Eg=; b=d1r8NF7s5j+wiL3BkfSkZsk35UdEwINa8szuFoLLkP+PauUR3OUw5OIj HV44jFXblPfaj5EIvmfhBg+XdSPb7p4vDNJP1tiEer0lBSYOK3InKuO7Q qxqtxq/u9jDyKEFy+DCxhzFXuIU28HYGi1Y4Ha2B1lknH2WWoXuZcMnIW MeRsnxzUdXief5OYtr2oDWEv0DCxZO9ULnltJzOiksRG9jqCTWD9wRmpy l9DcoVT2ugkCnHvPfAMmAmeZjbOcazqLu9tWdbDtseufDjgVc2nVrAN7i MikExITjoCLFMYNG3FfSaF0RaOEIRAM2Wvwk/SWOQzWfGtZWFi0LuVcHa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="463386829" X-IronPort-AV: E=Sophos;i="6.04,327,1695711600"; d="scan'208";a="463386829" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2024 01:14:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="898812648" X-IronPort-AV: E=Sophos;i="6.04,327,1695711600"; d="scan'208";a="898812648" Received: from yzhao56-desk.sh.intel.com ([10.239.159.62]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2024 01:14:46 -0800 From: Yan Zhao To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: pbonzini@redhat.com, seanjc@google.com, shuah@kernel.org, stevensd@chromium.org, Yan Zhao Subject: [RFC PATCH v2 3/3] KVM: selftests: Add set_memory_region_io to test memslots for MMIO BARs Date: Wed, 3 Jan 2024 16:45:35 +0800 Message-Id: <20240103084535.20162-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240103084327.19955-1-yan.y.zhao@intel.com> References: <20240103084327.19955-1-yan.y.zhao@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787060138611309168 X-GMAIL-MSGID: 1787060138611309168 Added a selftest set_memory_region_io to test memslots for MMIO BARs. The MMIO BARs' backends are compound/non-compound huge pages serving as device resources allocated by a mock device driver. This selftest will assert and report "errno=14 - Bad address" in vcpu_run() if any failure is met to add such MMIO BAR memslots. After MMIO memslots removal, page reference counts of the device resources are also checked. As this selftest will interacts with a mock device "/dev/kvm_mock_device", it depends on test driver test_kvm_mock_device.ko in the kernel. CONFIG_TEST_KVM_MOCK_DEVICE=m must be enabled in the kernel. Currently, this selftest is only compiled for __x86_64__. Signed-off-by: Yan Zhao --- tools/testing/selftests/kvm/Makefile | 1 + .../selftests/kvm/set_memory_region_io.c | 188 ++++++++++++++++++ 2 files changed, 189 insertions(+) create mode 100644 tools/testing/selftests/kvm/set_memory_region_io.c diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile index 4412b42d95de..9d39514b6403 100644 --- a/tools/testing/selftests/kvm/Makefile +++ b/tools/testing/selftests/kvm/Makefile @@ -144,6 +144,7 @@ TEST_GEN_PROGS_x86_64 += memslot_modification_stress_test TEST_GEN_PROGS_x86_64 += memslot_perf_test TEST_GEN_PROGS_x86_64 += rseq_test TEST_GEN_PROGS_x86_64 += set_memory_region_test +TEST_GEN_PROGS_x86_64 += set_memory_region_io TEST_GEN_PROGS_x86_64 += steal_time TEST_GEN_PROGS_x86_64 += kvm_binary_stats_test TEST_GEN_PROGS_x86_64 += system_counter_offset_test diff --git a/tools/testing/selftests/kvm/set_memory_region_io.c b/tools/testing/selftests/kvm/set_memory_region_io.c new file mode 100644 index 000000000000..e221103091f4 --- /dev/null +++ b/tools/testing/selftests/kvm/set_memory_region_io.c @@ -0,0 +1,188 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE /* for program_invocation_short_name */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include +#include +#include + +#include <../../../../lib/test_kvm_mock_device_uapi.h> + +/* + * Somewhat arbitrary location and slot, intended to not overlap anything. + */ +#define MEM_REGION_GPA_BASE 0xc0000000 +#define RANDOM_OFFSET 0x1000 +#define MEM_REGION_GPA_RANDOM (MEM_REGION_GPA_BASE + RANDOM_OFFSET) +#define MEM_REGION_SLOT_ID 10 + +static const bool non_compound_supported; + +static const uint64_t BASE_VAL = 0x1111; +static const uint64_t RANDOM_VAL = 0x2222; + +static unsigned long bar_size; + +static sem_t vcpu_ready; + +static void guest_code_read_bar(void) +{ + uint64_t val; + + GUEST_SYNC(0); + + val = READ_ONCE(*((uint64_t *)MEM_REGION_GPA_RANDOM)); + GUEST_ASSERT_EQ(val, RANDOM_VAL); + + val = READ_ONCE(*((uint64_t *)MEM_REGION_GPA_BASE)); + GUEST_ASSERT_EQ(val, BASE_VAL); + + GUEST_DONE(); +} + +static void *vcpu_worker(void *data) +{ + struct kvm_vcpu *vcpu = data; + struct kvm_run *run = vcpu->run; + struct ucall uc; + uint64_t cmd; + + /* + * Loop until the guest is done. Re-enter the guest on all MMIO exits, + * which will occur if the guest attempts to access a memslot after it + * has been deleted or while it is being moved . + */ + while (1) { + vcpu_run(vcpu); + + if (run->exit_reason == KVM_EXIT_IO) { + cmd = get_ucall(vcpu, &uc); + if (cmd != UCALL_SYNC) + break; + + sem_post(&vcpu_ready); + continue; + } + + if (run->exit_reason != KVM_EXIT_MMIO) + break; + + TEST_ASSERT(!run->mmio.is_write, "Unexpected exit mmio write"); + TEST_ASSERT(run->mmio.len == 8, + "Unexpected exit mmio size = %u", run->mmio.len); + + TEST_ASSERT(run->mmio.phys_addr < MEM_REGION_GPA_BASE || + run->mmio.phys_addr >= MEM_REGION_GPA_BASE + bar_size, + "Unexpected exit mmio address = 0x%llx", + run->mmio.phys_addr); + } + + if (run->exit_reason == KVM_EXIT_IO && cmd == UCALL_ABORT) + REPORT_GUEST_ASSERT(uc); + + return NULL; +} + +static void wait_for_vcpu(void) +{ + struct timespec ts; + + TEST_ASSERT(!clock_gettime(CLOCK_REALTIME, &ts), + "clock_gettime() failed: %d\n", errno); + + ts.tv_sec += 2; + TEST_ASSERT(!sem_timedwait(&vcpu_ready, &ts), + "sem_timedwait() failed: %d\n", errno); + + /* Wait for the vCPU thread to reenter the guest. */ + usleep(100000); +} + +static void test_kvm_mock_device_bar(bool compound) +{ + struct kvm_vm *vm; + void *mem; + struct kvm_vcpu *vcpu; + pthread_t vcpu_thread; + int fd, ret; + u32 param_compound = compound; + u32 inequal = 0; + + fd = open("/dev/kvm_mock_device", O_RDWR); + if (fd < 0) { + pr_info("Please ensure \"CONFIG_TEST_KVM_MOCK_DEVICE=m\" is enabled in the kernel"); + pr_info(", and execute\n\"modprobe test_kvm_mock_device\n"); + } + TEST_ASSERT(fd >= 0, "Failed to open kvm mock device."); + + ret = ioctl(fd, KVM_MOCK_DEVICE_GET_BAR_SIZE, &bar_size); + TEST_ASSERT(ret == 0, "Failed to get bar size of kvm mock device"); + + ret = ioctl(fd, KVM_MOCK_DEVICE_PREPARE_RESOURCE, ¶m_compound); + TEST_ASSERT(ret == 0, "Failed to prepare resource of kvm mock device"); + + mem = mmap(NULL, (size_t)bar_size, PROT_READ | PROT_WRITE, MAP_SHARED, + fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "Failed to mmap() kvm mock device bar"); + + *(u64 *)mem = BASE_VAL; + *(u64 *)(mem + RANDOM_OFFSET) = RANDOM_VAL; + + vm = vm_create_with_one_vcpu(&vcpu, guest_code_read_bar); + + vm_set_user_memory_region(vm, MEM_REGION_SLOT_ID, 0, MEM_REGION_GPA_BASE, + bar_size, mem); + + virt_map(vm, MEM_REGION_GPA_BASE, MEM_REGION_GPA_BASE, + (RANDOM_OFFSET / getpagesize()) + 1); + + pthread_create(&vcpu_thread, NULL, vcpu_worker, vcpu); + + /* Ensure the guest thread is spun up. */ + wait_for_vcpu(); + + pthread_join(vcpu_thread, NULL); + + vm_set_user_memory_region(vm, MEM_REGION_SLOT_ID, 0, 0, 0, 0); + kvm_vm_free(vm); + + ret = ioctl(fd, KVM_MOCK_DEVICE_CHECK_BACKEND_REF, &inequal); + TEST_ASSERT(ret == 0 && inequal == 0, "Incorrect resource ref of KVM device"); + + munmap(mem, bar_size); + close(fd); +} + +static void test_non_compound_backend(void) +{ + pr_info("Testing non-compound huge page backend for mem slot\n"); + test_kvm_mock_device_bar(false); +} + +static void test_compound_backend(void) +{ + pr_info("Testing compound huge page backend for mem slot\n"); + test_kvm_mock_device_bar(true); +} + +int main(int argc, char *argv[]) +{ +#ifdef __x86_64__ + test_compound_backend(); + if (non_compound_supported) + test_non_compound_backend(); +#endif + + return 0; +}