[net-next,v3] net: kcm: fix direct access to bv_len

Message ID 20240102205959.794513-1-almasrymina@google.com
State New
Headers
Series [net-next,v3] net: kcm: fix direct access to bv_len |

Commit Message

Mina Almasry Jan. 2, 2024, 8:59 p.m. UTC
  Minor fix for kcm: code wanting to access the fields inside an skb
frag should use the skb_frag_*() helpers, instead of accessing the
fields directly.

Signed-off-by: Mina Almasry <almasrymina@google.com>

---
 net/kcm/kcmsock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 4, 2024, 3 a.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  2 Jan 2024 12:59:58 -0800 you wrote:
> Minor fix for kcm: code wanting to access the fields inside an skb
> frag should use the skb_frag_*() helpers, instead of accessing the
> fields directly.
> 
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> 
> 
> [...]

Here is the summary with links:
  - [net-next,v3] net: kcm: fix direct access to bv_len
    https://git.kernel.org/netdev/net-next/c/b15a4cfe100b

You are awesome, thank you!
  

Patch

diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
index 65d1f6755f98..1184d40167b8 100644
--- a/net/kcm/kcmsock.c
+++ b/net/kcm/kcmsock.c
@@ -634,7 +634,7 @@  static int kcm_write_msgs(struct kcm_sock *kcm)
 
 		msize = 0;
 		for (i = 0; i < skb_shinfo(skb)->nr_frags; i++)
-			msize += skb_shinfo(skb)->frags[i].bv_len;
+			msize += skb_frag_size(&skb_shinfo(skb)->frags[i]);
 
 		iov_iter_bvec(&msg.msg_iter, ITER_SOURCE,
 			      skb_shinfo(skb)->frags, skb_shinfo(skb)->nr_frags,