diff mbox series

[1/2] dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4

Message ID 20240102205941.29654-1-zajec5@gmail.com
State New
Headers
Series [1/2] dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4 |

Commit Message

Rafał Miłecki Jan. 2, 2024, 8:59 p.m. UTC 
  From: Rafał Miłecki <rafal@milecki.pl>

MT7988A is another MediaTek's SoC with just 1 device available right
now: Banana Pi BPI-R4.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Frank Wunderlich Jan. 3, 2024, 11:37 a.m. UTC | #1 
Hi

thanks Rafal for making the first loop of Dts-patches and splitting it and Angelo for first review.
Just my 2c on the thermal-part.

> Gesendet: Mittwoch, 03. Januar 2024 um 10:49 Uhr
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
>
> Il 02/01/24 21:59, Rafał Miłecki ha scritto:
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > MT7988A (AKA MediaTek Filogic 880) is a quad-core ARM Cortex-A73
> > platform designed for Wi-Fi 7 devices (there is no wireless on SoC
> > though). The first public MT7988A device is Banana Pi BPI-R4.
> > 
> > Many SoC parts remain to be added (they need their own bindings or
> > depend on missing clocks). Those present block however are correct and
> > having base .dtsi will help testing & working on missing stuff.
> > 
> > +	thermal-zones {
> > +		cpu-thermal {
> > +			polling-delay-passive = <1000>;
> > +			polling-delay = <1000>;
> > +
> 
> Those thermal zones will not work, as they have no thermal-sensors - as this
> node is right now, it will produce a probe error and nothing else: please
> either drop it entirely or add support for the thermal sensors (lvts or auxadc?)
> and fix this node to use them.

it is LVTS and i upstreamed dt-binding and driverchange already, but it also needs a (infracfg-)reset which
i try to upstream soon after infracfg clock driver appear in next (imho daniels patch merged in subsystem tree today).

so also the infracfg-node will be needed in next round, if thermal part should be part of it (else not much is in the dtsi at this time).

> > +			trips {
> > +				crit {
> > +					temperature = <125000>;
> > +					hysteresis = <2000>;
> > +					type = "critical";
> > +				};
> > +
> > +				hot {
> > +					temperature = <120000>;
> > +					hysteresis = <2000>;
> > +					type = "hot";
> > +				};
> > +
> > +				active-high {
> > +					temperature = <115000>;
> > +					hysteresis = <2000>;
> > +					type = "active";
> 
> Active cooling is board specific. Keep only critical/hot trips in the SoC DT.
> 
> > +				};
> > +
> > +				active-med {
> > +					temperature = <85000>;
> > +					hysteresis = <2000>;
> > +					type = "active";
> > +				};
> > +
> > +				active-low {
> > +					temperature = <40000>;
> > +					hysteresis = <2000>;
> > +					type = "active";
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupt-parent = <&gic>;
> > +		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> > +};
> 
> Regards,
> Angelo

@rafal how do we sync our work? what is your codebase?
i currently work on daniels wip tree, but it does not contain your current splitting...
maybe daniel can include your splitted dts patches?

i already tried to fix some binding-issues in the full dts(i)....
waiting for vendor about clocks for mmc which are currently not matching actual binding (and using mt7986 compatible).

regards Frank
Conor Dooley Jan. 8, 2024, 5:38 p.m. UTC | #2 
On Tue, Jan 02, 2024 at 09:59:40PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> MT7988A is another MediaTek's SoC with just 1 device available right
> now: Banana Pi BPI-R4.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Rafał Miłecki Jan. 9, 2024, 6:12 a.m. UTC | #3 
Hi Conor,

On 8.01.2024 18:38, Conor Dooley wrote:
> On Tue, Jan 02, 2024 at 09:59:40PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> MT7988A is another MediaTek's SoC with just 1 device available right
>> now: Banana Pi BPI-R4.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

I sent V2 meanwhile, could you reply to below PATCH instead, please?

[PATCH V2 1/3] dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4
Conor Dooley Jan. 9, 2024, 4:40 p.m. UTC | #4 
On Tue, Jan 09, 2024 at 07:12:35AM +0100, Rafał Miłecki wrote:
> Hi Conor,
> 
> On 8.01.2024 18:38, Conor Dooley wrote:
> > On Tue, Jan 02, 2024 at 09:59:40PM +0100, Rafał Miłecki wrote:
> > > From: Rafał Miłecki <rafal@milecki.pl>
> > > 
> > > MT7988A is another MediaTek's SoC with just 1 device available right
> > > now: Banana Pi BPI-R4.
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> I sent V2 meanwhile, could you reply to below PATCH instead, please?
> 
> [PATCH V2 1/3] dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4

In the future, just give me the message-id in these cases.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 6f2f64ae76fc..92dbfb862757 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -91,6 +91,10 @@  properties:
           - enum:
               - mediatek,mt7986b-rfb
           - const: mediatek,mt7986b
+      - items:
+          - enum:
+              - bananapi,bpi-r4
+          - const: mediatek,mt7988a
       - items:
           - enum:
               - mediatek,mt8127-moose