From patchwork Tue Jan 2 21:07:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 184458 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4685903dyb; Tue, 2 Jan 2024 13:12:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGbnezp8YxVZLAAB9Y75Knvl2Z2fLLxBPXbFwXNBeGis0LxO8R2KQQwapet9qf8yDdjkOo X-Received: by 2002:a17:90a:b38f:b0:280:cd7b:1fa5 with SMTP id e15-20020a17090ab38f00b00280cd7b1fa5mr6065648pjr.4.1704229972519; Tue, 02 Jan 2024 13:12:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704229972; cv=none; d=google.com; s=arc-20160816; b=BsyxnVtQe6gg20n5QmqQwvC+PqeUWGMOlQ6givKd1oPRFK12bh5VTGdfF/rJ8eawqI TxdEVnJJlD53vV1xVYXmUxXdudx6tY/mz7Zll7N86Y9JBiGmR/cMyDq3/ZYThtlZOCzI zDyi/EFFTNY9a7tlqpEl24iJBsVzVY8rs/Ax84wYGb0TKFmCjKTC+AmF6sxHzx+orBHQ I7KnGDrygG1D2v4L/T4zwm4uv5J26mg03Fg2szZe+AMQ0UNyYJOwnfOyHBit/LTL8WcS AjMaBRsWFgQhCyEJxw2248jZB3zbNGdF4UDR9o5isFFCx/FKffgZnciz8iRk2oNvydf1 DuUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LeATnxPiO37XaEtB4eQZXrEcgW0prfgDBCAc6VotlMc=; fh=1lZWIWcOZVFTUi4X75WIpUZJOALL5V9UacQsFr0aq2w=; b=aJ7M7TJwSK0PLnXOTkdWIz8Zn4sGlhQ04yGMLUMjqKc2JpgenJN2GeC4deShf7KoWx 4AnsIxDRBtYiwfAupNvBG9QidktnDqDjjKRzn3FD1Prm6OOh2EkeOs4m73GezNQsVmKL as5m7JEac9e2RZzBZ4fiSahrQ+1nDeCHNadM650F08miZ5p0XsjwtJgEug0t2TcSOhOA q5ViLlFmZZnAOqafQ6VjE3SA5bViCLraEt69oFlQdxqFLEiDebsT9D61W0PCHgrkb8Uq rHBs3GT8FBoenMXbIiRzZJky4G6dOz3P0HlI//+Q6IC7nw98BIm4TuFhTFdPFoVYEP6T OBAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PyeXmrBb; spf=pass (google.com: domain of linux-kernel+bounces-14833-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14833-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id a14-20020a17090a740e00b0028672a7b3casi78759pjg.29.2024.01.02.13.12.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:12:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14833-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PyeXmrBb; spf=pass (google.com: domain of linux-kernel+bounces-14833-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14833-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7CD63B224DB for ; Tue, 2 Jan 2024 21:11:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4517418AE4; Tue, 2 Jan 2024 21:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PyeXmrBb" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5F918023 for ; Tue, 2 Jan 2024 21:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7bb97d5ee3aso99555739f.2 for ; Tue, 02 Jan 2024 13:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704229731; x=1704834531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LeATnxPiO37XaEtB4eQZXrEcgW0prfgDBCAc6VotlMc=; b=PyeXmrBbvHD0JEpLy/toV24mUPQXkcKEsrP2CPsbMBEuvug9xWLv23V0nsM8kdoo+w WiNM0e8Bz8Vhbweqg+l3plE1Jsa2Bm2ria9NHeYlnAevYO58QE8mLuVCm0bs77KA8ZOq W+IkdzfVuDsf48UFKrOG1IaC5HM+92ztPIzww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704229731; x=1704834531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LeATnxPiO37XaEtB4eQZXrEcgW0prfgDBCAc6VotlMc=; b=mplvHwXNZuKG2lbWlcpskO3OLAatvlJ216qtmpV4w8labGd6akny+pL2lrjsfCz7gE 3rl4EWB+IHOM8/mzaCjZjlit2DD1DmuikDpSyp3N688yrYl53F3TjV13W+ZJLnq/C1gs AUMg1zLqeWeGLKsjog/vx1IDON+qWRuJEMad82yo1Xsr8mi+wK361tkvS1Ecye/izvgW t5ILpJOsgIEjdcLvTyTjzpzIXfm65TIsLKQzj7EHM0n6C6ac3kGKd5peBvapYpA/l3tF 2lzkQdGOnQpoy6lMk/+a0ACTfVJvn0dQ6PSbpxjvQiD4xGM1YNMjZat7TNgxVHMsqmn3 3gkQ== X-Gm-Message-State: AOJu0YznOc5wKeRyZaZbgzxLOVpEqpskrdJqxxprUle/KRmGjvMS2vog 0EytO5erh50nlAkOa3KEqqLAw945euj4FBoJa3JT4MEZD728 X-Received: by 2002:a6b:f008:0:b0:7b7:4c36:f295 with SMTP id w8-20020a6bf008000000b007b74c36f295mr20729710ioc.40.1704229731497; Tue, 02 Jan 2024 13:08:51 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id bo18-20020a056638439200b0046993034c91sm6956978jab.77.2024.01.02.13.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:08:51 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: Sudeep Holla , AngeloGioacchino Del Regno , Rob Herring , Andy Shevchenko , Krzysztof Kozlowski , Konrad Dybcio , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v4 09/24] arm64: dts: mediatek: mt8173: Enable cros-ec-spi as wake source Date: Tue, 2 Jan 2024 14:07:33 -0700 Message-ID: <20240102140734.v4.9.Ic09ebe116c18e83cc1161f4bb073fea8043f03f3@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240102210820.2604667-1-markhas@chromium.org> References: <20240102210820.2604667-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787014648082053245 X-GMAIL-MSGID: 1787014648082053245 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. Signed-off-by: Mark Hasemeyer Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v3) Changes in v3: -Update commit message to provide details of the motivation behind the change Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index 8d614ac2c58ed..335aed42dc9e3 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -1155,6 +1155,7 @@ cros_ec: ec@0 { spi-max-frequency = <12000000>; interrupts-extended = <&pio 0 IRQ_TYPE_LEVEL_LOW>; google,cros-ec-spi-msg-delay = <500>; + wakeup-source; i2c_tunnel: i2c-tunnel0 { compatible = "google,cros-ec-i2c-tunnel";