| Message ID | 20240102140734.v4.5.Ia598792a1386cca61844068be03c3ccec9e81753@changeid |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-14829-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id
tb2csp4685039dyb;
Tue, 2 Jan 2024 13:10:57 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IFa+6DwL9Xfqus00UZy+wjfs+vzZw+8blouJuOJ/8VWru1KViBZc5wrxDh9c+diviVIzKmr
X-Received: by 2002:a17:902:e88b:b0:1d4:40f3:7ab9 with SMTP id
w11-20020a170902e88b00b001d440f37ab9mr76776plg.40.1704229857712;
Tue, 02 Jan 2024 13:10:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1704229857; cv=none;
d=google.com; s=arc-20160816;
b=EyXwhHtZHH0blD3rJU1WRhTedmz+1wmrBfvd4WwqbhiEhKnqqdJ3jmPWRkg3mypdKI
PB7yh1G1EvqEy1vsG1gG4RBgqPasZFDf5Utsjx1SemG4udkUaZsFBmHvufi0Ag5ERbkh
67CHAaqYVeEthcB/lOUJzJOuEbTqHip5iu78vLvKgO1IGsZ6szLRQGbRujZm0zSQrcD/
RKrrw/HNoVb2KBAYKaqGzV4h6LkaJMcBddxQsL1N2d0UpXgLEp8c7LNMVqQyLfxYMMDc
99oZQkOalDgYRGtXRPouynJLOL80AcNvd/yltdAWqpVAJ2jQ0fFUGfcwVwOiHqTVrElB
g6zw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=ZjO95JnMkaDwwshxg++NkSMHj1Inq11nKJ2Uva51g+s=;
fh=LVtsc25IE6q50pmooCNXgsUBzrr0HFF18UNosnJde/A=;
b=BL1Ssnjmhm3MOOfKJEZPvUX2KyF7/0CJ6Der5pYALW/gXp6ud6NJJV97/eTT1N+qE+
iJ7RSvsHozSWg2Qig+GYYojt8LV/VtyCKMgmAf9Pq9JACt2wdBwZ6O7g92HyTQe6YPy0
0/2dvWc6eYmHGcJxG4OeqHpTd9484wD8rtmBuyE0BUVJzoAHz05rsb7pjXNJCjIOG2fL
b4Q32ytEth3wOHNG0/1IrwA8E6r13cQRBqc6aXOe3Md40gY9WPUlO6svTqlMADO5KzQu
BBo0X8tcodODCGj2b6LIiLtKhx+rVRDNnR8wunpIZqumk5iZOmzwgnUxrZjkg5pigmu9
bYSg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@chromium.org header.s=google header.b=TzvupCHx;
spf=pass (google.com: domain of
linux-kernel+bounces-14829-ouuuleilei=gmail.com@vger.kernel.org designates
139.178.88.99 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-14829-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99])
by mx.google.com with ESMTPS id
im22-20020a170902bb1600b001d2f6d7f080si20312630plb.12.2024.01.02.13.10.57
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 02 Jan 2024 13:10:57 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-14829-ouuuleilei=gmail.com@vger.kernel.org designates
139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Authentication-Results: mx.google.com;
dkim=pass header.i=@chromium.org header.s=google header.b=TzvupCHx;
spf=pass (google.com: domain of
linux-kernel+bounces-14829-ouuuleilei=gmail.com@vger.kernel.org designates
139.178.88.99 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-14829-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7D6822844F4
for <ouuuleilei@gmail.com>; Tue, 2 Jan 2024 21:10:57 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id E9D9E18039;
Tue, 2 Jan 2024 21:08:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org
header.b="TzvupCHx"
X-Original-To: linux-kernel@vger.kernel.org
Received: from mail-il1-f171.google.com (mail-il1-f171.google.com
[209.85.166.171])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AE7171BA
for <linux-kernel@vger.kernel.org>; Tue, 2 Jan 2024 21:08:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=chromium.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=chromium.org
Received: by mail-il1-f171.google.com with SMTP id
e9e14a558f8ab-35fe47edd2eso20695415ab.0
for <linux-kernel@vger.kernel.org>;
Tue, 02 Jan 2024 13:08:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google; t=1704229728; x=1704834528;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=ZjO95JnMkaDwwshxg++NkSMHj1Inq11nKJ2Uva51g+s=;
b=TzvupCHxAkkrsakCQUzqs0yVAGMgiH7X+OVX1f6xgCQZhuzy8vI+jmgglIB58+S9A8
KKgaCT7i8KW2AG098C8PjBrgHatDj9qcDiI1C38wY/xg2Wc+6TKcqQT0FrkM6Obe5veF
Is2QuhFPtC644eyxFHEh5OClumx/XWyBD638k=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1704229728; x=1704834528;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=ZjO95JnMkaDwwshxg++NkSMHj1Inq11nKJ2Uva51g+s=;
b=iIS1BmbUOy4Idy6bQPBIQZgl9VlZH4rheqKma8oBC8L9SxeEYy6PbhEsRtlWZ+xvAl
VZcEfpW31z/+tUXkDZxOFTArTfyH+zUttilYzwM+rUx1mLOPid9L+RXSRjzSAbiEMog/
23oPpNMbZvOwCnbwYnMsA+YRyZDr+cYxKetrHfNWzo/Y5NXdYbxfyitLpIikjLRNJCDI
AAk+KCJAh85ATviUZCB62XoLhdUfJXXnd4K8Ij3bVVxMmWmXH+j1VkO++ti70Y0Bg6F5
+i9WOWpC17zmFiIukZ15Udyt5OB3MXI91GQ7/zkHpYCwOvmURkKDyVHFC70ceFtBZPXZ
4eHQ==
X-Gm-Message-State: AOJu0Yzu63+46MEVkTAm1wf15HMDCKze3lOuLtyjCOM+qv2S0FrCAUm8
qtWyDjx+1A0ujUtS6uAC9wt7HkGipezI+n6kne5aJ/0pmGfh
X-Received: by 2002:a05:6e02:20ea:b0:360:142:3fec with SMTP id
q10-20020a056e0220ea00b0036001423fecmr44297ilv.6.1704229727943;
Tue, 02 Jan 2024 13:08:47 -0800 (PST)
Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136])
by smtp.gmail.com with ESMTPSA id
bo18-20020a056638439200b0046993034c91sm6956978jab.77.2024.01.02.13.08.47
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 02 Jan 2024 13:08:47 -0800 (PST)
From: Mark Hasemeyer <markhas@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Raul Rangel <rrangel@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Mark Hasemeyer <markhas@chromium.org>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Andre Przywara <andre.przywara@arm.com>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nick Hawkins <nick.hawkins@hpe.com>,
Paul Barker <paul.barker@sancloud.com>,
Rob Herring <robh+dt@kernel.org>,
Romain Perier <romain.perier@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Wei Xu <xuwei5@hisilicon.com>,
devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: [PATCH v4 05/24] ARM: dts: tegra: Enable cros-ec-spi as wake source
Date: Tue, 2 Jan 2024 14:07:29 -0700
Message-ID:
<20240102140734.v4.5.Ia598792a1386cca61844068be03c3ccec9e81753@changeid>
X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog
In-Reply-To: <20240102210820.2604667-1-markhas@chromium.org>
References: <20240102210820.2604667-1-markhas@chromium.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1787014527198335958
X-GMAIL-MSGID: 1787014527198335958
|
| Series |
Improve IRQ wake capability reporting and update the cros_ec driver to use it
|
|
Commit Message
Mark Hasemeyer
Jan. 2, 2024, 9:07 p.m. UTC
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v3)
Changes in v3:
-Update commit message to provide details of the motivation behind the
change
Changes in v2:
-Split by arch/soc
arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi | 1 +
arch/arm/boot/dts/nvidia/tegra124-venice2.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi b/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi index a2ee371802004..8125c1b3e8d79 100644 --- a/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi +++ b/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi @@ -338,6 +338,7 @@ cros_ec: cros-ec@0 { interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(C, 7) IRQ_TYPE_LEVEL_LOW>; reg = <0>; + wakeup-source; google,cros-ec-spi-msg-delay = <2000>; diff --git a/arch/arm/boot/dts/nvidia/tegra124-venice2.dts b/arch/arm/boot/dts/nvidia/tegra124-venice2.dts index 3924ee385dee0..df98dc2a67b85 100644 --- a/arch/arm/boot/dts/nvidia/tegra124-venice2.dts +++ b/arch/arm/boot/dts/nvidia/tegra124-venice2.dts @@ -857,6 +857,7 @@ cros_ec: cros-ec@0 { interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(C, 7) IRQ_TYPE_LEVEL_LOW>; reg = <0>; + wakeup-source; google,cros-ec-spi-msg-delay = <2000>;