From patchwork Tue Jan 2 21:07:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 184463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4686329dyb; Tue, 2 Jan 2024 13:13:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNe0ihN/8UyS/e1VDlE2qHdVWx7q4uMtBdOL4xC6ijvYwwiZ9FjRevIXgjERnf6k9uBEFa X-Received: by 2002:a05:6808:4447:b0:3bb:c8ed:57ce with SMTP id ep7-20020a056808444700b003bbc8ed57cemr15406887oib.79.1704230032935; Tue, 02 Jan 2024 13:13:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704230032; cv=none; d=google.com; s=arc-20160816; b=zvNgzxQTN+vIa7LYIdprJoN8cOkGcSSeBO8QhHdWA63pLX75P9O/6uFuqKaSW5/zYp W+tvj7S2LcDZd8rji/PaJqkm+JMy6YUMtMYQbkhUao0wPGrhG98K8g9ZifEIfg5O+yGl a8RFeITAhtOgBO3p4flQkKFMF91lMxsmK+msIjwZ4qBezF2ZaTIlcSY7zZcS3q+3FNy5 fr7liiF9G630qWOqSspiT5Zl5gU+6W2xb70wNqz1mrCn1rnHuSW6S2oJryUbXWzVIXCh 8HXpTdd9/Mm6bo9Gjf8ospfT2vjliEE24L8TSPgt2Hl8tdCL70J2jL0u1AJArNGTxamB VTJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YBXG8fkqI4E9TDywbJQDVQlGARTRe1Vl9dne1ILm/18=; fh=i9qMm7eTyXuYgN0CaK5GL2gmQ8m9aJzrDZ8hqikZ3oc=; b=eZB9cqs6ej6Lo4W5NLe5t7W8HKspJKxbO2cSDMP9jkMxJnTy2gabNZA5Lv6ox3/yhO AB29zOgMEBXHYy4b+POH9ernwzoBz9RFuW0ogrZ/ZAmjQP03CBFHIeJUxzktLPZhzkHZ BlIQHpxELVxpeCfnJU52EteE5TBbEFe+ABjNRrgo4RphIasT3v9HKAyHDLh9E8dy5HUQ S5BGF4IJ2dU+3s4JeqM2sY/EU+wP9+muOtTh2JOALPE7VqKGmWA8jzziwQju9FYvp0ap NF/C/JgduP7tbL8rMirALhOUeiTo9mtcsMAQXM/AlQTd9eJ28ydaj+QB7WriuSWvYrds 5KXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gPGOZCPV; spf=pass (google.com: domain of linux-kernel+bounces-14840-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14840-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id z15-20020a056214040f00b006805f4f3d15si15689007qvx.486.2024.01.02.13.13.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:13:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14840-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gPGOZCPV; spf=pass (google.com: domain of linux-kernel+bounces-14840-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14840-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B489B1C22928 for ; Tue, 2 Jan 2024 21:13:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EFA1E19461; Tue, 2 Jan 2024 21:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gPGOZCPV" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04052168B4 for ; Tue, 2 Jan 2024 21:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7ba834684abso506386539f.2 for ; Tue, 02 Jan 2024 13:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704229738; x=1704834538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YBXG8fkqI4E9TDywbJQDVQlGARTRe1Vl9dne1ILm/18=; b=gPGOZCPVl2IIrjDodIynds27pMs1g9tjyI6RUW8c4K5irQ1QWFY02ZdmSp9dw1xXuD lVXArgUDrQ1w0wwrIRF2JSKyrb2MoJmnK0jQdeXA9XfriG2gO5eaIKLgFI/l0UfGKoUS ImvMVxBWqgtbgpsE3ief97V6bU0JucG9PvaZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704229738; x=1704834538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YBXG8fkqI4E9TDywbJQDVQlGARTRe1Vl9dne1ILm/18=; b=wlRizZOXCADgVzTxXqZEzSDm7Z9PcSEN39XiRl/37+ctImEKlX5IVBqJVWmMan8YvY QRuTl1VALfQRgqDMMse3nGoHcC44LmaLTpEbfEBjdpcedVpN8uaqbA436mQNpvl6BQkJ 5uhAbahYQEFmyOl4jquZsMQ05RNw63x4rEM9gKgLylDxcX47ih7LiNFON7R0AqqLa1Qh tn24Teeosw5rwpS3CVanuY+FwVSvEBLS/tJcCEkB7X3FAu5Muo3ActKoVPFeSKr/lvl1 aGlzuedqh8E+g+gORTPveIEi2jfR6kalQfGukwRLiAYK7FetYgmKD3NP7TG5GN8uZzDv OqEg== X-Gm-Message-State: AOJu0YxCBMj/eBuIiC07OwodZoLD4fUlvtIKfIET8YRjw/2uxlMyL8+x nNZiAB30uNlBYMREOW6PTYGA59B6hI4AL2ZMTXhst1hKngwZ X-Received: by 2002:a5d:974b:0:b0:7b7:4b32:7986 with SMTP id c11-20020a5d974b000000b007b74b327986mr22772171ioo.27.1704229738043; Tue, 02 Jan 2024 13:08:58 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id bo18-20020a056638439200b0046993034c91sm6956978jab.77.2024.01.02.13.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:08:57 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: Sudeep Holla , AngeloGioacchino Del Regno , Rob Herring , Andy Shevchenko , Krzysztof Kozlowski , Konrad Dybcio , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Douglas Anderson , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Rob Herring , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 16/24] arm64: dts: qcom: sdm845: Enable cros-ec-spi as wake source Date: Tue, 2 Jan 2024 14:07:40 -0700 Message-ID: <20240102140734.v4.16.I870e2c3490e7fc27a8f6bc41dba23b3dfacd2d13@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240102210820.2604667-1-markhas@chromium.org> References: <20240102210820.2604667-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787014711115819269 X-GMAIL-MSGID: 1787014711115819269 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. Reviewed-by: Douglas Anderson Signed-off-by: Mark Hasemeyer --- Changes in v4: -Add Douglas's Reviewed-by tag from v2 review Changes in v3: -Update commit message to provide details of the motivation behind the change Changes in v2: -Split by arch/soc arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index 0ab5e8f53ac9f..e8276db9eabb2 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -852,6 +852,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&ec_ap_int_l>; spi-max-frequency = <3000000>; + wakeup-source; cros_ec_pwm: pwm { compatible = "google,cros-ec-pwm";