From patchwork Tue Jan 2 21:07:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 184460 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4685979dyb; Tue, 2 Jan 2024 13:13:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpEgAU4VUbjRjIyP/PiI/doGA52YKUBfj5+4uos9EQvYwwtBFm8D8lM/M2FSTmwCaheGVF X-Received: by 2002:a05:6358:282:b0:175:32a7:705 with SMTP id w2-20020a056358028200b0017532a70705mr2884311rwj.64.1704229984904; Tue, 02 Jan 2024 13:13:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704229984; cv=none; d=google.com; s=arc-20160816; b=iWLki27ThY3eAjWNKmexHn7QVEC14D8cMshL6ZDCgoxbSszYWz4M8PgbxSd4rVxGWw tLTXZxpH4hHeJH7m32csiSJiS3cIcB8xV/kniOYkN3wkC6xtHx/3amsWhYn+2Zm3Haow Or/8DGrXAXppoBnxpu1UuhVNho5fn3wUOE9JgMbA8UB8MEFD+AlNELO7McmpZ6Q2K+8y p6hECTW3w5od3ivcfsbZD2wp7PDQizizFWrKYM1y7a/86pg0ZJA3GHZpgNaIFHAyV3H7 +ZVbnpSYUXO0WsbriQSD4JfspUf1550A2mKFHpTMiDTlFn/MP5ucK5WF/AnPYBc8M+bb w01w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=n3q5bAzQikGEaFLCjfRt4Z8nKD+aA0c3SnrfHNcWXEY=; fh=1lZWIWcOZVFTUi4X75WIpUZJOALL5V9UacQsFr0aq2w=; b=K3x+KHjUYEUK4Sd1S07mYtcS9F6dsm6vvxob4EUrwXEWfNmqE0qmmJ0to9n7zT5LDK jrWzttxkTRmSqMzzvZiSO4wEcrUjI7Od19LeeJFI+pmUY/AEfZcjLG5fCtUfrY0uQ8Js EIPcPI7PwN/C0pcDrBmdpgfTnGybYl43Vno1F0aTE8mCzxIkrXUL22z2T7lwZqJbJHgK 003HzgLTWEv93blNJZZfYJZVmFNixOReobjwzcZ4ncmnAgQLM+TmhibcL33bLV43AkUw ebSB2Ugn/RZLir+JE06hvstb2s/z3Nq7AVG1lym2JVvqnyE7fUDkykHD8Hx3c1MJ/9MF WL3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JXIgDXon; spf=pass (google.com: domain of linux-kernel+bounces-14837-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14837-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id k15-20020a05622a03cf00b00427b2719319si23923201qtx.546.2024.01.02.13.13.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:13:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14837-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JXIgDXon; spf=pass (google.com: domain of linux-kernel+bounces-14837-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14837-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AE54F1C22B2B for ; Tue, 2 Jan 2024 21:13:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5058618E3A; Tue, 2 Jan 2024 21:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JXIgDXon" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5441818632 for ; Tue, 2 Jan 2024 21:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7bb5fda069bso168111439f.0 for ; Tue, 02 Jan 2024 13:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704229734; x=1704834534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n3q5bAzQikGEaFLCjfRt4Z8nKD+aA0c3SnrfHNcWXEY=; b=JXIgDXonyYNTm//xOUZbqvGEUrcO/uNkN4iZlt5SKgdAoy2vIhCqJ8k3ilv1Qyju9n sqEoOwLdDWLnZ5BHEI3SEUOUyYRBKWtMGCPbadhqosOiYy2D0oupIDf7vv0ygYDSO2F6 Z92VWWV+mmFZk/gLa7p6FtRIY8D2fo6aJ2Mm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704229734; x=1704834534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n3q5bAzQikGEaFLCjfRt4Z8nKD+aA0c3SnrfHNcWXEY=; b=AwCIba5QWgWYIF8Tga2Krr4zgfP7rJbM3Cx/IkvYT5kobZO1lmnin1WXWVlx1FvhiA e8T7zHK04Zs5D1mUDynQv4+MY6n/L6G5iafNH/JgKSolrtCCyYWnP+UpxvdDTeRnVslH bvLFIgMQbUphlhFGocgnnu93hnsX4sBBsxCWy3SaMiYV0YDOtD74qvgdXC7Tp8PkI3wV 37kbSFeW9R6h8hbSB/GaXd/ECsmnoaOJaEzuVPbmDfH4zC694BRRtP2GQOeaZrYPwGah mGPL7YY5BZyZrcikUgS7Mw8a/wfN/fSlKvdyET8l1Tpv4Ao4JGK+FSqUYbPuCN74Mudj pClA== X-Gm-Message-State: AOJu0YxtMrdJVMFjdPDUzHDs0GSRJny2jOZrpT+xmM8kLTNYlk9t5Vfe Fn7E9jDC8AI+i5p2PVoPHMtccWorIsbaC4kwUdRUZer8oHkK X-Received: by 2002:a6b:5905:0:b0:7bb:bca0:7670 with SMTP id n5-20020a6b5905000000b007bbbca07670mr1472284iob.23.1704229734077; Tue, 02 Jan 2024 13:08:54 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id bo18-20020a056638439200b0046993034c91sm6956978jab.77.2024.01.02.13.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:08:53 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: Sudeep Holla , AngeloGioacchino Del Regno , Rob Herring , Andy Shevchenko , Krzysztof Kozlowski , Konrad Dybcio , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v4 12/24] arm64: dts: mediatek: mt8195: Enable cros-ec-spi as wake source Date: Tue, 2 Jan 2024 14:07:36 -0700 Message-ID: <20240102140734.v4.12.Iee33a7f1f991408cef372744199026f936bf54e2@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240102210820.2604667-1-markhas@chromium.org> References: <20240102210820.2604667-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787014660685450105 X-GMAIL-MSGID: 1787014660685450105 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. Signed-off-by: Mark Hasemeyer Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v3) Changes in v3: -Update commit message to provide details of the motivation behind the change Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi index bbdcd441c049d..2edb270d0bc2f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi @@ -1149,6 +1149,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&cros_ec_int>; spi-max-frequency = <3000000>; + wakeup-source; keyboard-backlight { compatible = "google,cros-kbd-led-backlight";