From patchwork Tue Jan 2 21:07:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 184456 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4685583dyb; Tue, 2 Jan 2024 13:12:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeL9U3W+u2Ux23Hh33fNqevxiqMBGhXCm2sMwDWaWyUMghnbp+MSy5s0y8f4KTiEQeRcbL X-Received: by 2002:ae9:ea0b:0:b0:781:72ff:7d6c with SMTP id f11-20020ae9ea0b000000b0078172ff7d6cmr10866939qkg.82.1704229928507; Tue, 02 Jan 2024 13:12:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704229928; cv=none; d=google.com; s=arc-20160816; b=YfEoBHGT7INw1E0/cT9KJLFOF9vnYzwMo9HrYTso1ruHQQJS21dqVCywyyQ/tNDufe tifbgGCtbHsWJzEsolMtPxa/3o4FpaXYNdblFIIZwQWkuLU3bJTdEvVh9HfgyI5CsBe+ 215OVYX1dBgPkfJcAX7dfqkVAt7hz69Pwtg8N/69l9vjdJMmkaE43u/g6A6wUC0QWteU 9Tf+EUw+d5y1FFhnXP1kAW5ykU6bkbAwMh2rujFTJFNth9vVrB/Rw0wjM8ZBNOI4XF2F /xXP721cqT9R/c92SZrpIr2LZwxe2+XIi3s5lweCZksu/3Kkm6fYvqXKjvevcykyX3U0 0ZjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=5bEDuGxV/dPJIqZg1w0wl3qVgLyOuLBrt1YTH4lJcK4=; fh=1lZWIWcOZVFTUi4X75WIpUZJOALL5V9UacQsFr0aq2w=; b=EJF47KwiFdROiCkxDUQ77D+BOseMLfU3dZ6CULGPNK2bLXq+1WjhqIcUPwGzvKISBF O6olPEEKtRQwgta/H/Qs+0BNY+/WGAjZkUUeP34sJkxna5kDfLlYAIX8js+TtMUsb0bs Y+Ag+7iIMr1mu18ttZWkmOh04oCiEb8m4iESa6Um+uXBoKicQ5OxzB+4tmiVUo7MTXwz AOjk07gFz8AS1zrG2XkwmxCYfnQnjHjb5TqaRqZumtwieglaAGyVlgEk0J7J2YuNlqkk fxlP0eD3GGMJ8hDa8G3ctfyThTj9SzvjAe5eWEv6HM4TaL4nYiWdfShommETgqWhyMp8 PCIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OUJsj7U4; spf=pass (google.com: domain of linux-kernel+bounces-14834-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14834-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id s18-20020a05620a255200b007817232fbf1si12532252qko.161.2024.01.02.13.12.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:12:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14834-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OUJsj7U4; spf=pass (google.com: domain of linux-kernel+bounces-14834-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14834-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 512221C229D1 for ; Tue, 2 Jan 2024 21:12:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14F0B18AFB; Tue, 2 Jan 2024 21:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OUJsj7U4" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 261B718041 for ; Tue, 2 Jan 2024 21:08:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7b7fdde8b98so496499039f.1 for ; Tue, 02 Jan 2024 13:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704229732; x=1704834532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5bEDuGxV/dPJIqZg1w0wl3qVgLyOuLBrt1YTH4lJcK4=; b=OUJsj7U4B/Wkgmd/AEzsPthDKbgyGX+3iugDar/5gA7ccoYTJ6wxikYoAtPZTOREmK UJ2mnqV+1gAUnr0GnKfLOhhpqJ/7zGJiUupAXFKyjhdkm8b3y1gJCpMPYQiqaPPvfz6H patHhOOm4j4GiWVlxD8AODicg2PmeldUrdKfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704229732; x=1704834532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5bEDuGxV/dPJIqZg1w0wl3qVgLyOuLBrt1YTH4lJcK4=; b=qG56ww6gYtnYpyj0sYOoFsyGK0UPHdp0s1MeMToCl3ASB5m8xRY1t6yH1ifeAfte64 UZmnmEtmRwGJq0VvnKLIX+T4+c0YuXCRA3g3nqcYY41HEs7xKCdFcYqbLzq++k27OkCJ /9HEX8fcGNS+OLS2J00gQ1XEey4rAMXXWZ5clRoOuvHUQ0W5P1tWWTaNYmaSo+mcnDJu GfdWRzA2Fd8z+hIhqhHYeOSkeX7KxRT6XJHFWWFF90qUjFIKj6UR08XbuUn7/yfVXviU 5XVW2gul4diDgi/26VDWnb/Oq/rmLrtsT4FD49jsTDmDx+QTJK1pyyEvR5MczU2AahWt mesA== X-Gm-Message-State: AOJu0Yz1e9i+d4PAgECuTkzCeAuwGA3yfJmYx7yVHvVha+nh0wVJZhsd b8MsRtDM75q6M8nkanPS2ESm6OuTfvYTnFnTa5x3cUwy/nl3 X-Received: by 2002:a05:6602:147:b0:7bb:cd42:ed8e with SMTP id v7-20020a056602014700b007bbcd42ed8emr301320iot.28.1704229732361; Tue, 02 Jan 2024 13:08:52 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id bo18-20020a056638439200b0046993034c91sm6956978jab.77.2024.01.02.13.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:08:52 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: Sudeep Holla , AngeloGioacchino Del Regno , Rob Herring , Andy Shevchenko , Krzysztof Kozlowski , Konrad Dybcio , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v4 10/24] arm64: dts: mediatek: mt8183: Enable cros-ec-spi as wake source Date: Tue, 2 Jan 2024 14:07:34 -0700 Message-ID: <20240102140734.v4.10.Iba4a8b7e908989e57f7838a80013a4062be5e614@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240102210820.2604667-1-markhas@chromium.org> References: <20240102210820.2604667-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787014601890118155 X-GMAIL-MSGID: 1787014601890118155 The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. Signed-off-by: Mark Hasemeyer Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v3) Changes in v3: -Update commit message to provide details of the motivation behind the change Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index 5506de83f61d4..08261164ab18d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -924,6 +924,7 @@ cros_ec: cros-ec@0 { interrupts-extended = <&pio 151 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&ec_ap_int_odl>; + wakeup-source; i2c_tunnel: i2c-tunnel { compatible = "google,cros-ec-i2c-tunnel";