From patchwork Tue Jan 2 08:19:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 184281 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4327368dyb; Tue, 2 Jan 2024 00:21:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsipLubnNKgTpVjEBHXjDqXK6qIpOHtxj5mbIi81asV5Z+ZxLFqKZmtz3XNRl5QpRv4Bp+ X-Received: by 2002:a25:3615:0:b0:dbd:c1f1:4ff8 with SMTP id d21-20020a253615000000b00dbdc1f14ff8mr8481502yba.44.1704183660534; Tue, 02 Jan 2024 00:21:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704183660; cv=none; d=google.com; s=arc-20160816; b=ieNLUe2fcyI9/NTY1u6Vlbl5e0LlGQc5F6/ROm+AKL7WawrdBZ2kLf0s+2D9xAc9eG e5npZpuXlAodr84wLVwnJhqQY+JZty+nQFyTOoGqCSwwwjhXCTjmBkR+iiDB2TcrIuqE CgUnM3tBd8h0XxoELzrEHA4QQx+r74Mr4VG5FRt9hGmNZjNFh7A/aiQI/EUvKB0IM17l NYBjpM91QeeBNr1QJxHSAVykmZuKh1ZC0j/v6CmbW1pleWOKB+DlzHA0L0JpEwFi/pXN 3n/LuFUcOodwTrb6rJ+LOXoxyGhaYkFnqAa5m8V6zWPclrYmk8At8Io4ug160KF9rPTS 0Fpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=F7JhpyUgH4Jq+rXwdSiSSX32DA0GZkdALp7liQzCyVM=; fh=PjtJGS0Lh44DZXlD4hYX3auelta6gOdLfj1IGNALQSo=; b=1Ego+rzSKOJ+s9SP6c/ZWQpQJdUcvOrffZGVuqw4VbRMYXzMM22YHkZ7m8AuP+UDRF 3e7rkUwUQQJDwx/WbLCNrEX/3BENQvZdBZPjMRzLbFXGl285Y3QxvKEAY8589Lu/Nw/4 BEka+/qA9fHVB7i7QWKTqsxCGzjGFTKVXHhsZ8PzLkacPOMe2gEt7YPnMohvN0Bbj4+i /MPSp6cwd2INZXA007n9t852qGkAyrhfrOl8/appMLQ16UkYTTx1ElqnhTbwNe0pLCwe Tw1wk8UQucdyNPKaoMhSRmDNP5Efgb/5LWFZyX2XDU6T09/GAJisjytQxleNXc8Qq95Y 2qvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=DMTcUzvu; spf=pass (google.com: domain of linux-kernel+bounces-14140-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14140-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t17-20020a05622a01d100b0042812aa31a4si6230623qtw.431.2024.01.02.00.21.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 00:21:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14140-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=DMTcUzvu; spf=pass (google.com: domain of linux-kernel+bounces-14140-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14140-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5521E1C210FA for ; Tue, 2 Jan 2024 08:21:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25B925697; Tue, 2 Jan 2024 08:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DMTcUzvu" X-Original-To: linux-kernel@vger.kernel.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF2D46AB; Tue, 2 Jan 2024 08:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 8DD151BF20B; Tue, 2 Jan 2024 08:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1704183586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=F7JhpyUgH4Jq+rXwdSiSSX32DA0GZkdALp7liQzCyVM=; b=DMTcUzvuzO5wWZxzkxtkgpGfk4NtH/WHDgEF4W8hiKTuQ8I0j7k5PPvxXZ13G8VjZLPz0o Ti7lAEzLQHF9EC7A0fuU/8vIooDBwkmz8Ji1AAghDNuB0V0v/FxkVqjHc4ceIidkDFuhKu JSXbhy0n8VmhyZZhU0mWjJ/b2wZuaBXssd0i0NNjcNDMm1ChiA8l5MZoeQHOtZxel3E8p9 Q1V/pBtMbsOm7lo+xbY4VB7ZBhI0YpheVioufVRvMiHaY/2nj4eVOhVIUYIKzQUoef6GZn IZsDZ8fY2KKd/xWVqHKtiePtsJvmThdBDhIpdfHSAIPKbbS9Hde5h6nG3/7Utw== From: Luca Ceresoli To: Dmitry Torokhov , devicetree@vger.kernel.org Cc: Rob Herring , Jeff LaBundy , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Luca Ceresoli , Rob Herring Subject: [PATCH RESEND v2] dt-bindings: input: touchscreen: goodix: clarify irq-gpios misleading text Date: Tue, 2 Jan 2024 09:19:34 +0100 Message-Id: <20240102081934.11293-1-luca.ceresoli@bootlin.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: luca.ceresoli@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786966085671695242 X-GMAIL-MSGID: 1786966085671695242 The irq-gpios description misleading, apparently saying that driving the IRQ GPIO resets the device, which is even more puzzling as there is a reset GPIO as well. In reality the IRQ pin can be driven during the reset sequence to configure the client address, as it becomes clear after checking both the datasheet and the driver code. Improve the text to clarify that. Also rephrase to remove reference to the driver, which is not appropriate in the bindings. Signed-off-by: Luca Ceresoli Acked-by: Rob Herring Reviewed-by: Jeff LaBundy --- Changed in v2 resend: - added ack/review tags Changed in v2: - reworded to clarify even further --- .../devicetree/bindings/input/touchscreen/goodix.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml index 3d016b87c8df..2a2d86cfd104 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml @@ -37,8 +37,9 @@ properties: maxItems: 1 irq-gpios: - description: GPIO pin used for IRQ. The driver uses the interrupt gpio pin - as output to reset the device. + description: GPIO pin used for IRQ input. Additionally, this line is + sampled by the device on reset deassertion to select the I2C client + address, thus it can be driven by the host during the reset sequence. maxItems: 1 reset-gpios: