From patchwork Tue Jan 2 05:17:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 184223 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4277713dyb; Mon, 1 Jan 2024 21:19:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJVsG/ohCV034rAeXBiJQDA6JCq6YVWsiTTIBGFNjsv+uzRZyPfZQcB0uq+sdm6+DrQ2MG X-Received: by 2002:a05:6512:3da6:b0:50e:7bf2:6a with SMTP id k38-20020a0565123da600b0050e7bf2006amr6041516lfv.88.1704172767168; Mon, 01 Jan 2024 21:19:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704172767; cv=none; d=google.com; s=arc-20160816; b=RJebpCIsriZhS1rf+eSSQUt+vZfVIjUtYcf5brgIBNTpB5CPRNOyCTGd6VeQGUuukY kQui/nb//Itq1a5VzRNa85u1ikJbGFYXk+2M2W/tgiPwxB3XP3nseKaxeaU00crgfmWK 1Z/LtRT3s8DBXwWIX1T5ZBfz4VDOZHFixlbzss09Zpvg+JEVvQPv9lV6uNhBTxKKwSNu M7BQIveddO7SAmt45ddvnOlzIMFFWPDIyJzf9UCEHTayT5AaA8UFxqdZ1CCrEXvH96SW upjxUVFAp3deUHcFyVWNnFqrDx1XbWxrLqOwyIj9SDA/9KUWhh/dN4dbU17wkmjXeYOh DY6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=tZIXO/ThTrvB76uyhSz3UtK15rWrBmplBSszBbpfRMs=; fh=fZbhx+jMjuxUAdMPGC0uJttciTMYnDPW8yRPWNbzqRg=; b=p22RJC66BidfUq1OHQEnsf59k+avThVEpMoSk8L6OztdAmcPLJxX8skLxpdXSmpI3u v9SaKmnZMSVbsRChRwE1QNibC0ea6WU8UG0PqR7nJKlKGk4r7dbv8SRw9j28B1a2h1c0 GcFGs7xHi0pWHlFfOFTU3r5dKtXPk5tD1hONu3Z9oqqDk+GxDfYkpORcq5qw/LyyYuiN uvC4T9xtlSdUNfVfi6i4/VcBwkD2NSFLHT45Q3cNiTSGDUxHNY058DXWSWzZeVnlQQv4 8HjC0XlcYrMWrXtEe2+/0C4xb5Io5bsVupz1fJYyTzLZU34k/eua9oXycDcChynKyoJy xZxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D90ZaNUb; spf=pass (google.com: domain of linux-kernel+bounces-14031-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14031-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g21-20020a0564021ed500b005549748fea0si8299986edg.67.2024.01.01.21.19.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:19:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14031-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D90ZaNUb; spf=pass (google.com: domain of linux-kernel+bounces-14031-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14031-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C1CBA1F21A53 for ; Tue, 2 Jan 2024 05:19:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60257DDDD; Tue, 2 Jan 2024 05:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D90ZaNUb" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F8A10E1 for ; Tue, 2 Jan 2024 05:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-50e766937ddso7000883e87.3 for ; Mon, 01 Jan 2024 21:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704172650; x=1704777450; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tZIXO/ThTrvB76uyhSz3UtK15rWrBmplBSszBbpfRMs=; b=D90ZaNUbmhAHq/HjrwwK591ATA9FmB25H3ZmTC6dAXkKxS8xOck0nNvxI0mS9rfd/J 7ILd/RxyPpmGzPIugvqc6gaKHc4cxsTJ43XbP2m115KC0ylU9QxOQiYKgVwR3HA1on3z NEEP+yOXU2YDCo5v5XsWFqZTusATgJaW+gvaF2rSmSuz+t5/mhlGiCVM7NWFbKacxf2Z whmh9zQoOS+tMOxq7dn8b10/v2u+J+pbQosxgpRJRzdNte8MVjRz2XJWsGA3CqboQuZd S3dALDUuEoDNboMx7R2uHZo3lCZqa6mVhEO5all5xZKU4miYSXL/ZgP3dm4NC8DTF5kv opHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704172650; x=1704777450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tZIXO/ThTrvB76uyhSz3UtK15rWrBmplBSszBbpfRMs=; b=LbAMUygIW4Ra4BcuVmUvCnMcVYJuF4UhghVjfXEOoj6MorGN/xehlY6V7doy5NOS4U NRaEAA5Q5JSDvTY+Wd3QebvilacueK9N0c54NyTvOoCGTdFKATn5Af40jfaoLiJ8M7PG DuBApaJQW87LsEVw/ypNf94Pd3yfqS8UyDy/eQvvWgp5tS51EaiBGYiYOuATaGUVE4cl UJDibjoBEzYciIeKwQpc7uVHb+Uw3yhKMX4HQZSGs0RhNXqi/w50kOt5aT5qh+WXOm0d yJtTLJXSialX4Y23oTGDBZbTl3hFYYM0ykLUc/CGELWgzA1xI5kO6LIB6rMTQgVcwcm4 8OWw== X-Gm-Message-State: AOJu0Yyjejc3WReUGDUJyWDCCePdse+DX5TXkGvdvEij2phf0vAz21FZ VV3B/YsdQcYtOQbGlClbD1lpo9jQsrYHkA== X-Received: by 2002:a05:6512:3b9b:b0:50e:6cce:f83 with SMTP id g27-20020a0565123b9b00b0050e6cce0f83mr7619763lfv.41.1704172650431; Mon, 01 Jan 2024 21:17:30 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r25-20020ac252b9000000b0050e810689e5sm2081827lfm.33.2024.01.01.21.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:17:30 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 02 Jan 2024 07:17:24 +0200 Subject: [PATCH v7 04/22] soc: qcom: spm: remove driver-internal structures from the driver API Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240102-saw2-spm-regulator-v7-4-0472ec237f49@linaro.org> References: <20240102-saw2-spm-regulator-v7-0-0472ec237f49@linaro.org> In-Reply-To: <20240102-saw2-spm-regulator-v7-0-0472ec237f49@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andy Gross Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2084; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=a76V5wzOqJIYhtikxIwQ57SYROC70B96NpLt3fgYg9s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBlk5xj2RzTeDVozECsmG8KbA8MxS0mAvAVKiHEh 4EqNsWdxzuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZZOcYwAKCRCLPIo+Aiko 1ZCDB/0T9Peoq2h7K4WOwq12rDVuzylEyRDBne4dCSpTjGMmN/a6uceuLmBbVQtVcVqTyDbmuMf rxCM1GXE593Ko4pdkKKeZfkkI+v8dkzx/PgzhBAFUpiiVCFXgDwpk4LnZ0TvKGLPfMxUAq3GOAk srzRG8XDnI8ziexjn5ShHcIDrzu/O9XGISscywTxUTv9M+RrQjs6sk2o//eOiFzFW0IHb6h7N2f 7MvQGGBsMHasxFmzaYxVIGpHvXsrUkDln5+MMltdJGgU6Bfvs5/gvq7Bo1AKEoC313xg7i5Z6U+ w441LpduamdgVhq/nZ4W8GvgYCVLUO+N2tMlNsZrDc/90o/P X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786954663422853225 X-GMAIL-MSGID: 1786954663422853225 Move internal SPM driver structures to the driver itself, removing them from the public API. The CPUidle driver doesn't use them at all. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/spm.c | 20 ++++++++++++++++++++ include/soc/qcom/spm.h | 23 +---------------------- 2 files changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c index 2f0b1bfe7658..b15435f7cb0d 100644 --- a/drivers/soc/qcom/spm.c +++ b/drivers/soc/qcom/spm.c @@ -36,6 +36,26 @@ enum spm_reg { SPM_REG_NR, }; +#define MAX_PMIC_DATA 2 +#define MAX_SEQ_DATA 64 + +struct spm_reg_data { + const u16 *reg_offset; + u32 spm_cfg; + u32 spm_dly; + u32 pmic_dly; + u32 pmic_data[MAX_PMIC_DATA]; + u32 avs_ctl; + u32 avs_limit; + u8 seq[MAX_SEQ_DATA]; + u8 start_index[PM_SLEEP_MODE_NR]; +}; + +struct spm_driver_data { + void __iomem *reg_base; + const struct spm_reg_data *reg_data; +}; + static const u16 spm_reg_offset_v4_1[SPM_REG_NR] = { [SPM_REG_AVS_CTL] = 0x904, [SPM_REG_AVS_LIMIT] = 0x908, diff --git a/include/soc/qcom/spm.h b/include/soc/qcom/spm.h index 4951f9d8b0bd..5b263c685812 100644 --- a/include/soc/qcom/spm.h +++ b/include/soc/qcom/spm.h @@ -7,11 +7,6 @@ #ifndef __SPM_H__ #define __SPM_H__ -#include - -#define MAX_PMIC_DATA 2 -#define MAX_SEQ_DATA 64 - enum pm_sleep_mode { PM_SLEEP_MODE_STBY, PM_SLEEP_MODE_RET, @@ -20,23 +15,7 @@ enum pm_sleep_mode { PM_SLEEP_MODE_NR, }; -struct spm_reg_data { - const u16 *reg_offset; - u32 spm_cfg; - u32 spm_dly; - u32 pmic_dly; - u32 pmic_data[MAX_PMIC_DATA]; - u32 avs_ctl; - u32 avs_limit; - u8 seq[MAX_SEQ_DATA]; - u8 start_index[PM_SLEEP_MODE_NR]; -}; - -struct spm_driver_data { - void __iomem *reg_base; - const struct spm_reg_data *reg_data; -}; - +struct spm_driver_data; void spm_set_low_power_mode(struct spm_driver_data *drv, enum pm_sleep_mode mode);