diff mbox series

[v2,5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

Message ID 20240101161601.2232247-6-dario.binacchi@amarulasolutions.com
State New
Headers
Series Add display support for stm32f769-disco board |

Commit Message

Dario Binacchi Jan. 1, 2024, 4:15 p.m. UTC 
  The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
Novatek NT35510-based panel family.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

Changes in v2:
- Add a dash in front of each "items:"

 .../bindings/display/panel/novatek,nt35510.yaml        | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Linus Walleij Jan. 1, 2024, 8:47 p.m. UTC | #1 
On Mon, Jan 1, 2024 at 5:16 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:

> The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
> Novatek NT35510-based panel family.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Krzysztof Kozlowski Jan. 2, 2024, 9:10 p.m. UTC | #2 
On 01/01/2024 17:15, Dario Binacchi wrote:
> The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
> Novatek NT35510-based panel family.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> Changes in v2:
> - Add a dash in front of each "items:"
> 
>  .../bindings/display/panel/novatek,nt35510.yaml        | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> index bc92928c805b..8e69446e00e0 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> @@ -14,9 +14,13 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: hydis,hva40wv1
> -      - const: novatek,nt35510
> +    oneOf:
> +      - items:
> +          - const: hydis,hva40wv1
> +          - const: novatek,nt35510
> +      - items:
> +          - const: frida,frd400b25025
> +          - const: novatek,nt35510

If fallback compatibles are the same, just make  the first item as enum.
Less code.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index bc92928c805b..8e69446e00e0 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -14,9 +14,13 @@  allOf:
 
 properties:
   compatible:
-    items:
-      - const: hydis,hva40wv1
-      - const: novatek,nt35510
+    oneOf:
+      - items:
+          - const: hydis,hva40wv1
+          - const: novatek,nt35510
+      - items:
+          - const: frida,frd400b25025
+          - const: novatek,nt35510
     description: This indicates the panel manufacturer of the panel
       that is in turn using the NT35510 panel driver. The compatible
       string determines how the NT35510 panel driver shall be configured