From patchwork Sat Dec 30 04:51:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Rameshbabu X-Patchwork-Id: 183980 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2930584dyb; Fri, 29 Dec 2023 20:52:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/j0hVeuU2DWAvHe5zj7AfW3hy3bAC311zQR81A9GHSQmMc3LxhmgiXBPI0CZBizS1vhAn X-Received: by 2002:a50:8d15:0:b0:554:7470:2248 with SMTP id s21-20020a508d15000000b0055474702248mr5074884eds.41.1703911948125; Fri, 29 Dec 2023 20:52:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703911948; cv=none; d=google.com; s=arc-20160816; b=XdcLyzPeKGO3VwJZ5MyQrZp6hu8BiN60jfHAZgpTp8PAE9NeBEn4qEHxG3Ssv5K34q EC1n7N+KTf+SzxXPTUSMLdawAUnbcU7DUmwMwbDv8hZxih/TzQ+dBTHRc9hfZs95sHW4 FXW9LYiChnsSNCZSHjVGq1b3Td6QQyiqwPxo3v4hPRgisyZZqk/xgG43/RE1PrtyeO6N Gs3CfPGEHVgeTJIjYEboPzwp6hRen735F3EgW6kogJfAYsl0KXHy1RjVBGbMcCOWxtw9 gqeXsyMvLqv9tRwICn58nJhXMYGg1aZ0QTawTkXP0+G36/XKfuLCebl5wjrwv05Ldjr0 VYng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:feedback-id:references :in-reply-to:message-id:subject:cc:from:to:date:dkim-signature; bh=xoCJFTO9+CWfEwOaRvKJoarW9UkFuNSaR1ANZeDoB50=; fh=+21FHHkXcWPzhlDv3RJju/ybCufC5jSccWkxzweibX0=; b=pkUiEC65T1QDQom2JwvVk4FC0IBRVDsYT+lP/kfL5cXMiqPGrzWLSBy01VeJEnNefx C0M5tzqcxVfzNTyL8dVHNg4LCBxN7vZufo/WYvpZCZHEv38hYJOfbprSDTdzvI1w8PaM zRZ2XvsMss3CdBHTE1K6R8O7UWPxkFv2VVrnrxNHCvgBOyWZ1fiKNuK/lYamuwtyEg2z ck8mTQQ7AqVK4mSBkDv4AD2wev62Da8H9VckZM3m6b6BaBVGJ6HNJ37HYE9WrPxxMPtL 3vJKxtSSfuD2G0fEb9yztB2P1NGt3WtWfB7PuvvnCKI4JZ22Hi6Bd/8160xjSf3JZDT+ OoXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=HWYX2cNv; spf=pass (google.com: domain of linux-kernel+bounces-13329-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13329-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id if14-20020a0564025d8e00b00553be25f7c0si8665533edb.433.2023.12.29.20.52.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 20:52:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13329-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=HWYX2cNv; spf=pass (google.com: domain of linux-kernel+bounces-13329-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13329-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BD0141F22211 for ; Sat, 30 Dec 2023 04:52:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5618853B3; Sat, 30 Dec 2023 04:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="HWYX2cNv" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC7ED17E9 for ; Sat, 30 Dec 2023 04:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1703911897; x=1704171097; bh=xoCJFTO9+CWfEwOaRvKJoarW9UkFuNSaR1ANZeDoB50=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=HWYX2cNva/4uVA/Sq3t67Mr+1ucZcbP1jyUFutujNFLmLDrIwJT2Eva2facQaKkO8 Zt/wwOIBDBRl2YnGlzxsVw5doNVsiVtze8UMLovD9CmuWpZaOdma+rlOIj1sRsJAew IA3pppPW+KkFKr8KWpRVozgPABgmA3dvFurr0j0k5yo71MRSwyDkMKmxBzyYw/q1MX 6CJj7A7GwXKZQRYLOt2m2PcMclY3/2pXtWoSwUe39qvqjakGpzoV59D+NBTAg1EVRY OaoSD0BjGhPEvy/ksAa/blRxfUD/8qkgKmtH7t6sHNy4V8wyDEEo46rG+1XGr7zxkZ UH9QT5TREXPkg== Date: Sat, 30 Dec 2023 04:51:29 +0000 To: Kalle Valo From: Rahul Rameshbabu Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Rahul Rameshbabu Subject: [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional Message-ID: <20231230045105.91351-2-sergeantsagara@protonmail.com> In-Reply-To: <20231230045105.91351-1-sergeantsagara@protonmail.com> References: <20231230045105.91351-1-sergeantsagara@protonmail.com> Feedback-ID: 26003777:user:proton Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786681174636959843 X-GMAIL-MSGID: 1786681174636959843 Trigger the warning message should be when the OpenFW capability for QoS does not advertise QoS support. Previously, the warning would be incorrectly triggered when OpenFW reported QoS capability is present. Fixes: 097b0e1bf18a ("b43: fix crash with OpenFWWF") Signed-off-by: Rahul Rameshbabu --- drivers/net/wireless/broadcom/b43/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index 92ca0b2ca286..c81117a22ebf 100644 --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c @@ -2713,7 +2713,7 @@ static int b43_upload_microcode(struct b43_wldev *dev) dev->hwcrypto_enabled = false; } /* adding QoS support should use an offline discovery mechanism */ - WARN(fwcapa & B43_FWCAPA_QOS, "QoS in OpenFW not supported\n"); + WARN(!(fwcapa & B43_FWCAPA_QOS), "QoS in OpenFW not supported\n"); } else { b43info(dev->wl, "Loading firmware version %u.%u " "(20%.2i-%.2i-%.2i %.2i:%.2i:%.2i)\n",