From patchwork Fri Dec 29 14:52:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 183918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2615850dyb; Fri, 29 Dec 2023 06:53:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkKGBij2Csafz9mC/O/LV/FooqCRXraf94rsub7kUPgSTT/1QhoE1VAeLPI3vepAHgAbNo X-Received: by 2002:a50:9551:0:b0:54c:f1cd:1a9 with SMTP id v17-20020a509551000000b0054cf1cd01a9mr8499313eda.39.1703861585995; Fri, 29 Dec 2023 06:53:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703861585; cv=none; d=google.com; s=arc-20160816; b=Dx9qG6V6axlNDt63EKK938NEM8+0t1yTWTMNONmgDqoI7t0XG8rxGtlKUfpVYIVXaj zog77hh7aY//I2iznzt25+hHAJdmEuzb5rdamEJ7Fxg+ljAJCOZvcztCjIsWpC6drX0o 9GmMCxISAZw9kwNJOJ4sWwvzbvsP10JQl6ZKtig+SRSNuJhcvIsdRXgopxn8ntLSkyGY TuHNcYQuTq6qTUJFTXEQPHZO/ciwcjY0ylv4FKa2FCFgKaLIjOUTtv2bEqfEg670u/oT MBHVyvEm10/+2kRNqqy0NIQNrhZpk+NoZ8DhQy03Xrtkz2KX43OuhzZlZJ1JnTE1oD93 +2aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=FdMlMCPTuJFT7B6JHZUjdlkId28CisOqAc6ex3dEgCQ=; fh=8Hsg4RnjZOYcUEkqSpKUxazZINkWPwgC32C9BIBvHfU=; b=DWUZY5anf39idA6Vp0e2U712sysSNpTm6VUQBO8qYiq66uYWG9nuztEVbmWMd/6EJs WSHq365bhwX1JqfX6TeryVQtDAQdcF3vrAvPZjJ+rA750KyaSfKZpjceqhsoaEkcAG09 TutoIRst0sWuPAa7DFnGmqKkFQ19U3+2BE0RAKPfsHt4lPco8LfANgj8lWqL9P3/33pU A7IdewP4YHEhJ9Acsvs89NPA8A6oe1+k0/80gNn/9Bj2bc3Mi2yciknbc5fOqgzXfZFv 89gfq3Xl+DpJjqFE8qYFgVAokMDvaeXS7s6UjQVYOVj/Umkvysluf1a2ffhgLmI/o+8B p1rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Yv+1D9+x; spf=pass (google.com: domain of linux-kernel+bounces-13125-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13125-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u20-20020a50d514000000b00552a9b8bc25si8123698edi.568.2023.12.29.06.53.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 06:53:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13125-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Yv+1D9+x; spf=pass (google.com: domain of linux-kernel+bounces-13125-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13125-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8C8071F2293B for ; Fri, 29 Dec 2023 14:53:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7131811CBE; Fri, 29 Dec 2023 14:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Yv+1D9+x" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ED1C11C8B; Fri, 29 Dec 2023 14:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703861563; x=1735397563; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jcb3d1Eurdn7JoSDwWMgzToJsi8wV219/OcIstMM8H4=; b=Yv+1D9+xExQnxR2A9GjWlNjNuXDTyNyqfWzLSnXpUsZbQHqjx6STDj7g apjJpRzQCJPy/RY7cUvp9e6qej516P4nwh47rD6ZTovBDhcmgeW8Im+fD 1I9H5sppwU5nC8KinKGtrbHPwCP8d5diclmQJ4j6d78JUph3LnRYfJvBE WADnk7gNzVRgToQFuxrkXDvd8hAGlnxObbYzVC6Ak0gEpzisQzvYt6fTF V3B1HEw13lQMKc7e2L0lpCKcIzZfNSwEGDHH6fuKbCHfUWXW5oGYldwF/ xskcjIC1wkrT0pFKyTnd6TMUtmxO4GhV2zx5Fm+9vW0gEn1aIGj/QfDX2 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10938"; a="396379422" X-IronPort-AV: E=Sophos;i="6.04,315,1695711600"; d="scan'208";a="396379422" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2023 06:52:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,315,1695711600"; d="scan'208";a="20888995" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.48.133]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2023 06:52:39 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ray Jui , Scott Branden , Broadcom internal kernel review list , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 1/1] net: mdio: mux-bcm-iproc: Use alignment helpers and SZ_4K Date: Fri, 29 Dec 2023 16:52:32 +0200 Message-Id: <20231229145232.6163-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786628366612639131 X-GMAIL-MSGID: 1786628366612639131 Instead of open coding, use IS_ALIGNED() and ALIGN_DOWN() when dealing with alignment. Replace also literals with SZ_4K. Signed-off-by: Ilpo Järvinen Reviewed-by: Florian Fainelli Acked-by: Ray Jui --- drivers/net/mdio/mdio-mux-bcm-iproc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-bcm-iproc.c b/drivers/net/mdio/mdio-mux-bcm-iproc.c index a750bd4c77a0..1ce7d67ba72e 100644 --- a/drivers/net/mdio/mdio-mux-bcm-iproc.c +++ b/drivers/net/mdio/mdio-mux-bcm-iproc.c @@ -2,6 +2,7 @@ /* * Copyright 2016 Broadcom */ +#include #include #include #include @@ -11,6 +12,7 @@ #include #include #include +#include #define MDIO_RATE_ADJ_EXT_OFFSET 0x000 #define MDIO_RATE_ADJ_INT_OFFSET 0x004 @@ -220,12 +222,12 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev) md->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(md->base)) return PTR_ERR(md->base); - if (res->start & 0xfff) { + if (!IS_ALIGNED(res->start, SZ_4K)) { /* For backward compatibility in case the * base address is specified with an offset. */ dev_info(&pdev->dev, "fix base address in dt-blob\n"); - res->start &= ~0xfff; + res->start = ALIGN_DOWN(res->start, SZ_4K); res->end = res->start + MDIO_REG_ADDR_SPACE_SIZE - 1; }