From patchwork Fri Dec 29 09:24:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petre Rodan X-Patchwork-Id: 183881 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2466425dyb; Fri, 29 Dec 2023 01:27:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwTP8s3YHGJzd3AVT+B9jloxh7eqw3GrFoBIne+sy51riojEcbXaJFw3VIeA/fIq+QNpsI X-Received: by 2002:ae9:f40d:0:b0:781:5be4:b3fe with SMTP id y13-20020ae9f40d000000b007815be4b3femr5467613qkl.71.1703842048931; Fri, 29 Dec 2023 01:27:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703842048; cv=none; d=google.com; s=arc-20160816; b=yInbBOQphxj13jLx7WSoKZK19AkcypBy7/mFvD6p4EIzO6Tsvm8+xd/OW1K5Yc3LJB NVTDIx8w9fa7MdDqK3WzVP1iahFJnQz3KFXHth5UYT1Bch8x0SkYRo3Ip0NW2c9SU2rb qQgbS/7dg5Fdk58xAtjStiy0Opecp5Mpz9J5wG+VNWDIFmkf8hNIN2om2z4IoC5n6JDN sDcIZoOMtK1iPutUkyIlFkvaCiPSzYbEuxWIr3dMex59N4m//36th9AFHhwLfrB7Rh8/ eXrxeGcGw4ajAM/ntx1rcgwX8Sh2Cxh4+X8bVOSrze576EnKUOzpaORNfccubDTjDRSN O5bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8UnxNb10S0yXPkPLRZ/mgeEJI3f6GIksHWzAJ6/qZ3U=; fh=cuSrpdmFbNnIGKLvcD6905UtzyKVEbJe+tTFY3eiseU=; b=iBzNuYJ2B3KXmDE7Ra2OLvnFaW/D/14ir07X9Oy7Uqz/bTRsg1Y9CQ3C+hijjP+glv wWCOYypAN5RkCMGqvjIVUwyFAgMHvLvbKaaXhVi+SMVObG7Fyjd0qMBzE3Yhh1tVsJWh Z/VIDzktfmn7xOT/DZfuZ30ggItRRwHEuYgVOjasba8ABoxSW1Xtr8zuXdDH2e3ZAkJf ZPs22mmWcv19rp2qDBrBCZrBXVulQy2xGwKIjWsUMz9XIWxwxPvTPn3NiZ8UN+0Um+86 O4ugi6iUX/lizLMzQXDjHIDYrK8x6w5QuqE6oSAcnLDEWeuKz+EiW5JyiLETBphnJGV4 WylQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@subdimension.ro header.s=skycaves header.b=mIaJW9MP; spf=pass (google.com: domain of linux-kernel+bounces-13032-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13032-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=subdimension.ro Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b38-20020a05620a272600b0078162b73363si4960485qkp.15.2023.12.29.01.27.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 01:27:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13032-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@subdimension.ro header.s=skycaves header.b=mIaJW9MP; spf=pass (google.com: domain of linux-kernel+bounces-13032-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13032-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=subdimension.ro Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B6C6B1C2239A for ; Fri, 29 Dec 2023 09:27:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1CF21134A7; Fri, 29 Dec 2023 09:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=subdimension.ro header.i=@subdimension.ro header.b="mIaJW9MP" X-Original-To: linux-kernel@vger.kernel.org Received: from mail.subdimension.ro (skycaves.subdimension.ro [172.104.132.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD29611707; Fri, 29 Dec 2023 09:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=subdimension.ro Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=subdimension.ro Received: from localhost.localdomain (unknown [188.24.94.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.subdimension.ro (Postfix) with ESMTPSA id 581A028B587; Fri, 29 Dec 2023 09:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=subdimension.ro; s=skycaves; t=1703841907; bh=WDPOUW7eIikkHeG8X4wBbQ+EIdwGrEaQcqnAsLeHEGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mIaJW9MPIiNCMyBoEfJRjdEiuJ4AhJe0o9TNUvAraFysQ+wSv77fr7hU1NTmS6Usj 74htdF0yGWbcKsPFMKoGHbG0CFJBfYNxzwlRoR9wPSHYKAJUGpp2CV+M9wrI9UdFQ8 7u03koibqsE3BNczxn3udLHD5v1Ajp6dksPUKHwA= From: Petre Rodan To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Petre Rodan , Andreas Klinger , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Angel Iglesias , Matti Vaittinen Subject: [PATCH v3 05/10] iio: pressure: mprls0025pa improve driver error resilience Date: Fri, 29 Dec 2023 11:24:33 +0200 Message-ID: <20231229092445.30180-6-petre.rodan@subdimension.ro> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231229092445.30180-1-petre.rodan@subdimension.ro> References: <20231229092445.30180-1-petre.rodan@subdimension.ro> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786607880301098184 X-GMAIL-MSGID: 1786607880301098184 Improve driver error resilience by ignoring the measurement if any of the 3 error flags gets set while interacting with the sensor. Based on the datasheet, in table 14 on page 14, the status byte contains: bit 5 busy flag - 1 if device is busy bit 2 memory integrity/error flag - 1 if integrity test failed bit 0 math saturation - 1 if internal math saturation has occurred Co-developed-by: Andreas Klinger Signed-off-by: Andreas Klinger Signed-off-by: Petre Rodan --- v2 -> v3 no changes drivers/iio/pressure/mprls0025pa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.41.0 diff --git a/drivers/iio/pressure/mprls0025pa.c b/drivers/iio/pressure/mprls0025pa.c index e3f0de020a40..233cc1dc38ad 100644 --- a/drivers/iio/pressure/mprls0025pa.c +++ b/drivers/iio/pressure/mprls0025pa.c @@ -39,6 +39,8 @@ #define MPR_I2C_MEMORY BIT(2) /* integrity test passed */ #define MPR_I2C_MATH BIT(0) /* internal math saturation */ +#define MPR_I2C_ERR_FLAG (MPR_I2C_BUSY | MPR_I2C_MEMORY | MPR_I2C_MATH) + /* * support _RAW sysfs interface: * @@ -213,7 +215,7 @@ static int mpr_read_pressure(struct mpr_data *data, s32 *press) status); return status; } - if (!(status & MPR_I2C_BUSY)) + if (!(status & MPR_I2C_ERR_FLAG)) break; } if (i == nloops) { @@ -233,7 +235,7 @@ static int mpr_read_pressure(struct mpr_data *data, s32 *press) return -EIO; } - if (buf[0] & MPR_I2C_BUSY) { + if (buf[0] & MPR_I2C_ERR_FLAG) { /* * it should never be the case that status still indicates * business