From patchwork Fri Dec 29 09:24:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petre Rodan X-Patchwork-Id: 183878 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2466076dyb; Fri, 29 Dec 2023 01:26:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IE04rU3BYkveZjyBssNIHoC9hU7kvVK3Nju0FYWSTpMpGdrt3WbJy6bB5fUuY0PPkTFzge9 X-Received: by 2002:a05:6214:18d:b0:67f:de0c:1aa with SMTP id q13-20020a056214018d00b0067fde0c01aamr9954500qvr.123.1703841981364; Fri, 29 Dec 2023 01:26:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703841981; cv=none; d=google.com; s=arc-20160816; b=WuAZ1r+IM67VWryl5OEM0s02B48+LO/qAqdaS0Iw8m06I7tibDsUFiQ6g6ZuCdiMlJ zk8JoskGOX1c+eMnnvpAKuvtl72rEJrKIbbXEws1nldMkpPo2KqR9qcLsxtyX1Ap0ZaI FXsCYWJfY8s7rxDthVA/+e2OV4+nyudsw0TU1OA8itCidvqjVQhgAQ155G5A/9zCRVR9 8T8uXcwgbPPue/VU8mpVr7czOsJ1qlpccMF5hO1IMgW73IcGhm9AuAoixjdkmMkgfiEp C8l1eq6JvGWgZ91x/wXwRTTOqoomFfbDK1G2FqU7/eQxfuU1e2eFaXPF8wN//74rc2cF Z3gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=O63f8/hzdyKes3hDJBK2oZxWoRpxJhe44nO6oTdF5To=; fh=cuSrpdmFbNnIGKLvcD6905UtzyKVEbJe+tTFY3eiseU=; b=UhSHggFeJQXgH8WCyt073EPY9VGzXJom5DnE1Lgq+peEjt5lDoPLLVrDtYn2hutZ9C xX7vXdTVDgCR35VfS1PoX5G80+PjVa8iz9lwewZRNwmR26RwauUoZklanxnRuGGF8BHB Pk0tvmtgY7raKL0hBBKy5UDn0HJ40SnJXIf5apBOqGkM2r5TlG4Agj3mzzDBbKM0aiOC H9Ok+oixQjdenJL+X0LBF27Sw0TA7Bs+DxoL//Za/7MnprJs1qekI7+eR3PVAYNaZCfy QbTniFlY2Ic7fwEu7L1XvycbPEgGl1pVgoOru/CNg0DDTZZrztYqj3STMsTGigE9sAOM MAXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@subdimension.ro header.s=skycaves header.b=m68GZYKJ; spf=pass (google.com: domain of linux-kernel+bounces-13028-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13028-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=subdimension.ro Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id m18-20020a05622a055200b004254e0e7245si18842209qtx.540.2023.12.29.01.26.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 01:26:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13028-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@subdimension.ro header.s=skycaves header.b=m68GZYKJ; spf=pass (google.com: domain of linux-kernel+bounces-13028-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13028-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=subdimension.ro Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2C4441C22DE2 for ; Fri, 29 Dec 2023 09:26:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3CB8911CB6; Fri, 29 Dec 2023 09:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=subdimension.ro header.i=@subdimension.ro header.b="m68GZYKJ" X-Original-To: linux-kernel@vger.kernel.org Received: from mail.subdimension.ro (skycaves.subdimension.ro [172.104.132.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520C510A0A; Fri, 29 Dec 2023 09:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=subdimension.ro Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=subdimension.ro Received: from localhost.localdomain (unknown [188.24.94.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.subdimension.ro (Postfix) with ESMTPSA id 0286628B586; Fri, 29 Dec 2023 09:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=subdimension.ro; s=skycaves; t=1703841907; bh=tlhYys3P3yLGPXxjY35bhZAwm+PVbm6Qq70uWBAQSm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m68GZYKJYu9MVhSNNAhugzNP9Hjh9U5xoPyi8ZIdCy19klvpOuB3MGfceyHvae5HW YoQcUZMH9ESCm93nkGIh9jPTzbonbnlw8HtYFYLBrrSncnm8T/FsYacqwY8hyu99vJ gXjOwsgFOChM9ADJp8t5RVqynNHf45lVMJolEtSg= From: Petre Rodan To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Petre Rodan , Andreas Klinger , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Angel Iglesias , Matti Vaittinen Subject: [PATCH v3 04/10] iio: pressure: mprls0025pa fix off-by-one enum Date: Fri, 29 Dec 2023 11:24:32 +0200 Message-ID: <20231229092445.30180-5-petre.rodan@subdimension.ro> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231229092445.30180-1-petre.rodan@subdimension.ro> References: <20231229092445.30180-1-petre.rodan@subdimension.ro> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786607809101577511 X-GMAIL-MSGID: 1786607809101577511 Fix off-by-one error in transfer-function property. The honeywell,transfer-function property takes values between 1-3 so make sure the proper enum gets used. Fixes: <713337d9143ed> ("iio: pressure: Honeywell mprls0025pa pressure sensor") Co-developed-by: Andreas Klinger Signed-off-by: Andreas Klinger Signed-off-by: Petre Rodan --- v2 -> v3 no changes drivers/iio/pressure/mprls0025pa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.41.0 diff --git a/drivers/iio/pressure/mprls0025pa.c b/drivers/iio/pressure/mprls0025pa.c index 30fb2de36821..e3f0de020a40 100644 --- a/drivers/iio/pressure/mprls0025pa.c +++ b/drivers/iio/pressure/mprls0025pa.c @@ -323,6 +323,7 @@ static int mpr_probe(struct i2c_client *client) struct iio_dev *indio_dev; struct device *dev = &client->dev; s64 scale, offset; + u32 func; if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_READ_BYTE)) return dev_err_probe(dev, -EOPNOTSUPP, @@ -362,10 +363,11 @@ static int mpr_probe(struct i2c_client *client) return dev_err_probe(dev, ret, "honeywell,pmax-pascal could not be read\n"); ret = device_property_read_u32(dev, - "honeywell,transfer-function", &data->function); + "honeywell,transfer-function", &func); if (ret) return dev_err_probe(dev, ret, "honeywell,transfer-function could not be read\n"); + data->function = func - 1; if (data->function > MPR_FUNCTION_C) return dev_err_probe(dev, -EINVAL, "honeywell,transfer-function %d invalid\n",