Message ID | 20231229020808.55840-1-jiapeng.chong@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-12909-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2337716dyb; Thu, 28 Dec 2023 18:08:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2ICaPW52Ht8i0j4Z8a+mBlC0krIaL1dKGOhnJjTvZ5Vlb2Mn4rcXl0rd5+IFEPJCN5K+k X-Received: by 2002:a17:902:7ed0:b0:1d4:8278:462e with SMTP id p16-20020a1709027ed000b001d48278462emr2796431plb.116.1703815726070; Thu, 28 Dec 2023 18:08:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703815726; cv=none; d=google.com; s=arc-20160816; b=vebEYMSDUT5qBFJ1gLCp4q2EjalQ8vO9QE9vlfna03cW9/YOxEWE2/APhOLu6lX8lp gpjou2m211zcKFxXATXKYCr+bf3WSHN2WMG9YWvL41VKl1keyPoj3wrDR6byZ6WbFWAh Lavsk2FpqBaf99IzUrhAh+3wB2cqtWyBVjALRdqjt6B64Avsb2/pQjXbSaiQQls9Qdo4 Jw6HqixjaUMQhTZ2wxG5x2uhw0p+LdNYSZ0F2NnQnEVIlHY0hJa6iO9I1sL5SUzte0qD i6xPRNMJyVQWQtdNEq4L1Latj7Nw/81Rin73Zjo0cdR7ulauoqvtaFD14tfTjBSLHvYT SlGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=quvKFl2umLwavKH/8cPxmUdEbN4oEC0NlC7yH68oWH4=; fh=Hu4BrfNRet+vIbfL9dAhxa55xEllnQN7V/PsanxCcGE=; b=lGXxq5sIoDrtc6Gr9b/BJVk7n2Y5wI0FGwTPn/7cNORndJnh1ALOwKfHGrThZkQf2r 9UKmL+KnjwLY9bf4CsNagbaJKzpO/MkBD6Rpi9BHOpzxNtHrXoNdjcJ6KZF35/QTaOkO ejZp36+uuKRrwrtU0WSrZ3OjfNAbBSBbCcsLLJFPq4+rFEcArSOzN467u/0G+94ejm+U ELotjgWM7xYYpp/J55GAkSi+72ln8QOSW6gUDj5F5QOVhditdX6hGeVhchKKMG+9V3/u lLECal9sq5zv7j6p4mbGlJAeZiA3UqtLmwtvsAEtvQoy7nvFytz6zL8Q94zfCjQkbAeU 3c9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12909-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12909-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g6-20020a170902740600b001d3dbb38f80si10342178pll.340.2023.12.28.18.08.45 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 18:08:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12909-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12909-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12909-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D60E52860E6 for <ouuuleilei@gmail.com>; Fri, 29 Dec 2023 02:08:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 54D1C1FD3; Fri, 29 Dec 2023 02:08:32 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF32137F; Fri, 29 Dec 2023 02:08:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R271e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VzPxWSp_1703815688; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VzPxWSp_1703815688) by smtp.aliyun-inc.com; Fri, 29 Dec 2023 10:08:19 +0800 From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> To: irenic.rajneesh@gmail.com Cc: david.e.box@intel.com, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, Abaci Robot <abaci@linux.alibaba.com> Subject: [PATCH] platform/x86/intel/pmc: make lnl_d3_fixup static Date: Fri, 29 Dec 2023 10:08:08 +0800 Message-Id: <20231229020808.55840-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786580278690157988 X-GMAIL-MSGID: 1786580278690157988 |
Series |
platform/x86/intel/pmc: make lnl_d3_fixup static
|
|
Commit Message
Jiapeng Chong
Dec. 29, 2023, 2:08 a.m. UTC
The lnl_d3_fixup are not used outside the file lnl.c, so the
modification is defined as static.
drivers/platform/x86/intel/pmc/lnl.c:503:6: warning: no previous prototype for ‘lnl_d3_fixup’.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7811
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/platform/x86/intel/pmc/lnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Jiapeng, On 12/29/23 03:08, Jiapeng Chong wrote: > The lnl_d3_fixup are not used outside the file lnl.c, so the > modification is defined as static. > > drivers/platform/x86/intel/pmc/lnl.c:503:6: warning: no previous prototype for ‘lnl_d3_fixup’. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7811 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Thank you for your patch, but this has already been fixed in the current version of the code, see: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/tree/?h=for-next Regards, Hans > --- > drivers/platform/x86/intel/pmc/lnl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c > index 88b35931f5df..f18fdc68fd94 100644 > --- a/drivers/platform/x86/intel/pmc/lnl.c > +++ b/drivers/platform/x86/intel/pmc/lnl.c > @@ -500,7 +500,7 @@ const struct pmc_reg_map lnl_socm_reg_map = { > * Set power state of select devices that do not have drivers to D3 > * so that they do not block Package C entry. > */ > -void lnl_d3_fixup(void) > +static void lnl_d3_fixup(void) > { > pmc_core_set_device_d3(LNL_IPU_PCI_DEV); > pmc_core_set_device_d3(LNL_NPU_PCI_DEV);
diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c index 88b35931f5df..f18fdc68fd94 100644 --- a/drivers/platform/x86/intel/pmc/lnl.c +++ b/drivers/platform/x86/intel/pmc/lnl.c @@ -500,7 +500,7 @@ const struct pmc_reg_map lnl_socm_reg_map = { * Set power state of select devices that do not have drivers to D3 * so that they do not block Package C entry. */ -void lnl_d3_fixup(void) +static void lnl_d3_fixup(void) { pmc_core_set_device_d3(LNL_IPU_PCI_DEV); pmc_core_set_device_d3(LNL_NPU_PCI_DEV);