From patchwork Thu Dec 28 15:30:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Shenghao" X-Patchwork-Id: 183772 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2063632dyb; Thu, 28 Dec 2023 07:32:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUS881vnX5f9PKTtmLrSzayCsdrDy7yukbxTZJDypgqm2Yycj+wevTr4zEBoLdcDSg/Eei X-Received: by 2002:a05:6102:4b14:b0:467:938:6be3 with SMTP id ia20-20020a0561024b1400b0046709386be3mr2348604vsb.4.1703777566510; Thu, 28 Dec 2023 07:32:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703777566; cv=none; d=google.com; s=arc-20160816; b=BCtpv0UVz1p3W9iYm0QhgtSA1/xhgd42UAf5+1y+2dcxrlB48rUrfsAA43NLqgC0ql CbeCqwxNW79maj7VeTXGVU5pJYTo2pKv4pOC0A6AoscvX48EC1NY+BLTGHG86yoTIOkl FSoYVyR7Yd22u8Tg6cuylWiAaEMMn/MI4+enQhwe4/QQHXsYr6vwKB/pLB1Ym08Lstfo eDOHmVok/zZpZh6OwdMrBc9xC2xo09itKpWJrepYan48teXW8RyJyZVPGsEmEUjNUIE8 4OD9Z8lnz5D+WrzJ6K0J9DZi46WqcNT0elRvvemp2YyDC761+V9noFAHDVH8ZZ9fhVKC /Iqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=pt5rKWcz7qj6e/Uv9/6XAlEO0zulJkwe/I8I73dMvrI=; fh=nmpqriIAxzz9z4/piqOabUsFkiEK8VDv7G5j+pvfHas=; b=CyDRMzzlkrKXTXoCObFkb2YuLP9GmYkPNv3wPXoe6pGr4vvKDD6w8zhOKqHqS/I22K /rD3KAHAs+NefCo+sp96UL3o6zw7l51vSNOKoGx6NSCkmDFjxc0n93YobxUSxPRMppdK PCwB7NXnj+hjE3s+vKQIpbCnSIxn/Ovd7tjIJ88vEMhJQW0xzUano6ixpRFk/7zHUwrB cbXTSh75FBvOPS06eNJ4Xz9KtrpcpNBGNPh5o4tNWIf2/1bsGRuo3BlB/y5lFfEBZiBO 0cJ6VrpM9UYRD17/L/Up8opCyvir0SABZ/gyjvnHRgcv5cRRLg0GyeNOuegDWPvMJGcj ZCpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="mSKaxI/p"; spf=pass (google.com: domain of linux-kernel+bounces-12758-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12758-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id k4-20020a67fd84000000b00466f6c703cesi1062201vsq.186.2023.12.28.07.32.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 07:32:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12758-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="mSKaxI/p"; spf=pass (google.com: domain of linux-kernel+bounces-12758-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12758-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4A7BD1C21FEF for ; Thu, 28 Dec 2023 15:32:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADFDB1078E; Thu, 28 Dec 2023 15:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mSKaxI/p" X-Original-To: linux-kernel@vger.kernel.org Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDB59101C8; Thu, 28 Dec 2023 15:32:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3BSFUgrh100508; Thu, 28 Dec 2023 09:30:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1703777443; bh=pt5rKWcz7qj6e/Uv9/6XAlEO0zulJkwe/I8I73dMvrI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=mSKaxI/p0aCDh2p+IOpxl8kr6LIZoA8Z50jeeffRHB0uehahZH8j2jE9rgiIsv/w2 YJhuIfCdvdA/WRPGX5ihdjHfWw44/MaLE6n0ZqlLTD29aPDPeB7AjrRQzyQsMwbeOr 1EcdqI927coRTqrx6ftKHTOurd+/Sj1BVdsyuzDI= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3BSFUgPB030577 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 Dec 2023 09:30:42 -0600 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 28 Dec 2023 09:30:42 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 28 Dec 2023 09:30:42 -0600 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.161.188]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3BSFUSKn116497; Thu, 28 Dec 2023 09:30:36 -0600 From: Shenghao Ding To: , , CC: , , , , , , , , <13916275206@139.com>, , , , , , , , Shenghao Ding Subject: [PATCH v4 2/4] ASoC: tas2562: move tas2563 from tas2562 driver to tas2781 driver Date: Thu, 28 Dec 2023 23:30:21 +0800 Message-ID: <20231228153024.1659-2-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20231228153024.1659-1-shenghao-ding@ti.com> References: <20231228153024.1659-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786540265541231331 X-GMAIL-MSGID: 1786540265541231331 Move tas2563 from tas2562 driver to tas2781 driver to unbind tas2563 from tas2562 driver code and bind it to tas2781 driver code, because tas2563 only work in bypass-DSP mode with tas2562 driver. In order to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder dooes is to parse the firmware and download it to the chip, then power on the chip. So, tas2781 driver can be resued as tas2563 driver. Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding --- Change in v4: - Move tas2563 from tas2562 driver to tas2781 driver. - Add more comments on why move tas2563 to tas2781 driver. - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. --- sound/soc/codecs/tas2562.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 962c2cdfa017..54561ae598b8 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -59,7 +59,6 @@ struct tas2562_data { enum tas256x_model { TAS2562, - TAS2563, TAS2564, TAS2110, }; @@ -721,7 +720,6 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562) static const struct i2c_device_id tas2562_id[] = { { "tas2562", TAS2562 }, - { "tas2563", TAS2563 }, { "tas2564", TAS2564 }, { "tas2110", TAS2110 }, { } @@ -770,7 +768,6 @@ static int tas2562_probe(struct i2c_client *client) #ifdef CONFIG_OF static const struct of_device_id tas2562_of_match[] = { { .compatible = "ti,tas2562", }, - { .compatible = "ti,tas2563", }, { .compatible = "ti,tas2564", }, { .compatible = "ti,tas2110", }, { },