From patchwork Thu Dec 28 15:06:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Liu X-Patchwork-Id: 183757 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp2048794dyb; Thu, 28 Dec 2023 07:08:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFp/hS4W3Jlu/oVWR07cYbV/Mg4An1I64sl5steKurvHKnRkeV8Qbk24lzjmJhrR6Gcfs9U X-Received: by 2002:a05:651c:1684:b0:2cc:811f:f9ae with SMTP id bd4-20020a05651c168400b002cc811ff9aemr3812031ljb.47.1703776085795; Thu, 28 Dec 2023 07:08:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703776085; cv=none; d=google.com; s=arc-20160816; b=aoGlcnhoJ+SCwhwaxRXdeh8QhsNA0zYUXbAX3uYPNqzJ2BgVPP0nZxwkcKQYn2X4/E Pi5HWRaZhAGZnh2qWTOMRAwoORimpYRyC5SEcanP3yTxyPW1Sg4RmXa+L1f9y6yFJyme rFQxmdtIjY1aFTWL/LbiFqB4qdUh5PM+SA97Cl6TDQVjvSIOtBIMxwMbTdkMerNkrs8S vhYJDFOzAKWYXolHnxW8MKP2i+saDu4dDT2K4VY9D0HhZjnd1RjOHT+/lB8sSWqh58xt Ryxpi0176grgdWkJM8gSHvCluOgOhRYD1pjYMxXTLJFI/AakLzllYy28W2S7guptWX70 edpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=euG6NwFyvGpQyx4bY1dT20hCi7fPaxrH9e/fkW+iluU=; fh=JbgkfaGVOLJQIgFMcRSNKOzjVQFwxW1pSzjP6daOUwc=; b=Gz8bVlEWssc5I33ATzdXkys8ys9lI4ZcG+W3uLpcFwbeU8x6t+pudPCSjLTT/wfYZ8 TkHBwOUvA5zHsHCKpAWzk/E/W0ysbs4yqt+lvvVw0WOcPgFSfGtpc3Vedoi+DIuvS9P/ 2coxbcef09Fu7r16fWj7sIBNr1C2vxn0z/2tjrRz5n2ZxG/IlWcefCRvyXMDN6tMknFi eLaLWzq7YW+8qnISRy941L4nhS3/UfNJ9JOnEQp01HZcnrOfNmilxYQrvmWj7cFLtD6X x87lN55sYuGypRfk0RAWX1cS+YH5Qq9NBpwmd4UT6d9wdGK37kc1cFC6cxx9Y6xjzaK8 ItBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Iuo4r4gd; spf=pass (google.com: domain of linux-kernel+bounces-12729-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12729-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id j23-20020a508a97000000b00553a472e61esi7333062edj.404.2023.12.28.07.08.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 07:08:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12729-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Iuo4r4gd; spf=pass (google.com: domain of linux-kernel+bounces-12729-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12729-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6483F1F21DDB for ; Thu, 28 Dec 2023 15:08:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6E3810A05; Thu, 28 Dec 2023 15:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Iuo4r4gd" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98885D2FC; Thu, 28 Dec 2023 15:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703775997; x=1735311997; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=a0MtJfDdMrZSQXPjcVw/ypmtgFbBgW6CUZyjsKPTKtk=; b=Iuo4r4gd9snYlQG0bx4a9zV793nlDdGKWo2AAUq4Z0yP8BVQ0jBct2+r yTqDbXe68URphdnsR0S1cFGBScMpxwdajAjvFtZS/CmhIN7UtJkshflaJ lsYvVU5Qt9987EeLxYKlm6o4gVl2c014bAKUVyL2n8fQKMpw8+AtlrLvh rnjCPcRvDL9iG7gk/iZ5IczQKiRR0eEmu0UeXcn42/ButjR7RNTBV/dpb dOLoVeqQIHdV+kUhHTK6QS/0OiDpllx1AOuebwc+84GWjvbkGFWtVuWb6 GQuLt681Cg2TCjgnfuXicGn9yUVFv5pdyIE08A8bndl9+smzgpnFdQ1Eh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10936"; a="393701924" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="393701924" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 07:06:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10936"; a="869155167" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="869155167" Received: from 984fee00a4c6.jf.intel.com ([10.165.58.231]) by FMSMGA003.fm.intel.com with ESMTP; 28 Dec 2023 07:06:35 -0800 From: Yi Liu To: joro@8bytes.org, alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com, robin.murphy@arm.com, baolu.lu@linux.intel.com Cc: cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com, yi.l.liu@intel.com, yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com, shameerali.kolothum.thodi@huawei.com, lulu@redhat.com, suravee.suthikulpanit@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, zhenzhong.duan@intel.com, joao.m.martins@oracle.com, xin.zeng@intel.com, yan.y.zhao@intel.com, j.granados@samsung.com Subject: [PATCH v9 03/10] iommu: Add iommu_copy_struct_from_user_array helper Date: Thu, 28 Dec 2023 07:06:22 -0800 Message-Id: <20231228150629.13149-4-yi.l.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231228150629.13149-1-yi.l.liu@intel.com> References: <20231228150629.13149-1-yi.l.liu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786538713027665764 X-GMAIL-MSGID: 1786538713027665764 From: Nicolin Chen Wrap up the data pointer/num sanity and __iommu_copy_struct_from_user call for iommu drivers to copy driver specific data at a specific location in the struct iommu_user_data_array, and iommu_respond_struct_to_user_array() to copy response to a specific location in the struct iommu_user_data_array. And expect it to be used in cache_invalidate_user ops for example. Reviewed-by: Kevin Tian Signed-off-by: Nicolin Chen Co-developed-by: Yi Liu Signed-off-by: Yi Liu --- include/linux/iommu.h | 74 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 93c0d12dd047..c3434c9eaa6d 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -341,6 +341,80 @@ static inline int __iommu_copy_struct_from_user( sizeof(*kdst), \ offsetofend(typeof(*kdst), min_last)) +/** + * __iommu_copy_struct_from_user_array - Copy iommu driver specific user space + * data from an iommu_user_data_array + * @dst_data: Pointer to an iommu driver specific user data that is defined in + * include/uapi/linux/iommufd.h + * @src_array: Pointer to a struct iommu_user_data_array for a user space array + * @data_type: The data type of the @dst_data. Must match with @src_array.type + * @index: Index to the location in the array to copy user data from + * @data_len: Length of current user data structure, i.e. sizeof(struct _dst) + * @min_len: Initial length of user data structure for backward compatibility. + * This should be offsetofend using the last member in the user data + * struct that was initially added to include/uapi/linux/iommufd.h + */ +static inline int +__iommu_copy_struct_from_user_array(void *dst_data, + const struct iommu_user_data_array *src_array, + unsigned int data_type, unsigned int index, + size_t data_len, size_t min_len) +{ + struct iommu_user_data src_data; + + if (WARN_ON(!src_array || index >= src_array->entry_num)) + return -EINVAL; + if (!src_array->entry_num) + return -EINVAL; + src_data.uptr = src_array->uptr + src_array->entry_len * index; + src_data.len = src_array->entry_len; + src_data.type = src_array->type; + + return __iommu_copy_struct_from_user(dst_data, &src_data, data_type, + data_len, min_len); +} + +/** + * iommu_copy_struct_from_user_array - Copy iommu driver specific user space + * data from an iommu_user_data_array + * @kdst: Pointer to an iommu driver specific user data that is defined in + * include/uapi/linux/iommufd.h + * @user_array: Pointer to a struct iommu_user_data_array for a user space + * array + * @data_type: The data type of the @kdst. Must match with @user_array->type + * @index: Index to the location in the array to copy user data from + * @min_last: The last memember of the data structure @kdst points in the + * initial version. + * Return 0 for success, otherwise -error. + */ +#define iommu_copy_struct_from_user_array(kdst, user_array, data_type, \ + index, min_last) \ + __iommu_copy_struct_from_user_array(kdst, user_array, data_type, \ + index, sizeof(*kdst), \ + offsetofend(typeof(*kdst), \ + min_last)) + +/** + * iommu_respond_struct_to_user_array - Copy the response in @ksrc back to + * a specific entry of user array + * @user_array: Pointer to a struct iommu_user_data_array for a user space + * array + * @index: Index to the location in the array to copy response + * @ksrc: Pointer to kernel structure + * @klen: Length of @ksrc struct + * + * This only copies response of one entry (@index) in @user_array. + */ +static inline int +iommu_respond_struct_to_user_array(const struct iommu_user_data_array *array, + unsigned int index, void *ksrc, size_t klen) +{ + if (copy_to_user(array->uptr + array->entry_len * index, + ksrc, min_t(size_t, array->entry_len, klen))) + return -EFAULT; + return 0; +} + /** * struct iommu_ops - iommu ops and capabilities * @capable: check capability