Message ID | 20231228003444.5580-3-ivor@iwanders.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-12326-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1737748dyb; Wed, 27 Dec 2023 16:35:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGe4IOYMVxC/HfxPXjMiC+58ycg2lYgbIbiEgYDJzxPNMiZVd+tmT/YR4Z2DI63XoQ33vB8 X-Received: by 2002:a05:6870:224d:b0:1fb:75a:de75 with SMTP id j13-20020a056870224d00b001fb075ade75mr10993255oaf.99.1703723745748; Wed, 27 Dec 2023 16:35:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703723745; cv=none; d=google.com; s=arc-20160816; b=u5exKgFrAHOCoNTZyXqZMbxobCKsaMj4uNIrKRJYA/bWVhZXDjyY9segBt/6obs4mF 4jx91c9Fy3v0IJ7lnnV+IDAoVY58Amk0s5QHYuCaO2ymq8zbFwmOEMH4tjUj/4sQyGpW LwSuOFyN3HGPBSFXXuYxsZeHgmrXmkabPPKzNUD6kei29JooMMExa6LPVlij8Ltb1NwL IrNCgTEl2T9NqtjcMj/LcDx0bOimajG2xFZ1zP9rYvgeddeH8v6qE8QGT+RGawyhTH9Y DOwJKld93U4VmIvnNTZo9ff6BDljHWrErAL48NrRZVsPnrOpoUhFQ4UhZrJuuIhiq1H4 0DXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=jy4/hAbZIHHKviv5DRs0q6iojZt8AME5ln1+pcgK9ak=; fh=tmP3r8kdHnjto9t/Q2hyg0WZlGuk2h+t0yEFfDzt3ZM=; b=HuSdkg//Ko7Yr3kzkuEF44568/CToYqFlit0Dv5HQOPdraYdtpd1bKxqDJMXPtJ6sN PCp6l8ZXBtvUoU7mLbeQiYs079CLhLGnBWU4B9DU23Mlccd8Chb5QspONm/jsncKVn33 nHn5G67rfADcOAjqkjzvy9y7EzetH7ShIE1OmfcVViDi+XIKPmOq/lgNV+j0fZCVQCpz JK+MS9RCf6VGgPA7lhb8KwEyLabkUW+A69GnaCw191BwbN82Bn2xZP69p84/XKIqlKst miqoP13JsI0RoLjcc9I1xDpUQDdwL9zJ2izqXbQ2j9Cvvhh3h5N5THmBvA4vlcQwEXHg NiXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@iwanders.net header.s=google header.b=I9TZNyYe; spf=pass (google.com: domain of linux-kernel+bounces-12326-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12326-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id w11-20020a65410b000000b005c658c16acdsi11470344pgp.196.2023.12.27.16.35.45 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 16:35:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12326-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@iwanders.net header.s=google header.b=I9TZNyYe; spf=pass (google.com: domain of linux-kernel+bounces-12326-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12326-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C71DFB21C8C for <ouuuleilei@gmail.com>; Thu, 28 Dec 2023 00:35:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5114F3C3B; Thu, 28 Dec 2023 00:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b="I9TZNyYe" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6757310E6 for <linux-kernel@vger.kernel.org>; Thu, 28 Dec 2023 00:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iwanders.net Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-427d5bfe24cso23868181cf.1 for <linux-kernel@vger.kernel.org>; Wed, 27 Dec 2023 16:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iwanders.net; s=google; t=1703723697; x=1704328497; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=jy4/hAbZIHHKviv5DRs0q6iojZt8AME5ln1+pcgK9ak=; b=I9TZNyYe5/S7FkFaIFHZgCXcMf0SdrdwOI/+g/8VP/nmpXa+PJpRfFj5a5oTyGxNRx r/nmmVBNaFRrJHBdqwB2AZL4hY8O4MHwTzSa+bpC2wqKwpn5WpofFBfqdkHkpHOHaMCk P0WFDYRoy6JxEVTrEfegwsFSJ+VwLZ5qL4G1w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703723697; x=1704328497; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jy4/hAbZIHHKviv5DRs0q6iojZt8AME5ln1+pcgK9ak=; b=Tc1JHo15k6N2/gXRalE/Td810iSHLhyCnGSnigepASqbJ6iDbhclSkhUBb0BFwXG19 tbqmyXm9P2kqY1Wd1PVHtMW1/oGRFB1+3mIWHArCMWcvlOS8OD2S7NxgGY1jF3iink3V OiOwVL0nMncMlc2yY+ckQnsP076r+ZzJReE4gBiXZaBFO6XXoLYAUjabUMV37m/OX3ki X7+7RJFuRHtP/J/yY3MX4Puh9/I0vCGJM9hY4OoEShMgsLtW4Cnm8XGODWjsBB1zZhwB SZUv69rG2xOpulqvLCOUqd3DkjWNclK6gnJ4qQKx6XDx2fU32TRRX12OjfVVXa49/1Nn 3RAg== X-Gm-Message-State: AOJu0YwrnBKBJpRzJv5EH2Q69HKtell7gv1iwiJtzi9UgYvZ7jtzE6qQ MFsBzN8AJszGyhiga8hPkuZ/UFe5HcdxQg== X-Received: by 2002:a05:622a:1803:b0:41c:c8f2:58ce with SMTP id t3-20020a05622a180300b0041cc8f258cemr15594049qtc.27.1703723697440; Wed, 27 Dec 2023 16:34:57 -0800 (PST) Received: from eagle.lan (24-246-30-234.cable.teksavvy.com. [24.246.30.234]) by smtp.gmail.com with ESMTPSA id fb9-20020a05622a480900b004279315b3besm7710684qtb.0.2023.12.27.16.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 16:34:57 -0800 (PST) From: Ivor Wanders <ivor@iwanders.net> To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, Jonathan Corbet <corbet@lwn.net>, Maximilian Luz <luzmaximilian@gmail.com>, Ivor Wanders <ivor@iwanders.net>, Hans de Goede <hdegoede@redhat.com>, Mark Gross <markgross@kernel.org> Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v2 2/2] platform/surface: aggregator_registry: add entry for fan speed Date: Wed, 27 Dec 2023 19:34:44 -0500 Message-Id: <20231228003444.5580-3-ivor@iwanders.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231228003444.5580-1-ivor@iwanders.net> References: <20231228003444.5580-1-ivor@iwanders.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786483830332394848 X-GMAIL-MSGID: 1786483830332394848 |
Series |
Surface fan monitoring driver
|
|
Commit Message
Ivor Wanders
Dec. 28, 2023, 12:34 a.m. UTC
Add an entry for the fan speed function.
Add this new entry to the Surface Pro 9 group.
Signed-off-by: Ivor Wanders <ivor@iwanders.net>
Link: https://github.com/linux-surface/kernel/pull/144
---
Changes in v2:
- No changes in this patch.
---
drivers/platform/surface/surface_aggregator_registry.c | 7 +++++++
1 file changed, 7 insertions(+)
Comments
On 12/28/23 01:34, Ivor Wanders wrote: > Add an entry for the fan speed function. > Add this new entry to the Surface Pro 9 group. > > Signed-off-by: Ivor Wanders <ivor@iwanders.net> > Link: https://github.com/linux-surface/kernel/pull/144 > --- > Changes in v2: > - No changes in this patch. > --- > drivers/platform/surface/surface_aggregator_registry.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c > index 530db4db7..b0db25886 100644 > --- a/drivers/platform/surface/surface_aggregator_registry.c > +++ b/drivers/platform/surface/surface_aggregator_registry.c > @@ -74,6 +74,12 @@ static const struct software_node ssam_node_tmp_pprof = { > .parent = &ssam_node_root, > }; > > +/* Fan speed function. */ > +static const struct software_node ssam_node_fan_speed = { > + .name = "ssam:01:05:01:01:01", > + .parent = &ssam_node_root, > +}; I would prefer if we could keep the subsystem prefix for node names. So something like `ssam_node_tmp_fan_speed`. Otherwise, this looks good to me. With that changed: Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > + > /* Tablet-mode switch via KIP subsystem. */ > static const struct software_node ssam_node_kip_tablet_switch = { > .name = "ssam:01:0e:01:00:01", > @@ -319,6 +325,7 @@ static const struct software_node *ssam_node_group_sp9[] = { > &ssam_node_bat_ac, > &ssam_node_bat_main, > &ssam_node_tmp_pprof, > + &ssam_node_fan_speed, > &ssam_node_pos_tablet_switch, > &ssam_node_hid_kip_keyboard, > &ssam_node_hid_kip_penstash,
On 12/29/23 23:42, Maximilian Luz wrote: > On 12/28/23 01:34, Ivor Wanders wrote: >> Add an entry for the fan speed function. >> Add this new entry to the Surface Pro 9 group. >> >> Signed-off-by: Ivor Wanders <ivor@iwanders.net> >> Link: https://github.com/linux-surface/kernel/pull/144 >> --- >> Changes in v2: >> - No changes in this patch. >> --- >> drivers/platform/surface/surface_aggregator_registry.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c >> index 530db4db7..b0db25886 100644 >> --- a/drivers/platform/surface/surface_aggregator_registry.c >> +++ b/drivers/platform/surface/surface_aggregator_registry.c >> @@ -74,6 +74,12 @@ static const struct software_node ssam_node_tmp_pprof = { >> .parent = &ssam_node_root, >> }; >> +/* Fan speed function. */ >> +static const struct software_node ssam_node_fan_speed = { >> + .name = "ssam:01:05:01:01:01", >> + .parent = &ssam_node_root, >> +}; > > I would prefer if we could keep the subsystem prefix for node names. So > something like `ssam_node_tmp_fan_speed`. Please disregard that comment. Somehow I thought it's part of the TMP subsystem, but it's in its own FAN subsystem. So all is good. > Otherwise, this looks good to me. With that changed: > > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > >> + >> /* Tablet-mode switch via KIP subsystem. */ >> static const struct software_node ssam_node_kip_tablet_switch = { >> .name = "ssam:01:0e:01:00:01", >> @@ -319,6 +325,7 @@ static const struct software_node *ssam_node_group_sp9[] = { >> &ssam_node_bat_ac, >> &ssam_node_bat_main, >> &ssam_node_tmp_pprof, >> + &ssam_node_fan_speed, >> &ssam_node_pos_tablet_switch, >> &ssam_node_hid_kip_keyboard, >> &ssam_node_hid_kip_penstash,
diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c index 530db4db7..b0db25886 100644 --- a/drivers/platform/surface/surface_aggregator_registry.c +++ b/drivers/platform/surface/surface_aggregator_registry.c @@ -74,6 +74,12 @@ static const struct software_node ssam_node_tmp_pprof = { .parent = &ssam_node_root, }; +/* Fan speed function. */ +static const struct software_node ssam_node_fan_speed = { + .name = "ssam:01:05:01:01:01", + .parent = &ssam_node_root, +}; + /* Tablet-mode switch via KIP subsystem. */ static const struct software_node ssam_node_kip_tablet_switch = { .name = "ssam:01:0e:01:00:01", @@ -319,6 +325,7 @@ static const struct software_node *ssam_node_group_sp9[] = { &ssam_node_bat_ac, &ssam_node_bat_main, &ssam_node_tmp_pprof, + &ssam_node_fan_speed, &ssam_node_pos_tablet_switch, &ssam_node_hid_kip_keyboard, &ssam_node_hid_kip_penstash,