| Message ID | 20231227130812.148914-1-eugen.hristev@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-12029-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id
tb2csp1420052dyb;
Wed, 27 Dec 2023 05:09:00 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IHpVLJgenbtMhFbSjBVY3eqkfQ0Esn6XFA3bBGSND0SNzm2No/UyG5hmT/A09T50TO3gY3O
X-Received: by 2002:a05:6512:473:b0:50e:70b1:d19d with SMTP id
x19-20020a056512047300b0050e70b1d19dmr2269020lfd.40.1703682539858;
Wed, 27 Dec 2023 05:08:59 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1703682539; cv=none;
d=google.com; s=arc-20160816;
b=SWAsNZ64E9ZVWFRARzKowLnzHI/kvyZwQTtwZaISr47QVoZb2d+j6924+vmki7fCfU
9KbgXVmFi7loNGB4my9eS0qmJmXqBCUfaJjFnveQl9D9BShSV8To7EgHvLEwHMNnIURF
N3vcF9BBrwdh8qFH2bKVDbb5Ez0QY0xwV19qCWj3ELFH44jEBmKA3BW15X7wLbOhCzVn
BNp/HK07dBUVEfWnct4hJILTppf3u07cBd0I17g50/kspuyWgfdqQERrvrXjIlBxwww6
dfF3d4VG4kig1A0zYhM3QkU4C0vv/hum0SGT1H6LFChWEAwVAYuGDLAc2vkLfFI4X7Ut
JFeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from:dkim-signature;
bh=TdS2SB8gqiKhHo2Q4/XiohnvYlRC2A8bxQwPxFGJ3MU=;
fh=skqBY4aibWdVUoKoxGGhlGaBOXS9f66RznzprIRdV3I=;
b=Oq/RG85Ets2hqR6nCdEbSINSL5gRvf4qh4mAGzQKrgyXGu7MAgj2HEq6Gt+lH5Myw/
2zlLzCowuN5gsNmN3ooLuAmkwD1MdLc0hqcdP30Ivdy3FQLno/cQ6uv6aRe03wwfbkTT
QWCicJGCr+dvbgohemmS2RPjiIebyXm1qVSq2ZkGFwuTSBaQtKroqYkw9P9voPytF7Vg
G1C/5Va63Wkmqj0zTu9QJX+HPMmtJqv2Xs/cJ3EjXte9XP09R6CMadPi13IVNPhHZsH4
mV26Dk941vtC3xZULC+xYBRjV76+1RDS9SbAGHWsi3PQM+nFrga42WCKneFPFjmxSJLC
GUfA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=LE8nW6o9;
spf=pass (google.com: domain of
linux-kernel+bounces-12029-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-12029-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org.
[2604:1380:4601:e00::3])
by mx.google.com with ESMTPS id
t26-20020a50d71a000000b00553044cd2f7si6248677edi.451.2023.12.27.05.08.59
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 27 Dec 2023 05:08:59 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-12029-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=LE8nW6o9;
spf=pass (google.com: domain of
linux-kernel+bounces-12029-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-12029-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by am.mirrors.kernel.org (Postfix) with ESMTPS id 781AE1F2209D
for <ouuuleilei@gmail.com>; Wed, 27 Dec 2023 13:08:59 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 6777045943;
Wed, 27 Dec 2023 13:08:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com
header.b="LE8nW6o9"
X-Original-To: linux-kernel@vger.kernel.org
Received: from madrid.collaboradmins.com (madrid.collaboradmins.com
[46.235.227.194])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493EC44C62;
Wed, 27 Dec 2023 13:08:23 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=collabora.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=collabora.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1703682501;
bh=jvUeOk62psQZsbMdkKVZNNNG5A+qB2Z6aEW45S/4p1Q=;
h=From:To:Cc:Subject:Date:From;
b=LE8nW6o9iLpxjsx2UDxC4w8bFvUiqBCbUaSLGN2QHFcV7Wvo3xQgjPQXLOdfJxYC1
e9razMUHVWO2kNDJZJA8djvpDFNJdNPgGKJ15oohl2rupU12EPGneHtvm2rwuFT8Un
iRw1ay/k+rjsCP6nc0VtHVpc3LA3yA+IKVdVMGvRSTKboJqy4FuEs/LqjTZ0WgV3zG
l2x3agZGwT7bEJ2muGWT+J2QP8ykOAGZqxQbQqLnL9ACZKfiHIEl72DcudVTqXklKV
ck7km5lP3naUFlSAOTHnnKSgHLKfGHnzOS6YAfbVP0Elw9NUjOydzd6cDkRgJXWC4E
MdXJdsUQdV6Tg==
Received: from eugen-station.. (cola.collaboradmins.com [195.201.22.229])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest
SHA256)
(No client certificate requested)
(Authenticated sender: ehristev)
by madrid.collaboradmins.com (Postfix) with ESMTPSA id C56A237801C1;
Wed, 27 Dec 2023 13:08:20 +0000 (UTC)
From: Eugen Hristev <eugen.hristev@collabora.com>
To: bin.liu@mediatek.com,
matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Eugen Hristev <eugen.hristev@collabora.com>
Subject: [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max
ioomus count
Date: Wed, 27 Dec 2023 15:08:11 +0200
Message-Id: <20231227130812.148914-1-eugen.hristev@collabora.com>
X-Mailer: git-send-email 2.34.1
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1786440622681471856
X-GMAIL-MSGID: 1786440622681471856
|
| Series |
[1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count
|
|
Commit Message
Eugen Hristev
Dec. 27, 2023, 1:08 p.m. UTC
MT8186 has 4 iommus in the list, to cope with this situation, adjust
the maxItems to 4 (instead of previous 2).
Add also minItems as 1 since iommus are mandatory, to avoid warning
on the example.
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
.../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Il 27/12/23 14:08, Eugen Hristev ha scritto: > MT8186 has 4 iommus in the list, to cope with this situation, adjust > the maxItems to 4 (instead of previous 2). > Add also minItems as 1 since iommus are mandatory, to avoid warning > on the example. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > .../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml > index 37800e1908cc..60c75b9312e8 100644 > --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml > @@ -38,7 +38,8 @@ properties: > maxItems: 1 > > iommus: > - maxItems: 2 > + minItems: 1 > + maxItems: 4 > description: | > Points to the respective IOMMU block with master port as argument, see > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details. (commit title) `ioomus` is something I've never heard of before... :-P Please fix the typo, after which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote: > MT8186 has 4 iommus in the list, to cope with this situation, adjust > the maxItems to 4 (instead of previous 2). > Add also minItems as 1 since iommus are mandatory, to avoid warning > on the example. maxItems alone means minItems is the same size. If IOMMU is required, then 'required' is where that is defined. Is there a case where 1 IOMMU is valid? If so, what h/w has this case. Rob
On 1/9/24 05:27, Rob Herring wrote: > On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote: >> MT8186 has 4 iommus in the list, to cope with this situation, adjust >> the maxItems to 4 (instead of previous 2). >> Add also minItems as 1 since iommus are mandatory, to avoid warning >> on the example. > > maxItems alone means minItems is the same size. If IOMMU is required, > then 'required' is where that is defined. Is there a case where 1 IOMMU > is valid? If so, what h/w has this case. > > Rob > > Hello Rob, Without setting a minItems , the example in the binding fails, because it has just 2 items, while the maxItems is now 4. I set minItems as 1 to avoid restricting any kind of hardware to have at least 2 items, but if you claim that previously, maxItems=minItems=2 , I will change this to 2. Is that fine with you ? Eugen
On 15/01/2024 04:57, Eugen Hristev wrote: > On 1/9/24 05:27, Rob Herring wrote: >> On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote: >>> MT8186 has 4 iommus in the list, to cope with this situation, adjust >>> the maxItems to 4 (instead of previous 2). >>> Add also minItems as 1 since iommus are mandatory, to avoid warning >>> on the example. >> >> maxItems alone means minItems is the same size. If IOMMU is required, >> then 'required' is where that is defined. Is there a case where 1 IOMMU >> is valid? If so, what h/w has this case. >> >> Rob >> >> > > Hello Rob, > > Without setting a minItems , the example in the binding fails, because it has just > 2 items, while the maxItems is now 4. > I set minItems as 1 to avoid restricting any kind of hardware to have at least 2 > items, but if you claim that previously, maxItems=minItems=2 , I will change this to 2. > Is that fine with you ? > I think that's what you should do yes. If in the future there shows up a platform with just one iommu, then we can fix that. Regards, Matthias
diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml index 37800e1908cc..60c75b9312e8 100644 --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml @@ -38,7 +38,8 @@ properties: maxItems: 1 iommus: - maxItems: 2 + minItems: 1 + maxItems: 4 description: | Points to the respective IOMMU block with master port as argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.