Message ID | 20231227090448.2216295-2-treapking@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-11922-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1320642dyb; Wed, 27 Dec 2023 01:05:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwSLwAdM+8lFptUS3O69Thn4ohXoCB1K0S5/43eiTKYJHVsnURJqpdWpj+tgJ2uHcRW7cg X-Received: by 2002:a50:8adc:0:b0:554:36d8:564e with SMTP id k28-20020a508adc000000b0055436d8564emr6013939edk.7.1703667931117; Wed, 27 Dec 2023 01:05:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703667931; cv=none; d=google.com; s=arc-20160816; b=cMFw1VvZt/s7Of6yBw8zRg6zltvMXoef3NuRnhsxn6d64fdCcdh4klAmVI8PxoIsZ1 pXgg6gbe5OhbiWh5WyDNeKJZ+xzxNJ4VeGpJCzvajNufPTku5OXzA8molg7b4SQ/Tnkf 8y15SZuR0QyzFVeaJ/jfARiFRG4dzEtyA72kced4FC+gUKr5duBewHZBaevIcZKgRhDn ZUUChiBuZ+wAFNM9s5bsmjp5Bb9K9DmB9/eJ+0c22uNGPyA90+gg0QAKSaJnVlL+/Hlw T2gMP69LX+ENzJQnw2IBA2pUk8Va9XLsxkuyKTkewreS0ROq0NkbwSrlnJS0KuMU+zYM AT9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=UqybA8kGXGwS0p6VfCaZS7VsH26LSz7rBgi0KXqcQ7I=; fh=+E9rH+H4HaQ4qmW57m/nA4Lfvd5mHH6hVIx4JbxsYqc=; b=R9uwBFc6bZ9Ht6a1zHJh044h67Tde9glUyjWqXFeF+eFGK4iX/x9Ztn+a7TraNoHbC CfycBIsbnwfCRnDyi2JrXHrjAc6pb9MaAbCkHQQDasaFP9H7FdyEcLBKAifcLpQQSUSF ALYFIotwkagCduOYsKNlm7amaFQhj0cNnG9GtJnUypFkCb0njD2dVKkYsfEKAI94pOtM 9lLcnTl7KS8HQLksHyT8UQyuTdCuXpGmjeiBntfLoO+3rwlcEEYD+AOjg16VRN19gmFM ww/5S2Li7x1HSKKg69E0+jhd3skfET1AYqnqYGF9czbDnn5N5j4mEXw4ACMYym5RXAFD OF1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eDIFHZLL; spf=pass (google.com: domain of linux-kernel+bounces-11922-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11922-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gy1-20020a0564025bc100b00553501720d4si6279010edb.432.2023.12.27.01.05.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 01:05:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11922-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eDIFHZLL; spf=pass (google.com: domain of linux-kernel+bounces-11922-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11922-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B96771F22DC7 for <ouuuleilei@gmail.com>; Wed, 27 Dec 2023 09:05:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3954C2CCDF; Wed, 27 Dec 2023 09:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eDIFHZLL" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C1C24B3C for <linux-kernel@vger.kernel.org>; Wed, 27 Dec 2023 09:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5c21e185df5so3793797a12.1 for <linux-kernel@vger.kernel.org>; Wed, 27 Dec 2023 01:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703667905; x=1704272705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UqybA8kGXGwS0p6VfCaZS7VsH26LSz7rBgi0KXqcQ7I=; b=eDIFHZLL0FxF5QSvJLxK1ALZKQCI/hE75enT1/3GkrZ/L/8nII7yLLlHhm/sgoExEB 08K8nohMfsKziIn/MCqY82WE+dGuMjhMPw+4IIS7I5Z4GfLX2alWhfgYGggSbPKDtIwm Kr5O3lh3AJQqpPr5H4/aKgrvGcST5NzJ4oFdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703667905; x=1704272705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UqybA8kGXGwS0p6VfCaZS7VsH26LSz7rBgi0KXqcQ7I=; b=L4epcc3m7+X/U3Y4tGaloASTHLiDK7iXTy0qtowPG7MRa56afQXjUP0sYg4QaGjkyT UjZrpY0uJE7M+IQRCWzjhCcRW4bhgP7Ju6h9bvUcXw7PAjxozdYKrZ+VcinXTJ7SDWPh ZJz2iQW3J3F6iBLKNJe4vS35xEHXkWCV6BXbHsaLlrxQIY2v8pMIZc6BgbKtxjQuiBlZ KNJ9vhxvR0eNjZF7Lms1d6iBqCPflYFzvjRbThwHpelSsnTUSnXx/WwGlufC0QkpJuNZ i89JgCiU0o+es6AL0aWxA7+8HBb0L7DzuD2dZDqPZi/W9IH7Fdzv/J0hvvjAfGwiRjTE DYjQ== X-Gm-Message-State: AOJu0YyCDiHAt2P3RwX6poXidl5+jgCRKHUDHP9DQWNa6WP80xofKAJ8 QWdM1eds2OROq4lZn2vI6oXg44PYG26zTrLFUpbhqOy1ew== X-Received: by 2002:a05:6a20:938d:b0:196:2c8b:9f21 with SMTP id x13-20020a056a20938d00b001962c8b9f21mr200388pzh.112.1703667905699; Wed, 27 Dec 2023 01:05:05 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:18d2:7869:e8b9:f4e4]) by smtp.gmail.com with ESMTPSA id v22-20020a056a00149600b006d9b65d1a8esm5347701pfu.28.2023.12.27.01.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 01:05:05 -0800 (PST) From: Pin-yen Lin <treapking@chromium.org> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Pin-yen Lin <treapking@chromium.org>, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai <wenst@chromium.org>, linux-kernel@vger.kernel.org, Weiyi Lu <weiyi.lu@mediatek.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] clk: mediatek: mt8183: Enable need_runtime_pm on mt8183-mfgcfg Date: Wed, 27 Dec 2023 17:04:43 +0800 Message-ID: <20231227090448.2216295-2-treapking@chromium.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231227090448.2216295-1-treapking@chromium.org> References: <20231227090448.2216295-1-treapking@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786425304501847436 X-GMAIL-MSGID: 1786425304501847436 |
Series |
[1/2] clk: mediatek: Introduce need_pm_runtime to mtk_clk_desc
|
|
Commit Message
Pin-yen Lin
Dec. 27, 2023, 9:04 a.m. UTC
mt8183-mfgcfg has a mutual dependency with genpd during the probing
stage, so enable need_runtim_pm to prevent a deadlock in the following
call stack:
CPU0: genpd_lock --> clk_prepare_lock
genpd_power_off_work_fn()
genpd_lock()
generic_pm_domain::power_off()
clk_unprepare()
clk_prepare_lock()
CPU1: clk_prepare_lock --> genpd_lock
clk_register()
__clk_core_init()
clk_prepare_lock()
clk_pm_runtime_get()
genpd_lock()
Do a runtime PM get at the probe function to make sure clk_register()
won't acquire the genpd lock.
Fixes: acddfc2c261b ("clk: mediatek: Add MT8183 clock support")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
drivers/clk/mediatek/clk-mt8183-mfgcfg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/mediatek/clk-mt8183-mfgcfg.c b/drivers/clk/mediatek/clk-mt8183-mfgcfg.c index ba504e19d420..62d876e150e1 100644 --- a/drivers/clk/mediatek/clk-mt8183-mfgcfg.c +++ b/drivers/clk/mediatek/clk-mt8183-mfgcfg.c @@ -29,6 +29,7 @@ static const struct mtk_gate mfg_clks[] = { static const struct mtk_clk_desc mfg_desc = { .clks = mfg_clks, .num_clks = ARRAY_SIZE(mfg_clks), + .need_runtime_pm = true, }; static const struct of_device_id of_match_clk_mt8183_mfg[] = {