| Message ID | 20231226122113.v3.7.I06b059021de1bf6103e60a73211f078f2af75d17@changeid |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-11635-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id
tb2csp1056108dyb;
Tue, 26 Dec 2023 11:24:25 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IHh1SgbVFjc1h2ZcMBcCiFbuXUxAYBrMCUWIjW2YLeReMOtlsqIHVSDxsk8vVJl6y60P1Uh
X-Received: by 2002:a17:906:295:b0:a0c:46b4:a705 with SMTP id
21-20020a170906029500b00a0c46b4a705mr3068205ejf.56.1703618665461;
Tue, 26 Dec 2023 11:24:25 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1703618665; cv=none;
d=google.com; s=arc-20160816;
b=P7LZWf86v1zK2gO3BFyWXF5XYc71wpOsogBii2AT/D1lRYbFMbG7eLukRD91HLQ2HA
+plyhDeEJ+Bgx9/rESqC9K4anyWobyFHGvsQs+J1guwbg5YVGwTPdmXu0f6UcVnyXPyZ
LKG0C/1/5A4RlHRvGhB+6O2qsLjYn/6mxwoXwiUiZiVizODyjV6pOSFveAe+wXTGmEbl
ErRWZTnbCEkMY0N9Y61bUz2K6ZaUgj4VPhh8+uKOkq8ztT0/BcDk02iSty6KiC8Aw3KS
g2onCNuTw1+jYFRKFsYv1DYkCMwlJDTckl5TN5djHwiXGaFT9E8QlXqEYyGdLofTf3d3
V77w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=thrF0ILWTbiGFQaiH41yQtWJ81V5Pd2rM8k0MkABtdQ=;
fh=X7e+T2TQZni0RkVvD/Xx9UFi2V894yZdvU15QxiScXQ=;
b=F1JabiLgMXADwiFZirIizZ1qpLKqyzNWmf2cFakt5k/vw17EKvESXvFIo7Q+5cph3M
bZ4tQY4Nx80a4og2JiGC97lIuhYcyC3SOgmlYriUG6uNjh2GD6SZ5WXt+a1+x1CteFa1
U99MKjz7gSyASBylJ9AbgWTRcM1Ey5O3QWtW5o63Vh5r3U6MxJ9IHi5WZR/7Aq3Pcmoz
QlpjcaQa/lIJzsqI6zx+8XbzdSXyDf0jzWQEuoRkTUkCFl4phAuQJeoj+NXSCdqnX9uq
ScCVfdeEaQLuebKcGpKYCxPcjO4+l4jWyezDJl85wqYxsu8EzA5miGpSTgvep334Kwme
J2Zg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@chromium.org header.s=google header.b=lKxoWkTJ;
spf=pass (google.com: domain of
linux-kernel+bounces-11635-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-11635-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org.
[2604:1380:4601:e00::3])
by mx.google.com with ESMTPS id
l3-20020a1709067d4300b00a26cd8c3628si3510071ejp.92.2023.12.26.11.24.25
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 26 Dec 2023 11:24:25 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-11635-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Authentication-Results: mx.google.com;
dkim=pass header.i=@chromium.org header.s=google header.b=lKxoWkTJ;
spf=pass (google.com: domain of
linux-kernel+bounces-11635-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-11635-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by am.mirrors.kernel.org (Postfix) with ESMTPS id 18CF71F21E02
for <ouuuleilei@gmail.com>; Tue, 26 Dec 2023 19:24:25 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 395B7134C0;
Tue, 26 Dec 2023 19:22:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org
header.b="lKxoWkTJ"
X-Original-To: linux-kernel@vger.kernel.org
Received: from mail-io1-f51.google.com (mail-io1-f51.google.com
[209.85.166.51])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D68E1096D
for <linux-kernel@vger.kernel.org>; Tue, 26 Dec 2023 19:22:09 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=chromium.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=chromium.org
Received: by mail-io1-f51.google.com with SMTP id
ca18e2360f4ac-7b7fdde8b26so206716739f.1
for <linux-kernel@vger.kernel.org>;
Tue, 26 Dec 2023 11:22:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google; t=1703618528; x=1704223328;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=thrF0ILWTbiGFQaiH41yQtWJ81V5Pd2rM8k0MkABtdQ=;
b=lKxoWkTJ/tP5Ccz3HNM0UnoM+TK+LTRVr9GmxUZK+TzKAdbpKeT1vro64k64+VAD0O
pFsaD+qJ9rUO9HSij2yaqD0zU7YDSz+y5YOiDPwLPZue/2B8gAySVSodZV9JmoP/bvOd
fvFknw0VpFuiJ6HCvqCtHhj86sVge+WwnegFI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1703618528; x=1704223328;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=thrF0ILWTbiGFQaiH41yQtWJ81V5Pd2rM8k0MkABtdQ=;
b=dXxCKfpRb01Pf7HKEMIYZRO6eYPti7PPBrdAATBxX6oK3LWi4iLapW0mp4h9mCnmwY
6tsvq8jxr0P/ScGA2CYNxmJEL+EpmE8aw0TYlZBril2RtY8dxa3v1g093qvI2xCg5khJ
7V7voxnpYRrvu9m0sVQLcaUVGzFJD/2sLRiM6LuDDMNiB3h1kY+LwUZwinTxoTvZRVFd
hmxyQJ7XT+HmfXb3FFhqiOWJOek938YHpp3vpP8Eqw80f+8/ZHQk+GP0Tpwfa01JZ76X
n9ULyyK+kEcb4jakPdeO/ntg+xuPI8pYwFjdu8sBhycV/CjQ7am7iqRcAgTpeCc2ZKMj
Mgtw==
X-Gm-Message-State: AOJu0Yy1rI0mjkq46hEJ5iu6BrQEJPQFhvVIooCgT1dFH/1t0K/eyvT+
tJDxESOhhfnSBAbxO/Ti7ebw/MK9gtyJjL+rdeKJYSNbl50q
X-Received: by 2002:a05:6602:3f8f:b0:7ba:9784:d96f with SMTP id
fb15-20020a0566023f8f00b007ba9784d96fmr11764777iob.20.1703618528314;
Tue, 26 Dec 2023 11:22:08 -0800 (PST)
Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136])
by smtp.gmail.com with ESMTPSA id
gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.07
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 26 Dec 2023 11:22:08 -0800 (PST)
From: Mark Hasemeyer <markhas@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Raul Rangel <rrangel@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Mark Hasemeyer <markhas@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 07/24] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as
wake source
Date: Tue, 26 Dec 2023 12:21:11 -0700
Message-ID:
<20231226122113.v3.7.I06b059021de1bf6103e60a73211f078f2af75d17@changeid>
X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog
In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org>
References: <20231226192149.1830592-1-markhas@chromium.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1786373645735426190
X-GMAIL-MSGID: 1786373645735426190
|
| Series |
Improve IRQ wake capability reporting and update the cros_ec driver to use it
|
|
Commit Message
Mark Hasemeyer
Dec. 26, 2023, 7:21 p.m. UTC
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts | 1 +
1 file changed, 1 insertion(+)
Comments
On 26/12/2023 20:21, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. > > Some Chromebooks use a separate wake pin, while others overload the > interrupt for wake and IO. With the current assumption, spurious wakes > can occur on systems that use a separate wake pin. It is planned to > update the driver to no longer assume that the EC interrupt pin should > be enabled for wake. > > Add the wakeup-source property to all cros-ec-spi compatible device > nodes to signify to the driver that they should still be a valid wakeup > source. > > -Commit-changes: 3 This looks like changelog, although a bit confusing. If it is changelog, then please keep it under ---. I can fix it while applying, but this will be after the merge window. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts index 4e757b6e28e1c..3759742d38cac 100644 --- a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts @@ -967,6 +967,7 @@ cros_ec: cros-ec@0 { reg = <0>; spi-max-frequency = <3125000>; google,has-vbc-nvram; + wakeup-source; controller-data { samsung,spi-feedback-delay = <1>;